linux-toradex.git/kernel/trace/trace_kprobe.c, branch v2.6.33.1

tracing/kprobes: Fix probe parsing

2010-02-14T08:43:58+00:00

Trying to add a probe like:

  echo p:myprobe 0x10000 > /sys/kernel/debug/tracing/kprobe_events

will fail since the wrong pointer is passed to strict_strtoul
when trying to convert the address to an unsigned long.

Signed-off-by: Heiko Carstens 
Acked-by: Masami Hiramatsu 
Cc: Frederic Weisbecker 
Cc: Steven Rostedt 
LKML-Reference: <20100210162346.GA6933@osiris.boeblingen.de.ibm.com>
Signed-off-by: Ingo Molnar

Merge branch 'tracing-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-12-31T19:52:01+00:00

* 'tracing-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  tracing: Fix sign fields in ftrace_define_fields_##call()
  tracing/syscalls: Fix typo in SYSCALL_DEFINE0
  tracing/kprobe: Show sign of fields in trace_kprobe format files
  ksym_tracer: Remove trace_stat
  ksym_tracer: Fix race when incrementing count
  ksym_tracer: Fix to allow writing newline to ksym_trace_filter
  ksym_tracer: Fix to make the tracer work
  tracing: Kconfig spelling fixes and cleanups
  tracing: Fix setting tracer specific options
  Documentation: Update ftrace-design.txt
  Documentation: Update tracepoint-analysis.txt
  Documentation: Update mmiotrace.txt

tracing/kprobe: Show sign of fields in trace_kprobe format files

2009-12-30T15:27:03+00:00

The format files of trace_kprobe do not show the sign of the fields.
The other format files show the field signed type of the fields and
this patch makes the trace_kprobe formats consistent with the others.

Signed-off-by: Lai Jiangshan 
LKML-Reference: <4B273D27.5040009@cn.fujitsu.com>
Acked-by: Masami Hiramatsu 
Signed-off-by: Steven Rostedt

kprobe-tracer: Check new event/group name

2009-12-17T08:42:44+00:00

Check new event/group name is same syntax as a C symbol. In other
words, checking the name is as like as other tracepoint events.

This can prevent user to create an event with useless name (e.g.
foo|bar, foo*bar).

Signed-off-by: Masami Hiramatsu 
Cc: Frederic Weisbecker 
Cc: Paul Mackerras 
Cc: Arnaldo Carvalho de Melo 
Cc: Steven Rostedt 
Cc: Jim Keniston 
Cc: Ananth N Mavinakayanahalli 
Cc: Christoph Hellwig 
Cc: Jason Baron 
Cc: K.Prasad 
Cc: Peter Zijlstra 
Cc: Srikar Dronamraju 
Cc: systemtap 
Cc: DLE 
LKML-Reference: <20091216222408.14459.68790.stgit@dhcp-100-2-132.bos.redhat.com>
[ v2: minor cleanups ]
Signed-off-by: Ingo Molnar

Merge branch 'linus' into tracing/urgent

2009-12-14T08:16:49+00:00

Conflicts:
	kernel/trace/trace_kprobe.c

Merge reason: resolve the conflict.

Signed-off-by: Ingo Molnar

tracing: Change event->profile_count to be int type

2009-12-13T17:37:28+00:00

Like total_profile_count, struct ftrace_event_call::profile_count
is protected by event_mutex, so it doesn't need to be atomic_t.

Signed-off-by: Li Zefan 
Acked-by: Steven Rostedt 
Cc: Jason Baron 
Cc: Masami Hiramatsu 
Cc: Peter Zijlstra 
LKML-Reference: <4B1DC549.5010705@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker

tracing: Pull up calls to trace_define_common_fields()

2009-12-13T17:34:23+00:00

Call trace_define_common_fields() in event_create_dir() only.
This avoids trace events to handle it from their define_fields
callbacks and shrinks the kernel code size:

   text    data     bss     dec     hex filename
5346802 1961864 7103260 14411926         dbe896 vmlinux.o.old
5345151 1961864 7103260 14410275         dbe223 vmlinux.o

Signed-off-by: Li Zefan 
Acked-by: Steven Rostedt 
Cc: Ingo Molnar 
Cc: Jason Baron 
Cc: Masami Hiramatsu 
LKML-Reference: <4B1DC49C.8000107@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker

tracing/kprobes: Fix field creation's bad error handling

2009-12-09T09:32:21+00:00

When we define the common event fields in kprobe, we invert the error
handling and return immediately in case of success. Then we omit
to define specific kprobes fields (ip and nargs), and specific
kretprobes fields (func, ret_ip, nargs). And we only define them
when we fail to create common fields.

The most visible consequence is that we can't create filter for
k(ret)probes specific fields.

This patch re-invert the success/error handling to fix it.

Reported-by: Lai Jiangshan 
Signed-off-by: Frederic Weisbecker 
Acked-by: Masami Hiramatsu 
Cc: Steven Rostedt 
Cc: Li Zefan 
LKML-Reference: <1260263815-5167-1-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar

trace-kprobe: Support delete probe syntax

2009-12-09T06:26:53+00:00

Support delete probe syntax. The syntax is "-:[group/]event".

Signed-off-by: Masami Hiramatsu 
Cc: Steven Rostedt 
Cc: Jim Keniston 
Cc: Ananth N Mavinakayanahalli 
Cc: Christoph Hellwig 
Cc: Frank Ch. Eigler 
Cc: Frederic Weisbecker 
Cc: Jason Baron 
Cc: K.Prasad 
Cc: Peter Zijlstra 
Cc: Srikar Dronamraju 
Cc: Arnaldo Carvalho de Melo 
Cc: systemtap 
Cc: DLE 
LKML-Reference: <20091208220316.10142.39192.stgit@dhcp-100-2-132.bos.redhat.com>
Signed-off-by: Ingo Molnar 
Cc: Steven Rostedt 
Cc: Jim Keniston 
Cc: Ananth N Mavinakayanahalli 
Cc: Christoph Hellwig 
Cc: Frank Ch. Eigler 
Cc: Frederic Weisbecker 
Cc: Jason Baron 
Cc: K.Prasad 
Cc: Peter Zijlstra 
Cc: Srikar Dronamraju 
Cc: Arnaldo Carvalho de Melo

trace_kprobes: Fix a memory leak bug and check kstrdup() return value

2009-12-01T07:19:59+00:00

Fix a memory leak case in create_trace_probe(). When an argument
is too long (> MAX_ARGSTR_LEN), it just jumps to error path. In
that case tp->args[i].name is not released.
This also fixes a bug to check kstrdup()'s return value.

Signed-off-by: Masami Hiramatsu 
Cc: systemtap 
Cc: DLE 
Cc: Steven Rostedt 
Cc: Jim Keniston 
Cc: Ananth N Mavinakayanahalli 
Cc: Christoph Hellwig 
Cc: Frank Ch. Eigler 
Cc: Frederic Weisbecker 
Cc: Jason Baron 
Cc: K.Prasad 
Cc: Peter Zijlstra 
Cc: Srikar Dronamraju 
Cc: Arnaldo Carvalho de Melo 
Cc: Frederic Weisbecker 
LKML-Reference: <20091201001919.10235.56455.stgit@harusame>
Signed-off-by: Ingo Molnar