linux-toradex.git/kernel/trace/trace_ksym.c, branch v2.6.33.5

ksym_tracer: Remove trace_stat

2009-12-30T06:50:50+00:00

trace_stat is problematic. Don't use it, use seqfile instead.

This fixes a race that reading the stat file is not protected by
any lock, which can lead to use after free.

Signed-off-by: Li Zefan 
Cc: Steven Rostedt 
Cc: K.Prasad 
Cc: Frederic Weisbecker 
LKML-Reference: <4B3AF203.40200@cn.fujitsu.com>
Signed-off-by: Ingo Molnar

ksym_tracer: Fix race when incrementing count

2009-12-30T06:50:49+00:00

We are under rcu read section but not holding the write lock, so
count++ is not atomic. Use atomic64_t instead.

Signed-off-by: Li Zefan 
Cc: Steven Rostedt 
Cc: K.Prasad 
Cc: Frederic Weisbecker 
LKML-Reference: <4B3AF1EC.9010608@cn.fujitsu.com>
Signed-off-by: Ingo Molnar

ksym_tracer: Fix to allow writing newline to ksym_trace_filter

2009-12-30T06:50:49+00:00

It used to work, but now doesn't:

 # echo > ksym_filter
 bash: echo: write error: Invalid argument

It's caused by d954fbf0ff6b5fdfb32350e85a2f15d3db976506
("tracing: Fix wrong usage of strstrip in trace_ksyms").

Signed-off-by: Li Zefan 
Cc: Steven Rostedt 
Cc: K.Prasad 
Cc: Frederic Weisbecker 
LKML-Reference: <4B3AF1D7.5040400@cn.fujitsu.com>
Signed-off-by: Ingo Molnar

ksym_tracer: Fix to make the tracer work

2009-12-30T06:50:47+00:00

ksym tracer doesn't work:

 # echo tasklist_lock:rw- > ksym_trace_filter
 -bash: echo: write error: No such device

It's because we pass to perf_event_create_kernel_counter()
a cpu number which is not present.

Signed-off-by: Li Zefan 
Cc: Steven Rostedt 
Cc: K.Prasad 
Cc: Frederic Weisbecker 
LKML-Reference: <4B3AF19E.1010201@cn.fujitsu.com>
Signed-off-by: Ingo Molnar

Merge branch 'linus' into tracing/urgent

2009-12-14T08:16:49+00:00

Conflicts:
	kernel/trace/trace_kprobe.c

Merge reason: resolve the conflict.

Signed-off-by: Ingo Molnar

ksym_tracer: Fix bad cast

2009-12-13T17:46:54+00:00

Fix this warning:

kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_read':
kernel/trace/trace_ksym.c:239: warning: cast to pointer from integer of different size

Signed-off-by: Li Zefan 
Acked-by: Steven Rostedt 
Cc: "K.Prasad" 
LKML-Reference: <4B1DC578.9020909@cn.fujitsu.com>
[remove the strstrip fix as tglx already fixed that]
Signed-off-by: Frederic Weisbecker

tracing: Fix wrong usage of strstrip in trace_ksyms

2009-12-10T23:01:36+00:00

strstrip returns a pointer to the first non space character, but the
code in parse_ksym_trace_str() ignores that.

strstrip is now must_check and therefor we get the correct warning:
kernel/trace/trace_ksym.c:294: warning:
ignoring return value of ‘strstrip’, declared with attribute warn_unused_result

We are really not interested in leading whitespace here.

Fix that and cleanup the dozen kfree() exit pathes.

Signed-off-by: Thomas Gleixner 
Cc: Xiao Guangrong 
Cc: Steven Rostedt

hw-breakpoints: Use overflow handler instead of the event callback

2009-12-06T07:27:18+00:00

struct perf_event::event callback was called when a breakpoint
triggers. But this is a rather opaque callback, pretty
tied-only to the breakpoint API and not really integrated into perf
as it triggers even when we don't overflow.

We prefer to use overflow_handler() as it fits into the perf events
rules, being called only when we overflow.

Reported-by: Peter Zijlstra 
Signed-off-by: Frederic Weisbecker 
Cc: Paul Mackerras 
Cc: Arnaldo Carvalho de Melo 
Cc: "K. Prasad"

hw-breakpoints: Use struct perf_event_attr to define kernel breakpoints

2009-11-27T05:22:59+00:00

Kernel breakpoints are created using functions in which we pass
breakpoint parameters as individual variables: address, length
and type.

Although it fits well for x86, this just does not scale across
architectures that may support this api later as these may have
more or different needs. Pass in a perf_event_attr structure
instead because it is meant to evolve as much as possible into
a generic hardware breakpoint parameter structure.

Reported-by: K.Prasad 
Signed-off-by: Frederic Weisbecker 
LKML-Reference: <1259294154-5197-2-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar

hw-breakpoints: Simplify error handling in breakpoint creation requests

2009-11-26T08:29:21+00:00

This simplifies the error handling when we create a breakpoint.
We don't need to check the NULL return value corner case anymore
since we have improved perf_event_create_kernel_counter() to
always return an error code in the failure case.

Signed-off-by: Frederic Weisbecker 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
Cc: Paul Mackerras 
Cc: Steven Rostedt 
Cc: Prasad 
LKML-Reference: <1259210142-5714-3-git-send-regression-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar