linux-toradex.git/lib/bitmap.c, branch v5.10-rc6

lib: bitmap: delete duplicated words

2020-10-16T18:11:19+00:00

Drop the repeated word "an".

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Link: https://lkml.kernel.org/r/20200823040424.25760-1-rdunlap@infradead.org
Signed-off-by: Linus Torvalds

Merge branch 'master' into for-next

2020-09-01T12:19:48+00:00

Sync with Linus' branch in order to be able to apply fixups
of more recent patches.

lib/bitmap.c: fix bitmap_cut() for partial overlapping case

2020-08-12T17:57:59+00:00

Patch series "lib: Fix bitmap_cut() for overlaps, add test"

This patch (of 2):

Yury Norov reports that bitmap_cut() will not produce the right outcome if
src and dst partially overlap, with src pointing at some location after
dst, because the memmove() affects src before we store the bits that we
need to keep, that is, the bits preceding the cut -- as long as we the
beginning of the cut is not aligned to a long.

Fix this by storing those bits before the memmove().

Note that this is just a theoretical concern so far, as the only user of
this function, pipapo_drop() from the nftables set back-end implemented in
net/netfilter/nft_set_pipapo.c, always supplies entirely overlapping src
and dst.

Fixes: 2092767168f0 ("bitmap: Introduce bitmap_cut(): cut bits and shift remaining")
Reported-by: Yury Norov 
Signed-off-by: Stefano Brivio 
Signed-off-by: Andrew Morton 
Reviewed-by: Andy Shevchenko 
Cc: Rasmus Villemoes 
Cc: Pablo Neira Ayuso 
Link: http://lkml.kernel.org/r/cover.1592155364.git.sbrivio@redhat.com
Link: http://lkml.kernel.org/r/003e38d4428cd6091ef00b5b03354f1bd7d9091e.1592155364.git.sbrivio@redhat.com
Signed-off-by: Linus Torvalds

lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-11T02:14:17+00:00

Commit 2d6261583be0 ("lib: rework bitmap_parse()") does not take into
account order of halfwords on 64-bit big endian architectures.  As
result (at least) Receive Packet Steering, IRQ affinity masks and
runtime kernel test "test_bitmap" get broken on s390.

[andriy.shevchenko@linux.intel.com: convert infinite while loop to a for loop]
  Link: http://lkml.kernel.org/r/20200609140535.87160-1-andriy.shevchenko@linux.intel.com

Fixes: 2d6261583be0 ("lib: rework bitmap_parse()")
Signed-off-by: Alexander Gordeev 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Andrew Morton 
Reviewed-by: Andy Shevchenko 
Cc: Yury Norov 
Cc: Amritha Nambiar 
Cc: Arnaldo Carvalho de Melo 
Cc: Chris Wilson 
Cc: Kees Cook 
Cc: Matthew Wilcox 
Cc: Miklos Szeredi 
Cc: Rasmus Villemoes 
Cc: Steffen Klassert 
Cc: "Tobin C . Harding" 
Cc: Vineet Gupta 
Cc: Will Deacon 
Cc: Willem de Bruijn 
Cc: 
Link: http://lkml.kernel.org/r/1591634471-17647-1-git-send-email-agordeev@linux.ibm.com
Signed-off-by: Linus Torvalds

lib/bitmap.c: fix spello

2020-05-18T10:37:51+00:00

Fix typo/spello for whitespaces.

Signed-off-by: Randy Dunlap 
Signed-off-by: Jiri Kosina

lib: bitmap.c: get rid of some doc warnings

2020-04-20T21:45:41+00:00

There are two ascii art drawings there. Use a block markup tag there
in order to get rid of those warnings:

	./lib/bitmap.c:189: WARNING: Unexpected indentation.
	./lib/bitmap.c:190: WARNING: Block quote ends without a blank line; unexpected unindent.
	./lib/bitmap.c:190: WARNING: Unexpected indentation.
	./lib/bitmap.c:191: WARNING: Line block ends without a blank line.

It should be noticed that there's actually a syntax violation
right now, as something like:

	/**
	 ...
	 @src:

will be handled as a definition for @src parameter, and not as
part of a diagram. So, we need to add something before it, in
order for this to be processed the way it should.

Signed-off-by: Mauro Carvalho Chehab 
Link: https://lore.kernel.org/r/1e2568fdfa838c1a0d8cc2a1d70dd4b6de99bfb1.1586881715.git.mchehab+huawei@kernel.org
Signed-off-by: Jonathan Corbet

lib: rework bitmap_parse()

2020-02-04T03:05:26+00:00

bitmap_parse() is ineffective and full of opaque variables and opencoded
parts.  It leads to hard understanding and usage of it.  This rework
includes:

- remove bitmap_shift_left() call from the cycle.  Now it makes the
  complexity of the algorithm as O(nbits^2).  In the suggested approach
  the input string is parsed in reverse direction, so no shifts needed;

- relax requirement on a single comma and no white spaces between
  chunks.  It is considered useful in scripting, and it aligns with
  bitmap_parselist();

- split bitmap_parse() to small readable helpers;

- make an explicit calculation of the end of input line at the
  beginning, so users of the bitmap_parse() won't bother doing this.

Link: http://lkml.kernel.org/r/20200102043031.30357-6-yury.norov@gmail.com
Signed-off-by: Yury Norov 
Cc: Amritha Nambiar 
Cc: Andy Shevchenko 
Cc: Arnaldo Carvalho de Melo 
Cc: Chris Wilson 
Cc: Kees Cook 
Cc: Matthew Wilcox 
Cc: Miklos Szeredi 
Cc: Rasmus Villemoes 
Cc: Steffen Klassert 
Cc: "Tobin C . Harding" 
Cc: Vineet Gupta 
Cc: Will Deacon 
Cc: Willem de Bruijn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib: make bitmap_parse_user a wrapper on bitmap_parse

2020-02-04T03:05:26+00:00

Currently we parse user data byte after byte which leads to
overcomplicating of parsing algorithm.  There are no performance critical
users of bitmap_parse_user(), and so we can duplicate user data to kernel
buffer and simply call bitmap_parselist().  This rework lets us unify and
simplify bitmap_parse() and bitmap_parse_user(), which is done in the
following patch.

Link: http://lkml.kernel.org/r/20200102043031.30357-5-yury.norov@gmail.com
Signed-off-by: Yury Norov 
Reviewed-by: Andy Shevchenko 
Cc: Amritha Nambiar 
Cc: Arnaldo Carvalho de Melo 
Cc: Chris Wilson 
Cc: Kees Cook 
Cc: Matthew Wilcox 
Cc: Miklos Szeredi 
Cc: Rasmus Villemoes 
Cc: Steffen Klassert 
Cc: "Tobin C . Harding" 
Cc: Vineet Gupta 
Cc: Will Deacon 
Cc: Willem de Bruijn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

bitmap: Introduce bitmap_cut(): cut bits and shift remaining

2020-01-27T07:54:30+00:00

The new bitmap function bitmap_cut() copies bits from source to
destination by removing the region specified by parameters first
and cut, and remapping the bits above the cut region by right
shifting them.

Signed-off-by: Stefano Brivio 
Signed-off-by: Pablo Neira Ayuso

lib/bitmap: introduce bitmap_replace() helper

2019-12-05T03:44:14+00:00

In some drivers we want to have a single operation over bitmap which is
an equivalent to:

	*dst = (*old & ~(*mask)) | (*new & *mask)

Introduce bitmap_replace() helper for this.

Link: http://lkml.kernel.org/r/20191022172922.61232-8-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Rasmus Villemoes 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds