linux-toradex.git/lib/checksum.c, branch v3.10.78

lib/checksum.c: fix build for generic csum_tcpudp_nofold

2015-02-11T06:48:17+00:00

commit 9ce357795ef208faa0d59894d9d119a7434e37f3 upstream.

Fixed commit added from64to32 under _#ifndef do_csum_ but used it
under _#ifndef csum_tcpudp_nofold_, breaking some builds (Fengguang's
robot reported TILEGX's). Move from64to32 under the latter.

Fixes: 150ae0e94634 ("lib/checksum.c: fix carry in csum_tcpudp_nofold")
Reported-by: kbuild test robot 
Signed-off-by: Karl Beldan 
Cc: Eric Dumazet 
Cc: David S. Miller 
Signed-off-by: David S. Miller 
Cc: Guenter Roeck 
Signed-off-by: Greg Kroah-Hartman

lib/checksum.c: fix carry in csum_tcpudp_nofold

2015-02-11T06:48:16+00:00

commit 150ae0e94634714b23919f0c333fee28a5b199d5 upstream.

The carry from the 64->32bits folding was dropped, e.g with:
saddr=0xFFFFFFFF daddr=0xFF0000FF len=0xFFFF proto=0 sum=1,
csum_tcpudp_nofold returned 0 instead of 1.

Signed-off-by: Karl Beldan 
Cc: Al Viro 
Cc: Eric Dumazet 
Cc: Arnd Bergmann 
Cc: Mike Frysinger 
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

asm-generic headers: Allow yet more arch overrides in checksum.h

2013-02-11T14:30:33+00:00

arches can have more efficient implementation of these routines

Acked-by: Arnd Bergmann 
Signed-off-by: Vineet Gupta

lib: reduce the use of module.h wherever possible

2012-03-07T20:04:04+00:00

For files only using THIS_MODULE and/or EXPORT_SYMBOL, map
them onto including export.h -- or if the file isn't even
using those, then just delete the include.  Fix up any implicit
include dependencies that were being masked by module.h along
the way.

Signed-off-by: Paul Gortmaker

lib/checksum.c: optimize do_csum a bit

2011-07-07T11:52:24+00:00

Reduce the number of variables modified by the loop in do_csum() by 1,
which seems like a good idea.  On Nios II (a RISC CPU with 3-operand
instruction set) it reduces the loop from 7 to 6 instructions, including
the conditional branch.

Signed-off-by: Ian Abbott 
Signed-off-by: David S. Miller

lib/checksum: fix one more thinko

2009-11-03T15:06:53+00:00

When do_csum gets unaligned data, we really need to treat
the first byte as an even byte, not an odd byte, because
we swap the two halves later.

Found by Mike's checksum-selftest module.

Reported-by: Mike Frysinger 
Signed-off-by: Arnd Bergmann

lib/checksum.c: make do_csum optional

2009-11-03T15:06:52+00:00

Mike Frysinger suggested that do_csum should be optional
so that an architecture can use the generic checksum code
but still provide an optimized fast-path for the most
critical function.

This can mean an implementation using inline assembly,
or in case of Alpha one using 64-bit arithmetic in C.

Cc: Mike Frysinger 
Signed-off-by: Arnd Bergmann

lib/checksum.c: use 32-bit arithmetic consistently

2009-11-03T15:06:52+00:00

The use of 'unsigned long' variables in the 32-bit part of do_csum()
is confusing at best, and potentially broken for long input on 64-bit
machines.

This changes the code to use 'unsigned int' instead, which makes
the code behave in the same (correct) way on both 32 and 64 bit
machines.

Reported-by: Linus Torvalds 
Signed-off-by: Arnd Bergmann

lib/checksum.c: fix endianess bug

2009-06-19T12:58:13+00:00

The new generic checksum code has a small dependency on endianess and
worked only on big-endian systems. I could not find a nice efficient
way to express this, so I added an #ifdef. Using
'result += le16_to_cpu(*buff);' would have worked as well, but
would be slightly less efficient on big-endian systems and IMHO
would not be clearer.

Also fix a bug that prevents this from working on 64-bit machines.
If you have a 64-bit CPU and want to use the generic checksum
code, you should probably do some more optimizations anyway, but
at least the code should not break.

Reported-by: Mike Frysinger 
Signed-off-by: Arnd Bergmann

add generic lib/checksum.c

2009-06-11T19:02:51+00:00

Add a generic (unoptimized) implementation of checksum.c in pure C
for use by all architectures that cannot be bother with implementing
their own version.

Based on microblaze code by Michal Simek 

Cc: Michal Simek 
Signed-off-by: Remis Lima Baima 
Signed-off-by: Arnd Bergmann