linux-toradex.git/lib/iommu-common.c, branch v4.3.3

lib/iommu-common.c: do not try to deref a null iommu->lazy_flush() pointer when n < pool->hint

2015-09-22T22:09:53+00:00

The check for invoking iommu->lazy_flush() from iommu_tbl_range_alloc()
has to be refactored so that we only call ->lazy_flush() if it is
non-null.

I had a sparc kernel that was crashing when I was trying to process some
very large perf.data files- the crash happens when the scsi driver calls
into dma_4v_map_sg and thus the iommu_tbl_range_alloc().

Signed-off-by: Sowmini Varadhan 
Cc: Benjamin Herrenschmidt 
Cc: Guenter Roeck 
Cc: David S. Miller 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/iommu-common.c: do not use 0xffffffffffffffffl for computing align_mask

2015-08-07T01:39:41+00:00

Using a 64 bit constant generates "warning: integer constant is too
large for 'long' type" on 32 bit platforms.  Instead use ~0ul and
BITS_PER_LONG.

Detected by Andrew Morton on ARMD.

Signed-off-by: Sowmini Varadhan 
Cc: Benjamin Herrenschmidt 
Cc: David S. Miller 
Cc: Guenter Roeck 
Cc: Rasmus Villemoes 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

iommu-common: rename iommu_pool_hash to iommu_hash_common

2015-04-20T18:09:55+00:00

When CONFIG_DEBUG_FORCE_WEAK_PER_CPU is set, the DEFINE_PER_CPU_SECTION
macro will define an extern __pcpu_unique_##name variable that could
conflict with the same definition in powerpc at this time. Avoid that
conflict by renaming iommu_pool_hash in iommu-common.c

Thanks to Guenter Roeck for catching this, and helping to test the fix.

Signed-off-by: Sowmini Varadhan 
Tested-by: Guenter Roeck 
Reviewed-by: Guenter Roeck 
Signed-off-by: David S. Miller

iommu-common: fix x86_64 compiler warnings

2015-04-20T18:09:55+00:00

Declare iommu_large_alloc as static. Remove extern definition  for
iommu_tbl_pool_init().

Signed-off-by: Sowmini Varadhan 
Tested-by: Guenter Roeck 
Reviewed-by: Guenter Roeck 
Signed-off-by: David S. Miller

iommu-common: Fix PARISC compile-time warnings

2015-04-18T19:34:50+00:00

Fixes warnings due to
- no DMA_ERROR_CODE on PARISC,
- sizeof (unsigned long) == 4 bytes on PARISC.

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

Break up monolithic iommu table/lock into finer graularity pools and lock

2015-04-18T19:32:59+00:00

Investigation of multithreaded iperf experiments on an ethernet
interface show the iommu->lock as the hottest lock identified by
lockstat, with something of the order of  21M contentions out of
27M acquisitions, and an average wait time of 26 us for the lock.
This is not efficient. A more scalable design is to follow the ppc
model, where the iommu_map_table has multiple pools, each stretching
over a segment of the map, and with a separate lock for each pool.
This model allows for better parallelization of the iommu map search.

This patch adds the iommu range alloc/free function infrastructure.

Signed-off-by: Sowmini Varadhan 
Acked-by: Benjamin Herrenschmidt 
Signed-off-by: David S. Miller

sparc: Revert generic IOMMU allocator.

2015-04-18T19:31:25+00:00

I applied the wrong version of this patch series, V4 instead
of V10, due to a patchwork bundling snafu.

Signed-off-by: David S. Miller

iommu-common: Fix PARISC compile-time warnings

2015-04-17T19:24:36+00:00

Fixes warnings due to
- no DMA_ERROR_CODE on PARISC,
- sizeof (unsigned long) == 4 bytes on PARISC.

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller

sparc: Break up monolithic iommu table/lock into finer graularity pools and lock

2015-04-16T19:44:55+00:00

Investigation of multithreaded iperf experiments on an ethernet
interface show the iommu->lock as the hottest lock identified by
lockstat, with something of the order of  21M contentions out of
27M acquisitions, and an average wait time of 26 us for the lock.
This is not efficient. A more scalable design is to follow the ppc
model, where the iommu_table has multiple pools, each stretching
over a segment of the map, and with a separate lock for each pool.
This model allows for better parallelization of the iommu map search.

This patch adds the iommu range alloc/free function infrastructure.

Signed-off-by: Sowmini Varadhan 
Signed-off-by: David S. Miller