linux-toradex.git/lib/kobject.c, branch v2.6.34.15

Driver core: Constify struct sysfs_ops in struct kobj_type

2010-03-08T01:04:49+00:00

Constify struct sysfs_ops.

This is part of the ops structure constification
effort started by Arjan van de Ven et al.

Benefits of this constification:

 * prevents modification of data that is shared
   (referenced) by many other structure instances
   at runtime

 * detects/prevents accidental (but not intentional)
   modification attempts on archs that enforce
   read-only kernel data at runtime

 * potentially better optimized code as the compiler
   can assume that the const data cannot be changed

 * the compiler/linker move const data into .rodata
   and therefore exclude them from false sharing

Signed-off-by: Emese Revfy 
Acked-by: David Teigland 
Acked-by: Matt Domsch 
Acked-by: Maciej Sosnowski 
Acked-by: Hans J. Koch 
Acked-by: Pekka Enberg 
Acked-by: Jens Axboe 
Acked-by: Stephen Hemminger 
Signed-off-by: Greg Kroah-Hartman

kobject: Constify struct kset_uevent_ops

2010-03-08T01:04:49+00:00

Constify struct kset_uevent_ops.

This is part of the ops structure constification
effort started by Arjan van de Ven et al.

Benefits of this constification:

 * prevents modification of data that is shared
   (referenced) by many other structure instances
   at runtime

 * detects/prevents accidental (but not intentional)
   modification attempts on archs that enforce
   read-only kernel data at runtime

 * potentially better optimized code as the compiler
   can assume that the const data cannot be changed

 * the compiler/linker move const data into .rodata
   and therefore exclude them from false sharing

Signed-off-by: Emese Revfy 
Signed-off-by: Greg Kroah-Hartman

kobject: make kset_create check kobject_set_name return value

2009-06-16T04:30:24+00:00

kset_create should check the kobject_set_name return value.

Add the return value checking code.

Signed-off-by: Dave Young 
Signed-off-by: Greg Kroah-Hartman

driver: dont update dev_name via device_add path

2009-04-20T15:12:58+00:00

notice one system /proc/iomem some entries missed the name for pci_devices

it turns that dev->dev.kobj name is changed after device_add.

for pci code: via acpi_pci_root_driver.ops.add (aka acpi_pci_root_add)
==> pci_acpi_scan_root is used to scan pci bus/device, and at the same
time we read the resource for pci_dev in the pci_read_bases, we have
res->name = pci_name(pci_dev); pci_name is calling dev_name.

later via acpi_pci_root_driver.ops.start (aka acpi_pci_root_start) ==>
pci_bus_add_device to add all pci_dev in kobj tree.  pci_bus_add_device
will call device_add.

actually in device_add

        /* first, register with generic layer. */
        error = kobject_add(&dev->kobj, dev->kobj.parent, "%s", dev_name(dev));
        if (error)
                goto Error;

will get one new name for that kobj, old name is freed.

[Impact: fix corrupted names in /proc/iomem ]

Signed-off-by: Yinghai Lu 
Signed-off-by: Linus Torvalds

driver core: get rid of struct device's bus_id string array

2009-03-24T23:38:23+00:00

Now that all users of bus_id is gone, we can remove it from struct
device.

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

kobject: Cleanup kobject_rename and !CONFIG_SYSFS

2008-10-16T16:24:52+00:00

It finally dawned on me what the clean fix to sysfs_rename_dir
calling kobject_set_name is.  Move the work into kobject_rename
where it belongs.  The callers serialize us anyway so this is
safe.

Signed-off-by: Eric W. Biederman 
Acked-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

kobject: Fix kobject_rename and !CONFIG_SYSFS

2008-10-16T16:24:52+00:00

When looking at kobject_rename I found two bugs with
that exist when sysfs support is disabled in the kernel.

kobject_rename does not change the name on the kobject when
sysfs support is not compiled in.

kobject_rename without locking attempts to check the
validity of a rename operation, which the kobject layer
simply does not have the infrastructure to do.

This patch documents the previously unstated requirement of
kobject_rename that is the responsibility of the caller to
provide mutual exclusion and to be certain that the new_name
for the kobject is valid.

This patch modifies sysfs_rename_dir in !CONFIG_SYSFS case
to call kobject_set_name to actually change the kobject_name.

This patch removes the bogus and misleading check in kobject_rename
that attempts to see if a rename is valid.  The check is bogus
because we do not have the proper locking.  The check is misleading
because it looks like we can and do perform checking at the kobject
level that we don't.

Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

kobject: Replace ALL occurrences of '/' with '!' instead of only the first one.

2008-08-21T17:15:34+00:00

A recent patch from Kay Sievers 
replaced the first occurrence of '/' with '!' as needed for block devices.

Now do some cheap defensive coding and replace all of them to avoid future
issues in this area.

Signed-off-by: Ingo Oeser 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Example use of WARN()

2008-07-25T17:53:29+00:00

Now that WARN() exists, we can fold some of the printk's into it.

Signed-off-by: Arjan van de Ven 
Cc: Greg KH 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

kobject: replace '/' with '!' in name

2008-07-22T04:54:40+00:00

Some (block) devices have a '/' in the name, and need special
handling. Let's have that rule to the core, so we can remove it
from the block class.

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman