linux-toradex.git/lib/test_bitmap.c, branch v5.6-rc6

lib: new testcases for bitmap_parse{_user}

2020-02-04T03:05:27+00:00

New version of bitmap_parse() is unified with bitmap_parse_list(),
and therefore:

- weakens rules on whitespaces and commas between hex chunks;

- in addition to

- allows passing UINT_MAX or any other big number as the length of input
  string instead of actual string length.

The patch covers the cases.

Link: http://lkml.kernel.org/r/20200102043031.30357-7-yury.norov@gmail.com
Signed-off-by: Yury Norov 
Reviewed-by: Andy Shevchenko 
Cc: Amritha Nambiar 
Cc: Arnaldo Carvalho de Melo 
Cc: Chris Wilson 
Cc: Kees Cook 
Cc: Matthew Wilcox 
Cc: Miklos Szeredi 
Cc: Rasmus Villemoes 
Cc: Steffen Klassert 
Cc: "Tobin C . Harding" 
Cc: Vineet Gupta 
Cc: Will Deacon 
Cc: Willem de Bruijn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib: add test for bitmap_parse()

2020-02-04T03:05:26+00:00

The test is derived from bitmap_parselist() NO_LEN is reserved for use in
following patches.

[yury.norov@gmail.com: fix rebase issue]
  Link: http://lkml.kernel.org/r/20200102182659.6685-1-yury.norov@gmail.com
[andriy.shevchenko@linux.intel.com: fix address space when test user buffer]
  Link: http://lkml.kernel.org/r/20200109103601.45929-2-andriy.shevchenko@linux.intel.com
Link: http://lkml.kernel.org/r/20200102043031.30357-4-yury.norov@gmail.com
Signed-off-by: Yury Norov 
Signed-off-by: Andy Shevchenko 
Reviewed-by: Andy Shevchenko 
Cc: Amritha Nambiar 
Cc: Arnaldo Carvalho de Melo 
Cc: Chris Wilson 
Cc: Kees Cook 
Cc: Matthew Wilcox 
Cc: Miklos Szeredi 
Cc: Rasmus Villemoes 
Cc: Steffen Klassert 
Cc: "Tobin C . Harding" 
Cc: Vineet Gupta 
Cc: Will Deacon 
Cc: Willem de Bruijn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: correct test data offsets for 32-bit

2020-01-31T18:30:36+00:00

On 32-bit platform the size of long is only 32 bits which makes wrong
offset in the array of 64 bit size.

Calculate offset based on BITS_PER_LONG.

Link: http://lkml.kernel.org/r/20200109103601.45929-1-andriy.shevchenko@linux.intel.com
Fixes: 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper")
Signed-off-by: Andy Shevchenko 
Reported-by: Guenter Roeck 
Cc: Rasmus Villemoes 
Cc: Yury Norov 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/bitmap: introduce bitmap_replace() helper

2019-12-05T03:44:14+00:00

In some drivers we want to have a single operation over bitmap which is
an equivalent to:

	*dst = (*old & ~(*mask)) | (*new & *mask)

Introduce bitmap_replace() helper for this.

Link: http://lkml.kernel.org/r/20191022172922.61232-8-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Rasmus Villemoes 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: fix comment about this file

2019-12-05T03:44:14+00:00

This test case file is about bitmap API, and not printf() facility.

Link: http://lkml.kernel.org/r/20191022172922.61232-7-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Rasmus Villemoes 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: move exp1 and exp2 upper for others to use

2019-12-05T03:44:14+00:00

Some test cases may re-use predefined exp1 and exp2 bitmaps.  Move them
upper in the file.

Link: http://lkml.kernel.org/r/20191022172922.61232-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Rasmus Villemoes 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: rename exp to exp1 to avoid ambiguous name

2019-12-05T03:44:14+00:00

One function is using exp as local variable.  Avoid ambiguous naming by
rename global one to exp1.

Link: http://lkml.kernel.org/r/20191022172922.61232-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Rasmus Villemoes 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: name EXP_BYTES properly

2019-12-05T03:44:14+00:00

EXP_BYTES has been wrongly named.  It's a size of the exp array in bits.

While here, go ahead and rename to EXP1_IN_BITS to avoid double renaming
when exp will be renamed to exp1 in the next patch

Link: http://lkml.kernel.org/r/20191022172922.61232-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Rasmus Villemoes 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: undefine macros after use

2019-12-05T03:44:14+00:00

There is no need to keep step and ptest macros defined in entire file.

Link: http://lkml.kernel.org/r/20191022172922.61232-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Geert Uytterhoeven 
Cc: Marek Vasut 
Cc: Rasmus Villemoes 
Cc: Thomas Petazzoni 
Cc: William Breathitt Gray 
Cc: Yury Norov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

lib/test_bitmap: force argument of bitmap_parselist_user() to proper address space

2019-12-05T03:44:14+00:00

Patch series "gpio: pca953x: Convert to bitmap (extended) API", v2.

While converting gpio-pca953x driver to bitmap API, I noticed that we
have no function to replace bits.

So, that's how patch 7 appears.

First 6 patches are preparatory of the test suite (including some
warning fixes, etc).

Patches 8-9 are preparatory for the GPIO driver to be easier converted
to bitmap API, conversion to which happens in patch 10.

Patch 11 contains simple indentation fixes.

This patch (of 11):

Sparse complains:

  lib/test_bitmap.c:345:58: warning: incorrect type in argument 1 (different address spaces)
  lib/test_bitmap.c:345:58:    expected char const [noderef]  *ubuf
  lib/test_bitmap.c:345:58:    got char const *const in

Force argument of bitmap_parselist_user() to proper address space.

Link: http://lkml.kernel.org/r/20191022172922.61232-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko 
Acked-by: Linus Walleij 
Cc: Bartosz Golaszewski 
Cc: Rasmus Villemoes 
Cc: Yury Norov 
Cc: William Breathitt Gray 
Cc: Geert Uytterhoeven 
Cc: Thomas Petazzoni 
Cc: Marek Vasut 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds