linux-toradex.git/mm/memory_hotplug.c, branch v3.0.16

mm, hotplug: protect zonelist building with zonelists_mutex

2011-06-23T04:06:48+00:00

Commit 959ecc48fc75 ("mm/memory_hotplug.c: fix building of node hotplug
zonelist") does not protect the build_all_zonelists() call with
zonelists_mutex as needed.  This can lead to races in constructing
zonelist ordering if a concurrent build is underway.  Protecting this
with lock_memory_hotplug() is insufficient since zonelists can be
rebuild though sysfs as well.

Signed-off-by: David Rientjes 
Reviewed-by: KOSAKI Motohiro 
Signed-off-by: Linus Torvalds

mm, hotplug: fix error handling in mem_online_node()

2011-06-23T04:06:47+00:00

The error handling in mem_online_node() is incorrect: hotadd_new_pgdat()
returns NULL if the new pgdat could not have been allocated and a pointer
to it otherwise.

mem_online_node() should fail if hotadd_new_pgdat() fails, not the
inverse.  This fixes an issue when memoryless nodes are not onlined and
their sysfs interface is not registered when their first cpu is brought
up.

The bug was introduced by commit cf23422b9d76 ("cpu/mem hotplug: enable
CPUs online before local memory online") iow v2.6.35.

Signed-off-by: David Rientjes 
Reviewed-by: KOSAKI Motohiro 
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds

mm/memory_hotplug.c: fix building of node hotplug zonelist

2011-06-16T03:04:01+00:00

During memory hotplug we refresh zonelists when we online a page in a new
zone.  It means that the node's zonelist is not initialized until pages
are onlined.  So for example, "nid" passed by MEM_GOING_ONLINE notifier
will point to NODE_DATA(nid) which has no zone fallback list.  Moreover,
if we hot-add cpu-only nodes, alloc_pages() will do no fallback.

This patch makes a zonelist when a new pgdata is available.

Note: in production, at fujitsu, memory should be onlined before cpu
      and our server didn't have any memory-less nodes and had no problems.

      But recent changes in MEM_GOING_ONLINE+page_cgroup
      will access not initialized zonelist of node.
      Anyway, there are memory-less node and we need some care.

Signed-off-by: KAMEZAWA Hiroyuki 
Cc: Mel Gorman 
Cc: Dave Hansen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm: remove dependency on CONFIG_FLATMEM from online_page()

2011-05-25T15:39:28+00:00

online_pages() is only compiled for CONFIG_MEMORY_HOTPLUG_SPARSE, so there
is no need to support CONFIG_FLATMEM code within it.

This patch removes code that is never used.

Signed-off-by: Daniel Kiper 
Acked-by: Dave Hansen 
Acked-by: David Rientjes 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mem-hotplug: call isolate_lru_page with elevated refcount

2011-05-25T15:39:22+00:00

isolate_lru_page() must be called only with stable reference to page.  So,
let's grab normal page reference.

Signed-off-by: Konstantin Khlebnikov 
Cc: Andi Kleen 
Cc: KAMEZAWA Hiroyuki 
Cc: KOSAKI Motohiro 
Cc: Mel Gorman 
Cc: Lee Schermerhorn 
Cc: Rik van Riel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm, mem-hotplug: recalculate lowmem_reserve when memory hotplug occurs

2011-05-25T15:39:09+00:00

Currently, memory hotplug calls setup_per_zone_wmarks() and
calculate_zone_inactive_ratio(), but doesn't call
setup_per_zone_lowmem_reserve().

It means the number of reserved pages aren't updated even if memory hot
plug occur.  This patch fixes it.

Signed-off-by: KOSAKI Motohiro 
Reviewed-by: KAMEZAWA Hiroyuki 
Acked-by: Mel Gorman 
Reviewed-by: Minchan Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm, mem-hotplug: fix section mismatch. setup_per_zone_inactive_ratio() should be __meminit.

2011-05-25T15:39:08+00:00

Commit bce7394a3e ("page-allocator: reset wmark_min and inactive ratio of
zone when hotplug happens") introduced invalid section references.  Now,
setup_per_zone_inactive_ratio() is marked __init and then it can't be
referenced from memory hotplug code.

This patch marks it as __meminit and also marks caller as __ref.

Signed-off-by: KOSAKI Motohiro 
Reviewed-by: Minchan Kim 
Cc: Yasunori Goto 
Cc: Rik van Riel 
Cc: Johannes Weiner 
Reviewed-by: KAMEZAWA Hiroyuki 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mm: optimize pfn calculation in online_page()

2011-04-14T23:06:54+00:00

If CONFIG_FLATMEM is enabled pfn is calculated in online_page() more than
once.  It is possible to optimize that and use value established at
beginning of that function.

Signed-off-by: Daniel Kiper 
Acked-by: Dave Hansen 
Cc: KAMEZAWA Hiroyuki 
Cc: Wu Fengguang 
Cc: Mel Gorman 
Cc: Christoph Lameter 
Acked-by: David Rientjes 
Reviewed-by: Jesper Juhl 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

Merge branch 'slub/hotplug' into slab/urgent

2011-01-15T11:28:17+00:00