linux-toradex.git/net/9p/trans_fd.c, branch v3.2.20

net/9p: enable 9p to work in non-default network namespace

2011-05-25T13:46:39+00:00

Teach 9p filesystem to work in container with non-default network namespace.
(Note: I also patched the unix domain socket code but don't have a test case
for that.  It's the same fix, I just don't have a server for it...)

To test, run diod server (http://code.google.com/p/diod):
  diod -n -f -L stderr -l 172.23.255.1:9999 -c /dev/null -e /root
and then mount like so:
  mount -t 9p -o port=9999,aname=/root,version=9p2000.L 172.23.255.1 /mnt

A container test environment is described at http://landley.net/lxc

Signed-off-by: Rob Landley 
Signed-off-by: Eric Van Hensbergen

9p: Kill set but not used variable 'ret' in parse_opts()

2011-05-19T21:38:57+00:00

Signed-off-by: David S. Miller

net/9p: Convert the in the 9p rpc call path to GFP_NOFS

2011-03-22T20:43:35+00:00

Without this we can cause reclaim allocation in writepage.

[ 3433.448430] =================================
[ 3433.449117] [ INFO: inconsistent lock state ]
[ 3433.449117] 2.6.38-rc5+ #84
[ 3433.449117] ---------------------------------
[ 3433.449117] inconsistent {RECLAIM_FS-ON-W} -> {IN-RECLAIM_FS-R} usage.
[ 3433.449117] kswapd0/505 [HC0[0]:SC0[0]:HE1:SE1] takes:
[ 3433.449117]  (iprune_sem){+++++-}, at: [] shrink_icache_memory+0x45/0x2b1
[ 3433.449117] {RECLAIM_FS-ON-W} state was registered at:
[ 3433.449117]   [] mark_held_locks+0x52/0x70
[ 3433.449117]   [] lockdep_trace_alloc+0x85/0x9f
[ 3433.449117]   [] slab_pre_alloc_hook+0x18/0x3c
[ 3433.449117]   [] kmem_cache_alloc+0x23/0xa2
[ 3433.449117]   [] idr_pre_get+0x2d/0x6f
[ 3433.449117]   [] p9_idpool_get+0x30/0xae
[ 3433.449117]   [] p9_client_rpc+0xd7/0x9b0
[ 3433.449117]   [] p9_client_clunk+0x88/0xdb
[ 3433.449117]   [] v9fs_evict_inode+0x3c/0x48
[ 3433.449117]   [] evict+0x1f/0x87
[ 3433.449117]   [] dispose_list+0x47/0xe3
[ 3433.449117]   [] evict_inodes+0x138/0x14f
[ 3433.449117]   [] generic_shutdown_super+0x57/0xe8
[ 3433.449117]   [] kill_anon_super+0x11/0x50
[ 3433.449117]   [] v9fs_kill_super+0x49/0xab
[ 3433.449117]   [] deactivate_locked_super+0x21/0x46
[ 3433.449117]   [] deactivate_super+0x40/0x44
[ 3433.449117]   [] mntput_no_expire+0x100/0x109
[ 3433.449117]   [] sys_umount+0x2f1/0x31c
[ 3433.449117]   [] system_call_fastpath+0x16/0x1b
[ 3433.449117] irq event stamp: 192941
[ 3433.449117] hardirqs last  enabled at (192941): [] _raw_spin_unlock_irq+0x2b/0x30
[ 3433.449117] hardirqs last disabled at (192940): [] shrink_inactive_list+0x290/0x2f5
[ 3433.449117] softirqs last  enabled at (188470): [] __do_softirq+0x133/0x152
[ 3433.449117] softirqs last disabled at (188455): [] call_softirq+0x1c/0x28
[ 3433.449117]
[ 3433.449117] other info that might help us debug this:
[ 3433.449117] 1 lock held by kswapd0/505:
[ 3433.449117]  #0:  (shrinker_rwsem){++++..}, at: [] shrink_slab+0x38/0x15f
[ 3433.449117]
[ 3433.449117] stack backtrace:
[ 3433.449117] Pid: 505, comm: kswapd0 Not tainted 2.6.38-rc5+ #84
[ 3433.449117] Call Trace:
[ 3433.449117]  [] ? valid_state+0x17e/0x191
[ 3433.449117]  [] ? save_stack_trace+0x28/0x45
[ 3433.449117]  [] ? check_usage_forwards+0x0/0x87
[ 3433.449117]  [] ? mark_lock+0x113/0x22c
[ 3433.449117]  [] ? __lock_acquire+0x37a/0xcf7
[ 3433.449117]  [] ? mark_lock+0x2d/0x22c
[ 3433.449117]  [] ? __lock_acquire+0x392/0xcf7
[ 3433.449117]  [] ? determine_dirtyable_memory+0x15/0x28
[ 3433.449117]  [] ? lock_acquire+0x57/0x6d
[ 3433.449117]  [] ? shrink_icache_memory+0x45/0x2b1
[ 3433.449117]  [] ? down_read+0x47/0x5c
[ 3433.449117]  [] ? shrink_icache_memory+0x45/0x2b1
[ 3433.449117]  [] ? shrink_icache_memory+0x45/0x2b1
[ 3433.449117]  [] ? shrink_slab+0xdb/0x15f
[ 3433.449117]  [] ? kswapd+0x574/0x96a
[ 3433.449117]  [] ? kswapd+0x0/0x96a
[ 3433.449117]  [] ? kthread+0x7d/0x85
[ 3433.449117]  [] ? kernel_thread_helper+0x4/0x10
[ 3433.449117]  [] ? restore_args+0x0/0x30
[ 3433.449117]  [] ? kthread+0x0/0x85
[ 3433.449117]  [] ? kernel_thread_helper+0x0/0x10

Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: Venkateswararao Jujjuri 
Signed-off-by: Eric Van Hensbergen

net/9p: replace p9_poll_task with a work

2011-02-01T10:42:43+00:00

Now that cmwq can handle high concurrency, it's more efficient to use
work than a dedicated kthread.  Convert p9_poll_proc() to a work
function for p9_poll_work and make p9_pollwake() schedule it on each
poll event.  The work is sync flushed on module exit.

Signed-off-by: Tejun Heo 
Cc: Eric Van Hensbergen 
Cc: Ron Minnich 
Cc: Latchesar Ionkov 
Cc: v9fs-developer@lists.sourceforge.net

net/9p: use system_wq instead of p9_mux_wq

2011-02-01T10:42:43+00:00

With cmwq, there's no reason to use a dedicated workqueue in trans_fd.
Drop p9_mux_wq and use system_wq instead.  The used work items are
already sync canceled in p9_conn_destroy() and doesn't require further
synchronization.

Signed-off-by: Tejun Heo 
Cc: Eric Van Hensbergen 
Cc: Ron Minnich 
Cc: Latchesar Ionkov 
Cc: v9fs-developer@lists.sourceforge.net

net/9p/trans_fd.c: Fix unsigned return type

2010-09-07T01:48:42+00:00

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// 

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

9p: strlen() doesn't count the terminator

2010-08-02T15:37:17+00:00

This is an off by one bug because strlen() doesn't count the NULL
terminator.  We strcpy() addr into a fixed length array of size
UNIX_PATH_MAX later on.

The addr variable is the name of the device being mounted.

Signed-off-by: Dan Carpenter 
Signed-off-by: Eric Van Hensbergen

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30T13:02:32+00:00

percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files.  percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.

percpu.h -> slab.h dependency is about to be removed.  Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability.  As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.

  http://userweb.kernel.org/~tj/misc/slabh-sweep.py

The script does the followings.

* Scan files for gfp and slab usages and update includes such that
  only the necessary includes are there.  ie. if only gfp is used,
  gfp.h, if slab is used, slab.h.

* When the script inserts a new include, it looks at the include
  blocks and try to put the new include such that its order conforms
  to its surrounding.  It's put in the include block which contains
  core kernel includes, in the same order that the rest are ordered -
  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
  doesn't seem to be any matching order.

* If the script can't find a place to put a new include (mostly
  because the file doesn't have fitting include block), it prints out
  an error message indicating which .h file needs to be added to the
  file.

The conversion was done in the following steps.

1. The initial automatic conversion of all .c files updated slightly
   over 4000 files, deleting around 700 includes and adding ~480 gfp.h
   and ~3000 slab.h inclusions.  The script emitted errors for ~400
   files.

2. Each error was manually checked.  Some didn't need the inclusion,
   some needed manual addition while adding it to implementation .h or
   embedding .c file was more appropriate for others.  This step added
   inclusions to around 150 files.

3. The script was run again and the output was compared to the edits
   from #2 to make sure no file was left behind.

4. Several build tests were done and a couple of problems were fixed.
   e.g. lib/decompress_*.c used malloc/free() wrappers around slab
   APIs requiring slab.h to be added manually.

5. The script was run on all .h files but without automatically
   editing them as sprinkling gfp.h and slab.h inclusions around .h
   files could easily lead to inclusion dependency hell.  Most gfp.h
   inclusion directives were ignored as stuff from gfp.h was usually
   wildly available and often used in preprocessor macros.  Each
   slab.h inclusion directive was examined and added manually as
   necessary.

6. percpu.h was updated not to include slab.h.

7. Build test were done on the following configurations and failures
   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
   distributed build env didn't work with gcov compiles) and a few
   more options had to be turned off depending on archs to make things
   build (like ipr on powerpc/64 which failed due to missing writeq).

   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
   * powerpc and powerpc64 SMP allmodconfig
   * sparc and sparc64 SMP allmodconfig
   * ia64 SMP allmodconfig
   * s390 SMP allmodconfig
   * alpha SMP allmodconfig
   * um on x86_64 SMP allmodconfig

8. percpu.h modifications were reverted so that it could be applied as
   a separate patch and serve as bisection point.

Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.

Signed-off-by: Tejun Heo 
Guess-its-ok-by: Christoph Lameter 
Cc: Ingo Molnar 
Cc: Lee Schermerhorn

9p: fix option parsing

2010-02-08T22:23:23+00:00

Options pointer is being moved before calling kfree() which seems
to cause problems.  This uses a separate pointer to track and free
original allocation.

Signed-off-by: Venkateswararao Jujjuri 
Signed-off-by: Eric Van Hensbergen w

9p connect fixes

2009-12-16T17:16:41+00:00

* if we fail in p9_conn_create(), we shouldn't leak references to struct file.
  Logics in ->close() doesn't help - ->trans is already gone by the time it's
  called.
* sock_create_kern() can fail.
* use of sock_map_fd() is all fscked up; I'd fixed most of that, but the
  rest will have to wait for a bit more work in net/socket.c (we still are
  violating the basic rule of working with descriptor table: "once the reference
  is installed there, don't rely on finding it there again").

Signed-off-by: Al Viro