linux-toradex.git/net/9p/trans_rdma.c, branch v3.13.4

net: trans_rdma: remove unused function

2013-07-24T22:46:27+00:00

This patch gets rid of the following warning:

net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function]
 static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)

The rdma_cancelled function is not called anywhere in the kernel

Signed-off-by: Andi Shyti 
Signed-off-by: David S. Miller

9P: Add cancelled() to the transport functions.

2013-07-08T03:18:18+00:00

RDMA needs to post a buffer for each incoming reply.
Hence it needs to keep count of these and needs to be
aware of whether a flushed request has received a reply
or not.

This patch adds the cancelled() callback to the transport modules.
It is called when RFLUSH has been received and that the corresponding
request will never receive a reply.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: count posted buffers without a pending request

2013-07-08T03:04:36+00:00

In rdma_request():

If an error occurs between posting the recv and the send,
there will be a reply context posted without a pending
request.
Since there is no way to "un-post" it, we remember it and
skip post_recv() for the next request.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: Improve error handling in rdma_request

2013-07-08T03:02:29+00:00

Most importantly:
- do not free the recv context (rpl_context) after a successful post_recv()
- but do free the send context (c) after a failed send.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: Do not free req->rc in error handling in rdma_request()

2013-07-08T03:02:29+00:00

rdma_request() should never be in charge of freeing rc.

When an error occurs:
* Either the rc buffer has been recv_post()'ed.
  then kfree()'ing it certainly is a bad idea.
* Or is has not, and in that case req->rc still points to it,
  hence it needs not be freed.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: Use a semaphore to protect the RQ

2013-07-08T03:02:29+00:00

The current code keeps track of the number of buffers posted in the RQ,
and will prevent it from overflowing. But it does so by simply dropping
post requests (And leaking memory in the process).
When this happens there will actually be too few buffers posted, and
soon the 9P server will complain about 'RNR retry counter exceeded'
errors.

Instead, use a semaphore, and block until the RQ is ready for another
buffer to be posted.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: Protect against duplicate replies

2013-07-08T03:02:28+00:00

A well-behaved server would not send twice the reply to a request.
But if it ever happens...
This additional check prevents the kernel from leaking memory
and possibly more nasty consequences in that unlikely event.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: increase P9_RDMA_MAXSIZE to 1MB

2013-07-08T03:02:28+00:00

The current value is too low to get good performance.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9P/RDMA: rdma_request() needs not allocate req->rc

2013-07-08T03:02:27+00:00

p9_tag_alloc() takes care of that.

Signed-off-by: Simon Derr 
Signed-off-by: Eric Van Hensbergen

9p: Reduce object size with CONFIG_NET_9P_DEBUG

2012-01-05T16:51:44+00:00

Reduce object size by deduplicating formats.

Use vsprintf extension %pV.
Rename P9_DPRINTK uses to p9_debug, align arguments.
Add function for _p9_debug and macro to add __func__.
Add missing "\n"s to p9_debug uses.
Remove embedded function names as p9_debug adds it.
Remove P9_EPRINTK macro and convert use to pr_.
Add and use pr_fmt and pr_.

$ size fs/9p/built-in.o*
   text	   data	    bss	    dec	    hex	filename
  62133	    984	  16000	  79117	  1350d	fs/9p/built-in.o.new
  67342	    984	  16928	  85254	  14d06	fs/9p/built-in.o.old
$ size net/9p/built-in.o*
   text	   data	    bss	    dec	    hex	filename
  88792	   4148	  22024	 114964	  1c114	net/9p/built-in.o.new
  94072	   4148	  23232	 121452	  1da6c	net/9p/built-in.o.old

Signed-off-by: Joe Perches 
Signed-off-by: Eric Van Hensbergen