linux-toradex.git/net/batman-adv/network-coding.h, branch v5.3.2

batman-adv: no need to check return value of debugfs_create functions

2019-06-27T17:25:04+00:00

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Because we don't care if debugfs works or not, this trickles back a bit
so we can clean things up by making some functions return void instead
of an error value that is never going to fail.

Cc: Marek Lindner 
Cc: Simon Wunderlich 
Cc: Antonio Quartulli 
Cc: "David S. Miller" 
Cc: b.a.t.m.a.n@lists.open-mesh.org
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
[sven@narfation.org: drop unused variables]
Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: Use includes instead of fwdecls

2019-05-25T10:59:53+00:00

While it can be slightly beneficial for the build performance to use
forward declarations instead of includes, the handling of them together
with changes in the included headers makes it unnecessary complicated and
fragile. Just replace them with actual includes since some parts (hwmon,
..) of the kernel even request avoidance of forward declarations and net/
is mostly not using them in *.c file.

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: Drop license boilerplate

2019-03-25T08:31:35+00:00

All files got a SPDX-License-Identifier with commit 7db7d9f369a4
("batman-adv: Add SPDX license identifier above copyright header"). All the
required information about the license conditions can be found in
LICENSES/.

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: Update copyright years for 2019

2019-01-04T10:04:24+00:00

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: Update copyright years for 2018

2018-02-26T16:57:39+00:00

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: Add SPDX license identifier above copyright header

2017-12-15T16:22:45+00:00

The "Linux kernel licensing rules" require that each file has a SPDX
license identifier as first line (and sometimes as second line).

The FSFE REUSE practices [1] would also require the same tags but have no
restrictions on the placement in the source file. Using the "Linux kernel
licensing rules" is therefore also fulfilling the FSFE REUSE practices
requirements at the same time.

[1] https://reuse.software/practices/

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

batman-adv: update copyright years for 2017

2017-01-26T07:34:19+00:00

Signed-off-by: Sven Eckelmann 
Signed-off-by: Simon Wunderlich

2016-02-02T04:55:10+00:00

Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner 
Signed-off-by: Antonio Quartulli

batman-adv: Remove batadv_ types forward declarations

2015-08-24T22:12:20+00:00

main.h is included in every file and is the only way to access types.h.
This makes forward declarations for all types defined in types.h
unnecessary.

Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner 
Signed-off-by: Antonio Quartulli

batman-adv: Add required includes to all files

2015-06-07T15:07:19+00:00

The header files could not be build indepdent from each other. This is
happened because headers didn't include the files for things they've used.
This was problematic because the success of a build depended on the
knowledge about the right order of local includes.

Also source files were not including everything they've used explicitly.
Instead they required that transitive includes are always stable. This is
problematic because some transitive includes are not obvious, depend on
config settings and may not be stable in the future.

The order for include blocks are:

 * primary headers (main.h and the *.h file of a *.c file)
 * global linux headers
 * required local headers
 * extra forward declarations for pointers in function/struct declarations

The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h.
This header file is shared with userspace applications like batctl and must
therefore build together with userspace applications. The header
linux/bitops.h is not part of the uapi headers and linux/if_ether.h
conflicts with the musl implementation of netinet/if_ether.h. The
maintainers rejected the use of __KERNEL__ preprocessor checks and thus
these two headers are only in main.h. All files using packet.h first have
to include main.h to work correctly.

Reported-by: Markus Pargmann 
Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner