linux-toradex.git/net/batman-adv/sysfs.c, branch v4.5

batman-adv: only call post function if something changed

2016-01-09T12:56:00+00:00

Currently, the post function is also called on errors or if there were
no changes, which is redundant for the functions currently using these
facilities.

Signed-off-by: Simon Wunderlich 
Signed-off-by: Marek Lindner 
Signed-off-by: Antonio Quartulli

batman-adv: purge bridge loop avoidance when its disabled

2016-01-09T12:56:00+00:00

When bridge loop avoidance is disabled through sysfs, the internal
datastructures are not disabled, but only BLA operations are disabled.
To be sure that they are removed, purge the data immediately. That is
especially useful if a firmwares network state is changed, and the BLA
wait periods should restart on the new network.

Signed-off-by: Simon Wunderlich 
Signed-off-by: Marek Lindner 
Signed-off-by: Antonio Quartulli

batman-adv: Replace C99 int types with kernel type

2015-08-24T22:12:17+00:00

(s|u)(8|16|32|64) are the preferred types in the kernel. The use of the
standard C99 types u?int(8|16|32|64)_t are objected by some people and even
checkpatch now warns about using them.

Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner 
Signed-off-by: Antonio Quartulli

batman-adv: Add required includes to all files

2015-06-07T15:07:19+00:00

The header files could not be build indepdent from each other. This is
happened because headers didn't include the files for things they've used.
This was problematic because the success of a build depended on the
knowledge about the right order of local includes.

Also source files were not including everything they've used explicitly.
Instead they required that transitive includes are always stable. This is
problematic because some transitive includes are not obvious, depend on
config settings and may not be stable in the future.

The order for include blocks are:

 * primary headers (main.h and the *.h file of a *.c file)
 * global linux headers
 * required local headers
 * extra forward declarations for pointers in function/struct declarations

The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h.
This header file is shared with userspace applications like batctl and must
therefore build together with userspace applications. The header
linux/bitops.h is not part of the uapi headers and linux/if_ether.h
conflicts with the musl implementation of netinet/if_ether.h. The
maintainers rejected the use of __KERNEL__ preprocessor checks and thus
these two headers are only in main.h. All files using packet.h first have
to include main.h to work correctly.

Reported-by: Markus Pargmann 
Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner

batman-adv: split name from variable for uint mesh attributes

2015-06-07T15:07:18+00:00

Some mesh attributes are behind substructs in the
batadv_priv object and for this reason the name cannot be
used anymore to refer to them.

This patch allows to specify the variable name where the
attribute is stored inside batadv_priv instead of using the
name

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner

batman-adv: update copyright years for 2015

2015-05-29T08:13:35+00:00

Signed-off-by: Sven Eckelmann 
Signed-off-by: Marek Lindner

batman-adv: checkpatch - Please don't use multiple blank lines

2015-01-07T16:21:56+00:00

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner

batman-adv: Use kasprintf

2014-07-08T00:00:31+00:00

kasprintf combines kmalloc and sprintf, and takes care of the size
calculation itself.

The semantic patch that makes this change is as follows:

// 
@@
expression a,flag;
expression list args;
statement S;
@@

  a =
-  \(kmalloc\|kzalloc\)(...,flag)
+  kasprintf(flag,args)
  <... when != a
  if (a == NULL || ...) S
  ...>
- sprintf(a,args);
// 

Signed-off-by: Himangi Saraogi 
Acked-by: Julia Lawall 
Signed-off-by: David S. Miller

batman-adv: remove semi-colon after macro definition

2014-05-18T13:04:00+00:00

Reported by checkpatch with the following warning:
"WARNING: macros should not use a trailing semicolon"

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner

batman-adv: add blank line between declarations and the rest of the code

2014-05-18T13:03:52+00:00

Reported by checkpatch with the following message:
"WARNING: Missing a blank line after declarations"

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner