linux-toradex.git/net/batman-adv/vis.c, branch v3.3.8

batman-adv: create a common substructure for tt_global/local_entry

2011-11-20T12:08:35+00:00

Several functions in the translation table management code assume that the
tt_global_entry and tt_local_entry structures have the same initial fields such
as 'addr' and 'hash_entry'. To improve the code readability and to avoid
mistakes in later changes, a common substructure that substitute the shared
fields has been introduced (struct tt_common_entry).

Thanks to this modification, it has also been possible to slightly reduce the
code length by merging some functions like compare_ltt/gtt() and
tt_local/global_hash_find()

Signed-off-by: Antonio Quartulli 
Signed-off-by: Sven Eckelmann

batman-adv: fixed hash functions type to uint32_t instead of int

2011-11-20T12:08:33+00:00

There are two reasons for this fix:
- the result of choose_orig() and vis_choose() is an index and therefore it can't
  be negative. Hence it is correct to make the return type unsigned too.

- sizeof(int) may not be the same on ALL the architectures. Since we plan to use
  choose_orig() as DHT hash function, we need to guarantee that, given the same
  argument, the result is the same. Then it is correct to explicitly express
  the size of the return type (and the second argument). Since the expected
  length is currently 4, uint32_t is the most convenient choice.

Signed-off-by: Antonio Quartulli 
Signed-off-by: Sven Eckelmann

batman-adv: Remove unnecessary OOM logging messages

2011-09-08T15:52:30+00:00

Removing unnecessary messages saves code and text.

Site specific OOM messages are duplications of a generic MM
out of memory message and aren't really useful, so just
delete them.

Signed-off-by: Joe Perches 
Signed-off-by: Marek Lindner

batman-adv: correct several typ0s in the comments

2011-08-22T13:16:19+00:00

Several typos have been corrected and some sentences have been rephrased

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner

batman-adv: hash_add() has to discriminate on the return value

2011-08-22T13:16:19+00:00

hash_add() returns 0 on success while returns -1 either on error and on
entry already present. The caller could use such information to select
its behaviour. For this reason it is useful that hash_add() returns -1
in case on error and returns 1 in case of entry already present.

Signed-off-by: Antonio Quartulli 
Signed-off-by: Marek Lindner

batman-adv: protect the local and the global trans-tables with rcu

2011-06-20T09:37:30+00:00

The local and the global translation-tables are now lock free and rcu
protected.

Signed-off-by: Antonio Quartulli 
Acked-by: Simon Wunderlich 
Signed-off-by: Sven Eckelmann

batman-adv: move smallest_signed_int(), seq_before() and seq_after() into main.h

2011-05-30T05:39:35+00:00

smallest_signed_int(), seq_before() and seq_after() are very useful
functions that help to handle comparisons between sequence numbers.
However they were only defined in vis.c. With this patch every
batman-adv function will be able to use them.

Signed-off-by: Antonio Quartulli 
Signed-off-by: Sven Eckelmann

batman-adv: Calculate sizeof using variable insead of types

2011-05-30T05:39:33+00:00

Documentation/CodingStyle recommends to use the form

	p = kmalloc(sizeof(*p), ...);

to calculate the size of a struct and not the version where the struct
name is spelled out to prevent bugs when the type of p changes. This
also seems appropriate for manipulation of buffers when they are
directly associated with p.

Signed-off-by: Sven Eckelmann

batman-adv: Remove casts from type x to type x

2011-05-30T05:39:33+00:00

Casting from pointer like 'struct orig_node*' to 'struct orig_node *'
doesn't provide any additional functionality and can be savely removed.

Signed-off-by: Sven Eckelmann

batman-adv: Add const type qualifier for pointers

2011-05-30T05:39:31+00:00

batman-adv uses pointers which are marked as const and should not
violate that type qualifier by passing it to functions which force a
cast to the non-const version.

Signed-off-by: Sven Eckelmann