linux-toradex.git/net/bluetooth/hci_request.c, branch v4.10

Bluetooth: Fix append max 11 bytes of name to scan rsp data

2016-10-19T16:42:37+00:00

Append maximum of 10 + 1 bytes of name to scan response data.
Complete name is appended only if exists and is <= 10 characters.
Else append short name if exists or shorten complete name if not.
This makes sure name is consistent across multiple advertising
instances.

Signed-off-by: Michał Narajowski 
Signed-off-by: Marcel Holtmann

Bluetooth: Refactor append name and appearance

2016-10-06T09:52:29+00:00

Use eir_append_data to remove code duplication.

Signed-off-by: Michał Narajowski 
Signed-off-by: Marcel Holtmann

Bluetooth: Add appearance to default scan rsp data

2016-10-06T09:52:29+00:00

Add appearance value to beginning of scan rsp data for
default advertising instance if the value is not 0.

Signed-off-by: Michał Narajowski 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix local name in scan rsp

2016-10-06T09:52:29+00:00

Use complete name if it fits. If not and there is short name
check if it fits. If not then use shortened name as prefix
of complete name.

Signed-off-by: Michał Narajowski 
Signed-off-by: Marcel Holtmann

Bluetooth: Add support for appearance in scan rsp

2016-09-19T18:19:34+00:00

This patch enables prepending appearance value to scan response data.
It also adds support for setting appearance value through mgmt command.
If currently advertised instance has apperance flag set it is expired
immediately.

Signed-off-by: Michał Narajowski 
Signed-off-by: Szymon Janc 
Signed-off-by: Marcel Holtmann

Bluetooth: Add support for local name in scan rsp

2016-09-19T18:19:34+00:00

This patch enables appending local name to scan response data. If
currently advertised instance has name flag set it is expired
immediately.

Signed-off-by: Michał Narajowski 
Signed-off-by: Szymon Janc 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix reason code used for rejecting SCO connections

2016-09-19T18:19:34+00:00

A comment in the code states that SCO connection should be rejected
with the proper error value between 0xd-0xf. The code uses
HCI_ERROR_REMOTE_LOW_RESOURCES which is 0x14.

This led to following error:
< HCI Command: Reject Synchronous Co.. (0x01|0x002a) plen 7
        Address: 34:51:C9:EF:02:CA (Apple, Inc.)
        Reason: Remote Device Terminated due to Low Resources (0x14)
> HCI Event: Command Status (0x0f) plen 4
      Reject Synchronous Connection Request (0x01|0x002a) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Instead make use of HCI_ERROR_REJ_LIMITED_RESOURCES which is 0xd.

Signed-off-by: Frédéric Dalleau 
Signed-off-by: Marcel Holtmann

Bluetooth: mgmt: Fix sending redundant event for Advertising Instance

2016-09-19T18:19:34+00:00

When an Advertising Instance is removed, the Advertising Removed event
shouldn't be sent to the same socket that issued the Remove
Advertising command (it gets a command complete event instead). The
mgmt_advertising_removed() function already has a parameter for
skipping a specific socket, but there was no code to propagate the
right value to this parameter. This patch fixes the issue by making
sure the intermediate hci_req_clear_adv_instance() function gets the
socket pointer.

Signed-off-by: Johan Hedberg 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix memory leak at end of hci requests

2016-08-24T14:49:29+00:00

In hci_req_sync_complete the event skb is referenced in hdev->req_skb.
It is used (via hci_req_run_skb) from either __hci_cmd_sync_ev which will
pass the skb to the caller, or __hci_req_sync which leaks.

unreferenced object 0xffff880005339a00 (size 256):
  comm "kworker/u3:1", pid 1011, jiffies 4294671976 (age 107.389s)
  backtrace:
    [] kmemleak_alloc+0x49/0xa0
    [] kmem_cache_alloc+0x128/0x180
    [] skb_clone+0x4f/0xa0
    [] hci_event_packet+0xc1/0x3290
    [] hci_rx_work+0x18b/0x360
    [] process_one_work+0x14a/0x440
    [] worker_thread+0x43/0x4d0
    [] kthread+0xc4/0xe0
    [] ret_from_fork+0x1f/0x40
    [] 0xffffffffffffffff

Signed-off-by: Frédéric Dalleau 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix setting NO_BREDR advertising flag

2016-04-08T16:50:40+00:00

If we're dealing with a single-mode controller or BR/EDR is disable
for a dual-mode one, the NO_BREDR flag needs to be unconditionally
present in the advertising data. This patch moves it out from behind
an extra condition to be always set in the create_instance_adv_data()
function if BR/EDR is disabled.

Signed-off-by: Johan Hedberg 
Signed-off-by: Marcel Holtmann