linux-toradex.git/net/bluetooth/hidp, branch v3.4.34

Bluetooth: Fix incorrect strncpy() in hidp_setup_hid()

2013-02-04T00:24:41+00:00

commit 0a9ab9bdb3e891762553f667066190c1d22ad62b upstream.

The length parameter should be sizeof(req->name) - 1 because there is no
guarantee that string provided by userspace will contain the trailing
'\0'.

Can be easily reproduced by manually setting req->name to 128 non-zero
bytes prior to ioctl(HIDPCONNADD) and checking the device name setup on
input subsystem:

$ cat /sys/devices/pnp0/00\:04/tty/ttyS0/hci0/hci0\:1/input8/name
AAAAAA[...]AAAAAAAAf0:af:f0:af:f0:af

("f0:af:f0:af:f0:af" is the device bluetooth address, taken from "phys"
field in struct hid_device due to overflow.)

Signed-off-by: Anderson Lizardo 
Acked-by: Marcel Holtmann 
Signed-off-by: Gustavo Padovan 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: Use kernel int types instead of ones from stdint.h

2012-02-27T10:34:39+00:00

u8/__u8/u32/etc should be used in the kernel instead of stdint.h types.

Signed-off-by: Johan Hedberg 
Acked-by: Marcel Holtmann

Bluetooth: Always compile SCO and L2CAP in Bluetooth Core

2011-12-21T04:21:08+00:00

The handling of SCO audio links and the L2CAP protocol are essential to
any system with Bluetooth thus are always compiled in from now on.

Signed-off-by: Ulisses Furquim 
Acked-by: Marcel Holtmann 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Replace spin_lock by mutex in hci_dev

2011-12-18T19:07:54+00:00

Now we run everything in HCI in process context, so it's a better idea use
mutex instead spin_lock. The macro remains hci_dev_lock() (and I got rid
of hci_dev_lock_bh()), of course.

Acked-by: Marcel Holtmann 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Fix hidp_get_connection()

2011-11-07T19:24:55+00:00

This functions needs crtl_sock and intr_sock to be set first.

Signed-off-by: Gustavo F. Padovan

Bluetooth: hidp: Fix module reference cleanup

2011-11-07T19:24:54+00:00

Calling module_put(THIS_MODULE) is *never* safe when we cannot go sure that we
own at least two references. This is because the call may unload our module
before it returns and then the "return" will jump into invalid memory.

Gladly, module.h provides a wrapper for kthread-users: module_put_and_exit().
This puts our module and then exits the kthread without returning to the module.

This patch fixes the hidp kthread to use this wrapper instead of manually
freeing its own reference. See nfsd or lockd for other kthreads using this.

Calling __module_get() inside the kthread is safe as the hidp module will always
wait until the kthread sets "waiting_for_startup" to 0.

Signed-off-by: David Herrmann 
Signed-off-by: Gustavo F. Padovan

Bluetooth: replace list_for_each with list_for_each_entry whenever possible

2011-11-07T19:24:46+00:00

When all items in the list have the same type there is no much of a point
to use list_for_each except if you want to use the list pointer itself.

Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Rename hidp_find_connection()

2011-10-07T04:44:00+00:00

hidp_get_connection() makes more sense because we hold a reference to the
connection inside this function.

Signed-off-by: Gustavo F. Padovan

Bluetooth: Delay session allocation in hidp

2011-10-07T04:43:17+00:00

It gets allocated only when it is really needed.

Signed-off-by: Gustavo F. Padovan

Bluetooth: hidp: safely acquire hci connection

2011-10-07T04:43:10+00:00

Claim device lock to safely enumerate hci connection list and bump
hci connection proxy device ref count simultaneously.

This patch incorporates David Herrmann's fix to prevent adding an
HID device when the hci connection no longer exists.

Signed-off-by: David Herrmann 
Signed-off-by: Peter Hurley 
Signed-off-by: Gustavo F. Padovan