linux-toradex.git/net/bluetooth/sco.c, branch v3.0.29

Bluetooth: fix shutdown on SCO sockets

2011-06-10T18:04:40+00:00

shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.

Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Gustavo F. Padovan

Revert "Bluetooth: fix shutdown on SCO sockets"

2011-05-12T01:58:16+00:00

This reverts commit f21ca5fff6e548833fa5ee8867239a8378623150.

Quoth Gustavo F. Padovan:
  "Commit f21ca5fff6e548833fa5ee8867239a8378623150 can cause a NULL
   dereference if we call shutdown in a bluetooth SCO socket and doesn't
   wait the shutdown completion to call close().  Please revert it.  I
   may have a fix for it soon, but we don't have time anymore, so revert
   is the way to go.  ;)"

Requested-by: Gustavo F. Padovan 
Signed-off-by: Linus Torvalds

Bluetooth: fix shutdown on SCO sockets

2011-04-18T23:11:46+00:00

shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.

Signed-off-by: Luiz Augusto von Dentz 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Use ERR_PTR as return error from hci_connect

2011-02-27T20:11:29+00:00

Use ERR_PTR mechanism to return error from hci_connect.

Signed-off-by: Ville Tervo 
Signed-off-by: Anderson Briglia 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Merge L2CAP and SCO modules into bluetooth.ko

2011-02-14T20:27:36+00:00

Actually doesn't make sense have these modules built separately.
The L2CAP layer is needed by almost all Bluetooth protocols and profiles.
There isn't any real use case without having L2CAP loaded.
SCO is only essential for Audio transfers, but it is so small that we can
have it loaded always in bluetooth.ko without problems.
If you really doesn't want it you can disable SCO in the kernel config.

Signed-off-by: Gustavo F. Padovan

Bluetooth: sco: fix information leak to userspace

2011-02-14T14:51:40+00:00

struct sco_conninfo has one padding byte in the end.  Local variable
cinfo of type sco_conninfo is copied to userspace with this uninizialized
one byte, leading to old stack contents leak.

Signed-off-by: Vasiliy Kulikov 
Signed-off-by: Gustavo F. Padovan

Bluetooth: clean up sco code

2010-12-01T23:04:43+00:00

Do not use assignments in IF condition, remove extra spaces

Signed-off-by: Andrei Emeltchenko 
Signed-off-by: Gustavo F. Padovan

Bluetooth: Fix not returning proper error in SCO

2010-11-22T20:23:18+00:00

Return 0 in that situation could lead to errors in the caller.

Signed-off-by: Gustavo F. Padovan

net: Remove unnecessary returns from void function()s

2010-05-18T06:23:14+00:00

This patch removes from net/ (but not any netfilter files)
all the unnecessary return; statements that precede the
last closing brace of void functions.

It does not remove the returns that are immediately
preceded by a label as gcc doesn't like that.

Done via:
$ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
  xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

Bluetooth: Trivial clean ups to SCO

2010-05-10T07:28:45+00:00

Remove extra braces and labels, break over column 80 lines, etc

Signed-off-by: Gustavo F. Padovan 
Signed-off-by: Marcel Holtmann