linux-toradex.git/net/bluetooth, branch v2.6.23.17

[BLUETOOTH]: Fix non-COMPAT build of hci_sock.c

2007-09-12T12:10:58+00:00

Signed-off-by: David S. Miller

[Bluetooth] Fix parameter list for event filter command

2007-09-09T06:39:49+00:00

On device initialization the event filters are cleared. In case of
clearing the filters the extra condition type shall be omitted.

Signed-off-by: Marcel Holtmann

[Bluetooth] Update security filter for Bluetooth 2.1

2007-09-09T06:39:43+00:00

This patch updates the HCI security filter with support for the
Bluetooth 2.1 commands and events.

Signed-off-by: Marcel Holtmann

[Bluetooth] Add compat handling for timestamp structure

2007-09-09T06:39:34+00:00

The timestamp structure needs special handling in case of compat
programs. Use the same wrapping method the network core uses.

Signed-off-by: Marcel Holtmann

[BLUETOOTH] l2cap: don't mangle cmd.len

2007-07-31T09:28:09+00:00

Since nobody uses it after we convert it to host-endian,
no need to do that at all.  At that point l2cap is endian-clean.

Signed-off-by: Al Viro 
Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[BLUETOOTH]: pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-31T09:28:08+00:00

Signed-off-by: Al Viro 
Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[BLUETOOTH] l2cap: endianness annotations

2007-07-31T09:28:07+00:00

no code changes, just documenting existing types

Signed-off-by: Al Viro 
Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[BLUETOOTH]: Fix endianness bug in l2cap_sock_listen()

2007-07-31T09:28:06+00:00

We loop through psm values, calling __l2cap_get_sock_by_addr(psm, ...)
until we get NULL; then we set ->psm of our socket to htobs(psm).
IOW, we find unused psm value and put it into our socket.  So far, so
good, but...  __l2cap_get_sock_by_addr() compares its argument with
->psm of sockets.  IOW, the entire thing works correctly only on
little-endian.  On big-endian we'll get "no socket with such psm"
on the first iteration, since we won't find a socket with ->psm == 0x1001.
We will happily conclude that 0x1001 is unused and slap htobs(0x1001)
(i.e. 0x110) into ->psm of our socket.  Of course, the next time around
the same thing will repeat and we'll just get a fsckload of sockets
with the same ->psm assigned.

Fix: pass htobs(psm) to __l2cap_get_sock_by_addr() there.  All other
callers are already passing little-endian values and all places that
store something in ->psm are storing little-endian.

Signed-off-by: Al Viro 
Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[IRDA]: Fix rfcomm use-after-free

2007-07-31T09:28:05+00:00

Adrian Bunk wrote:
> Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following
> use-after-free in net/bluetooth/rfcomm/tty.c:
>
> <--  snip  -->
>
> ...
> static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
> {
> ...
>         if (IS_ERR(dev->tty_dev)) {
>                 list_del(&dev->list);
>                 kfree(dev);
>                 return PTR_ERR(dev->tty_dev);
>         }
> ...
>
> <--  snip  -->
>
> Spotted by the Coverity checker.

really good catch. I fully overlooked that one. The attached patch
should fix it.

Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[NET] BLUETOOTH: Fix whitespace errors.

2007-07-19T01:43:16+00:00

Signed-off-by: YOSHIFUJI Hideaki