linux-toradex.git/net/bluetooth, branch v2.6.32.8

Bluetooth: Fix regression with L2CAP configuration in Basic Mode

2009-11-16T00:31:41+00:00

Basic Mode is the default mode of operation of a L2CAP entity. In
this case the RFC (Retransmission and Flow Control) configuration
option should not be used at all.

Normally remote L2CAP implementation should just ignore this option,
but it can cause various side effects with other Bluetooth stacks
that are not capable of handling unknown options.

Signed-off-by: Gustavo F. Padovan 
Signed-off-by: Marcel Holtmann

Bluetooth: Select Basic Mode as default for SOCK_SEQPACKET

2009-11-16T00:31:16+00:00

The default mode for SOCK_SEQPACKET is Basic Mode. So when no
mode has been specified, Basic Mode shall be used.

This is important for current application to keep working as
expected and not cause a regression.

Signed-off-by: Gustavo F. Padovan 
Signed-off-by: Marcel Holtmann

Bluetooth: Set general bonding security for ACL by default

2009-11-16T00:30:28+00:00

This patch fixes double pairing issues with Secure Simple
Paring support. It was observed that when pairing with SSP
enabled, that the confirmation will be asked twice.

http://www.spinics.net/lists/linux-bluetooth/msg02473.html

This also causes bug when initiating SSP connection from
Windows Vista.

The reason is because bluetoothd does not store link keys
since HCIGETAUTHINFO returns 0. Setting default to general
bonding fixes these issues.

Signed-off-by: Andrei Emeltchenko 
Signed-off-by: Marcel Holtmann

bluetooth: static lock key fix

2009-10-20T02:36:49+00:00

When shutdown ppp connection, lockdep waring about non-static key
will happen, it is caused by the lock is not initialized properly
at that time.

Fix with tuning the lock/skb_queue_head init order

[   94.339261] INFO: trying to register non-static key.
[   94.342509] the code is fine but needs lockdep annotation.
[   94.342509] turning off the locking correctness validator.
[   94.342509] Pid: 0, comm: swapper Not tainted 2.6.31-mm1 #2
[   94.342509] Call Trace:
[   94.342509]  [] register_lock_class+0x58/0x241
[   94.342509]  [] ? __lock_acquire+0xb57/0xb73
[   94.342509]  [] __lock_acquire+0xac/0xb73
[   94.342509]  [] ? lock_release_non_nested+0x17b/0x1de
[   94.342509]  [] lock_acquire+0x67/0x84
[   94.342509]  [] ? skb_dequeue+0x15/0x41
[   94.342509]  [] _spin_lock_irqsave+0x2f/0x3f
[   94.342509]  [] ? skb_dequeue+0x15/0x41
[   94.342509]  [] skb_dequeue+0x15/0x41
[   94.342509]  [] ? _read_unlock+0x1d/0x20
[   94.342509]  [] skb_queue_purge+0x14/0x1b
[   94.342509]  [] l2cap_recv_frame+0xea1/0x115a [l2cap]
[   94.342509]  [] ? __lock_acquire+0xb57/0xb73
[   94.342509]  [] ? mark_lock+0x1e/0x1c7
[   94.342509]  [] ? hci_rx_task+0xd2/0x1bc [bluetooth]
[   94.342509]  [] l2cap_recv_acldata+0xb1/0x1c6 [l2cap]
[   94.342509]  [] hci_rx_task+0x106/0x1bc [bluetooth]
[   94.342509]  [] ? l2cap_recv_acldata+0x0/0x1c6 [l2cap]
[   94.342509]  [] tasklet_action+0x69/0xc1
[   94.342509]  [] __do_softirq+0x94/0x11e
[   94.342509]  [] do_softirq+0x36/0x5a
[   94.342509]  [] irq_exit+0x35/0x68
[   94.342509]  [] do_IRQ+0x72/0x89
[   94.342509]  [] common_interrupt+0x2e/0x34
[   94.342509]  [] ? pm_qos_add_requirement+0x63/0x9d
[   94.342509]  [] ? acpi_idle_enter_bm+0x209/0x238
[   94.342509]  [] cpuidle_idle_call+0x5c/0x94
[   94.342509]  [] cpu_idle+0x4e/0x6f
[   94.342509]  [] rest_init+0x53/0x55
[   94.342509]  [] start_kernel+0x2f0/0x2f5
[   94.342509]  [] i386_start_kernel+0x91/0x96

Reported-by: Oliver Hartkopp 
Signed-off-by: Dave Young 
Tested-by: Oliver Hartkopp 
Signed-off-by: David S. Miller

bluetooth: scheduling while atomic bug fix

2009-10-20T02:36:45+00:00

Due to driver core changes dev_set_drvdata will call kzalloc which should be
in might_sleep context, but hci_conn_add will be called in atomic context

Like dev_set_name move dev_set_drvdata to work queue function.

oops as following:

Oct  2 17:41:59 darkstar kernel: [  438.001341] BUG: sleeping function called from invalid context at mm/slqb.c:1546
Oct  2 17:41:59 darkstar kernel: [  438.001345] in_atomic(): 1, irqs_disabled(): 0, pid: 2133, name: sdptool
Oct  2 17:41:59 darkstar kernel: [  438.001348] 2 locks held by sdptool/2133:
Oct  2 17:41:59 darkstar kernel: [  438.001350]  #0:  (sk_lock-AF_BLUETOOTH-BTPROTO_L2CAP){+.+.+.}, at: [] lock_sock+0xa/0xc [l2cap]
Oct  2 17:41:59 darkstar kernel: [  438.001360]  #1:  (&hdev->lock){+.-.+.}, at: [] l2cap_sock_connect+0x103/0x26b [l2cap]
Oct  2 17:41:59 darkstar kernel: [  438.001371] Pid: 2133, comm: sdptool Not tainted 2.6.31-mm1 #2
Oct  2 17:41:59 darkstar kernel: [  438.001373] Call Trace:
Oct  2 17:41:59 darkstar kernel: [  438.001381]  [] __might_sleep+0xde/0xe5
Oct  2 17:41:59 darkstar kernel: [  438.001386]  [] __kmalloc+0x4a/0x15a
Oct  2 17:41:59 darkstar kernel: [  438.001392]  [] ? kzalloc+0xb/0xd
Oct  2 17:41:59 darkstar kernel: [  438.001396]  [] kzalloc+0xb/0xd
Oct  2 17:41:59 darkstar kernel: [  438.001400]  [] device_private_init+0x15/0x3d
Oct  2 17:41:59 darkstar kernel: [  438.001405]  [] dev_set_drvdata+0x18/0x26
Oct  2 17:41:59 darkstar kernel: [  438.001414]  [] hci_conn_init_sysfs+0x40/0xd9 [bluetooth]
Oct  2 17:41:59 darkstar kernel: [  438.001422]  [] ? hci_conn_add+0x128/0x186 [bluetooth]
Oct  2 17:41:59 darkstar kernel: [  438.001429]  [] hci_conn_add+0x177/0x186 [bluetooth]
Oct  2 17:41:59 darkstar kernel: [  438.001437]  [] hci_connect+0x3c/0xfb [bluetooth]
Oct  2 17:41:59 darkstar kernel: [  438.001442]  [] l2cap_sock_connect+0x174/0x26b [l2cap]
Oct  2 17:41:59 darkstar kernel: [  438.001448]  [] sys_connect+0x60/0x7a
Oct  2 17:41:59 darkstar kernel: [  438.001453]  [] ? lock_release_non_nested+0x84/0x1de
Oct  2 17:41:59 darkstar kernel: [  438.001458]  [] ? might_fault+0x47/0x81
Oct  2 17:41:59 darkstar kernel: [  438.001462]  [] ? might_fault+0x47/0x81
Oct  2 17:41:59 darkstar kernel: [  438.001468]  [] ? __copy_from_user_ll+0x11/0xce
Oct  2 17:41:59 darkstar kernel: [  438.001472]  [] sys_socketcall+0x82/0x17b
Oct  2 17:41:59 darkstar kernel: [  438.001477]  [] syscall_call+0x7/0xb

Signed-off-by: Dave Young 
Signed-off-by: David S. Miller

net: Make setsockopt() optlen be unsigned.

2009-09-30T23:12:20+00:00

This provides safety against negative optlen at the type
level instead of depending upon (sometimes non-trivial)
checks against this sprinkled all over the the place, in
each and every implementation.

Based upon work done by Arjan van de Ven and feedback
from Linus Torvalds.

Signed-off-by: David S. Miller

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid

2009-09-22T14:51:28+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid:
  HID: Remove duplicate Kconfig entry
  HID: consolidate connect and disconnect into core code
  HID: fix non-atomic allocation in hid_input_report

HID: consolidate connect and disconnect into core code

2009-09-17T13:15:11+00:00

HID core registers input, hidraw and hiddev devices, but leaves
unregistering it up to the individual driver, which is not really nice.
Let's move all the logic to the core.

Reported-by: Marcel Holtmann 
Reported-by: Brian Rogers 
Acked-by: Marcel Holtmann 
Signed-off-by: Jiri Kosina

driver model: constify attribute groups

2009-09-15T16:50:47+00:00

Let attribute group vectors be declared "const".  We'd
like to let most attribute metadata live in read-only
sections... this is a start.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

net: Add DEVTYPE support for Ethernet based devices

2009-09-11T19:54:55+00:00

The Ethernet framing is used for a lot of devices these days. Most
prominent are WiFi and WiMAX based devices. However for userspace
application it is important to classify these devices correctly and
not only see them as Ethernet devices. The daemons like HAL, DeviceKit
or even NetworkManager with udev support tries to do the classification
in userspace with a lot trickery and extra system calls. This is not
good and actually reaches its limitations. Especially since the kernel
does know the type of the Ethernet device it is pretty stupid.

To solve this problem the underlying device type needs to be set and
then the value will be exported as DEVTYPE via uevents and available
within udev.

  # cat /sys/class/net/wlan0/uevent
  DEVTYPE=wlan
  INTERFACE=wlan0
  IFINDEX=5

This is similar to subsystems like USB and SCSI that distinguish
between hosts, devices, disks, partitions etc.

The new SET_NETDEV_DEVTYPE() is a convenience helper to set the actual
device type. All device types are free form, but for convenience the
same strings as used with RFKILL are choosen.

Signed-off-by: Marcel Holtmann 
Signed-off-by: David S. Miller