linux-toradex.git/net/bridge/br_if.c, branch v2.6.38-rc2

bridge: add RCU annotations to bridge port lookup

2010-11-15T19:13:18+00:00

br_port_get() renamed to br_port_get_rtnl() to make clear RTNL is held.

Signed-off-by: Eric Dumazet 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: fix RCU races with bridge port

2010-11-15T19:13:17+00:00

The macro br_port_exists() is not enough protection when only
RCU is being used. There is a tiny race where other CPU has cleared port
handler hook, but is bridge port flag might still be set.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: avoid ethtool on non running interface

2010-08-25T23:36:51+00:00

If bridge port is offline, don't call ethtool to query speed.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: fix locking comment

2010-08-25T23:36:50+00:00

The carrier check is not called from work queue in current code.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: use rx_handler_data pointer to store net_bridge_port pointer

2010-06-15T18:48:58+00:00

Register net_bridge_port pointer as rx_handler data pointer. As br_port is
removed from struct net_device, another netdev priv_flag is added to indicate
the device serves as a bridge port. Also rcuized pointers are now correctly
dereferenced in br_fdb.c and in netfilter parts.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net: add rx_handler data pointer

2010-06-15T18:47:11+00:00

Add possibility to register rx_handler data pointer along with a rx_handler.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

bridge: Fix netpoll support

2010-06-15T18:00:40+00:00

There are multiple problems with the newly added netpoll support:

1) Use-after-free on each netpoll packet.
2) Invoking unsafe code on netpoll/IRQ path.
3) Breaks when netpoll is enabled on the underlying device.

This patch fixes all of these problems.  In particular, we now
allocate proper netpoll structures for each underlying device.

We only allow netpoll to be enabled on the bridge when all the
devices underneath it support netpoll.  Once it is enabled, we
do not allow non-netpoll devices to join the bridge (until netpoll
is disabled again).

This allows us to do away with the npinfo juggling that caused
problem number 1.

Incidentally this patch fixes number 2 by bypassing unsafe code
such as multicast snooping and netfilter.

Reported-by: Qianfeng Zhang 
Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

net: replace hooks in __netif_receive_skb V5

2010-06-02T14:11:15+00:00

What this patch does is it removes two receive frame hooks (for bridge and for
macvlan) from __netif_receive_skb. These are replaced them with a single
hook for both. It only supports one hook per device because it makes no
sense to do bridging and macvlan on the same device.

Then a network driver (of virtual netdev like macvlan or bridge) can register
an rx_handler for needed net device.

Signed-off-by: Jiri Pirko 
Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: fix build for CONFIG_SYSFS disabled

2010-05-18T19:26:27+00:00

Fix build when CONFIG_SYSFS is not enabled:
net/bridge/br_if.c:136: error: 'struct net_bridge_port' has no member named 'sysfs_name'

Note: dev->name == sysfs_name except when change name is in
progress, and we are protected from that by RTNL mutex.

Signed-off-by: Randy Dunlap 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: update sysfs link names if port device names have changed

2010-05-16T06:10:15+00:00

Links for each port are created in sysfs using the device
name, but this could be changed after being added to the
bridge.

As well as being unable to remove interfaces after this
occurs (because userspace tools don't recognise the new
name, and the kernel won't recognise the old name), adding
another interface with the old name to the bridge will
cause an error trying to create the sysfs link.

This fixes the problem by listening for NETDEV_CHANGENAME
notifications and renaming the link.

https://bugzilla.kernel.org/show_bug.cgi?id=12743

Signed-off-by: Simon Arlott 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller