linux-toradex.git/net/bridge, branch v2.6.19.2 Linux kernel for Apalis and Colibri modules [PATCH] ebtables: don't compute gap before checking struct type 2007-01-10T19:05:22+00:00 Chuck Ebbert 76306.1226@compuserve.com 2007-01-04T07:59:56+00:00 ff6173b1de40f8b0341c18a8e12414a59bcf7f52 We cannot compute the gap until we know we have a 'struct ebt_entry' and not 'struct ebt_entries'. Failure to check can cause crash. Tested-by: Santiago Garcia Mantinan <manty@manty.net> Acked-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
We cannot compute the gap until we know we have a 'struct ebt_entry'
and not 'struct ebt_entries'.  Failure to check can cause crash.

Tested-by: Santiago Garcia Mantinan <manty@manty.net>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] NETFILTER: bridge netfilter: deal with martians correctly 2006-12-11T19:32:38+00:00 Bart De Schuymer bdschuym@pandora.be 2006-12-04T11:22:10+00:00 721aed8126ef1b3823fdd27c3fc3b98667e80fa9 The attached patch resolves an issue where a IP DNATed packet with a martian source is forwarded while it's better to drop it. It also resolves messages complaining about ip forwarding being disabled while it's actually enabled. Thanks to lepton <ytht.net@gmail.com> for reporting this problem. This is probably a candidate for the -stable release. Signed-off-by: Bart De Schuymer <bdschuym@pandora.be> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
The attached patch resolves an issue where a IP DNATed packet with a
martian source is forwarded while it's better to drop it. It also
resolves messages complaining about ip forwarding being disabled while
it's actually enabled. Thanks to lepton <ytht.net@gmail.com> for
reporting this problem.

This is probably a candidate for the -stable release.

Signed-off-by: Bart De Schuymer <bdschuym@pandora.be>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] EBTABLES: Prevent wraparounds in checks for entry components' sizes. 2006-12-11T19:32:37+00:00 Al Viro viro@zeniv.linux.org.uk 2006-12-01T03:47:59+00:00 bf59e3085f0d107969c01c3c00c88b0db3a3ca82 Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] EBTABLES: Deal with the worst-case behaviour in loop checks. 2006-12-11T19:32:37+00:00 Al Viro viro@zeniv.linux.org.uk 2006-12-01T03:47:58+00:00 dc983545ac3c17728ebb1e0c56aadc85ae3f8daf No need to revisit a chain we'd already finished with during the check for current hook. It's either instant loop (which we'd just detected) or a duplicate work. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
No need to revisit a chain we'd already finished with during
the check for current hook.  It's either instant loop (which
we'd just detected) or a duplicate work.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] EBTABLES: Verify that ebt_entries have zero ->distinguisher. 2006-12-11T19:32:37+00:00 Al Viro viro@zeniv.linux.org.uk 2006-12-01T03:47:56+00:00 2066918ca75a860c085f294db4f679a397bcc9a3 We need that for iterator to work; existing check had been too weak. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
We need that for iterator to work; existing check had been too weak.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] EBTABLES: Fix wraparounds in ebt_entries verification. 2006-12-11T19:32:37+00:00 Al Viro viro@zeniv.linux.org.uk 2006-12-01T03:47:52+00:00 1ebe9529ae0ea279959d6455811f6f8cfcff0485 We need to verify that a) we are not too close to the end of buffer to dereference b) next entry we'll be checking won't be _before_ our While we are at it, don't subtract unrelated pointers... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> 
We need to verify that
	a) we are not too close to the end of buffer to dereference
	b) next entry we'll be checking won't be _before_ our

While we are at it, don't subtract unrelated pointers...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[PATCH] bridge: fix possible overflow in get_fdb_entries 2006-11-29T01:26:50+00:00 Chris Wright chrisw@sous-sol.org 2006-11-20T23:02:49+00:00 ba8379b220509e9448c00a77cf6c15ac2a559cc7 Make sure to properly clamp maxnum to avoid overflow Signed-off-by: Chris Wright <chrisw@sous-sol.org> Acked-by: Eugene Teo <eteo@redhat.com> Acked-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> 
Make sure to properly clamp maxnum to avoid overflow

Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Acked-by: Eugene Teo <eteo@redhat.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
[NETFILTER]: silence a warning in ebtables 2006-11-02T02:07:27+00:00 Meelis Roos mroos@linux.ee 2006-11-02T02:07:27+00:00 6f5b7ef6b5816dc497094048d7d8a270004602d6 net/bridge/netfilter/ebtables.c: In function 'ebt_dev_check': net/bridge/netfilter/ebtables.c:89: warning: initialization discards qualifiers from pointer target type So make the char* a const char * and the warning is gone. Signed-off-by: Meelis Roos <mroos@linux.ee> Signed-off-by: David S. Miller <davem@davemloft.net> 
net/bridge/netfilter/ebtables.c: In function 'ebt_dev_check':
net/bridge/netfilter/ebtables.c:89: warning: initialization discards qualifiers from pointer target type

So make the char* a const char * and the warning is gone.

Signed-off-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: David S. Miller <davem@davemloft.net>
[BRIDGE]: correct print message typo 2006-10-26T06:07:37+00:00 Randy Dunlap randy.dunlap@oracle.com 2006-10-26T06:07:37+00:00 1842c4bef61f985fbec6df7150041b85d8b52b1a Correct message typo/spello. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Correct message typo/spello.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[BRIDGE]: flush forwarding table when device carrier off 2006-10-16T06:14:13+00:00 Stephen Hemminger shemminger@osdl.org 2006-10-12T21:45:38+00:00 1a620698c29b5e18150ec04ace0609fb07d08d3e Flush the forwarding table when carrier is lost. This helps for availability because we don't want to forward to a downed device and new packets may come in on other links. Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
Flush the forwarding table when carrier is lost. This helps for
availability because we don't want to forward to a downed device and
new packets may come in on other links.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>