linux-toradex.git/net/bridge, branch v2.6.35.4

bridge: Fix skb leak when multicast parsing fails on TX

2010-08-26T23:45:58+00:00

[ Upstream commit 6d1d1d398cb7db7a12c5d652d50f85355345234f ]

On the bridge TX path we're leaking an skb when br_multicast_rcv
returns an error.

Reported-by: David Lamparter 
Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

bridge: add rcu_read_lock on transmit

2010-08-26T23:45:58+00:00

[ Upstream commit eeaf61d8891f9c9ed12c1a667e72bf83f0857954 ]

Long ago, when bridge was converted to RCU, rcu lock was equivalent
to having preempt disabled. RCU has changed a lot since then and
bridge code was still assuming the since transmit was called with
bottom half disabled, it was RCU safe.

Signed-off-by: Stephen Hemminger 
Tested-by: Johannes Berg 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

bridge: Partially disable netpoll support

2010-07-20T06:28:25+00:00

The new netpoll code in bridging contains use-after-free bugs
that are non-trivial to fix.

This patch fixes this by removing the code that uses skbs after
they're freed.

As a consequence, this means that we can no longer call bridge
from the netpoll path, so this patch also removes the controller
function in order to disable netpoll.

Signed-off-by: Herbert Xu 

Thanks,
Signed-off-by: David S. Miller

bridge: Clear IPCB before possible entry into IP stack

2010-07-07T21:43:33+00:00

The bridge protocol lives dangerously by having incestuous relations
with the IP stack.  In this instance an abomination has been created
where a bogus IPCB area from a bridged packet leads to a crash in
the IP stack because it's interpreted as IP options.

This patch papers over the problem by clearing the IPCB area in that
particular spot.  To fix this properly we'd also need to parse any
IP options if present but I'm way too lazy for that.

Signed-off-by: Herbert Xu 

Cheers,
Signed-off-by: David S. Miller

bridge br_multicast: BUG: unable to handle kernel NULL pointer dereference

2010-07-06T03:08:06+00:00

On Tue, Jul 06, 2010 at 08:48:35AM +0800, Herbert Xu wrote:
>
> bridge: Restore NULL check in br_mdb_ip_get

Resend with proper attribution.

bridge: Restore NULL check in br_mdb_ip_get

Somewhere along the line the NULL check in br_mdb_ip_get went
AWOL, causing crashes when we receive an IGMP packet with no
multicast table allocated.

This patch restores it and ensures all br_mdb_*_get functions
use it.

Reported-by: Frank Arnold 
Signed-off-by: Herbert Xu 

Thanks,
Signed-off-by: David S. Miller

bridge: fdb cleanup runs too often

2010-06-17T20:49:14+00:00

It is common in end-node, non STP bridges to set forwarding
delay to zero; which causes the forwarding database cleanup
to run every clock tick. Change to run only as soon as needed
or at next ageing timer interval which ever is sooner.

Use round_jiffies_up macro rather than attempting round up
by changing value.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: Fix OOM crash in deliver_clone

2010-06-16T04:43:07+00:00

The bridge multicast patches introduced an OOM crash in the forward
path, when deliver_clone fails to clone the skb.

Reported-by: Mark Wagner 
Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

sysfs: add struct file* to bin_attr callbacks

2010-05-21T16:37:31+00:00

This allows bin_attr->read,write,mmap callbacks to check file specific data
(such as inode owner) as part of any privilege validation.

Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

bridge: fix build for CONFIG_SYSFS disabled

2010-05-18T19:26:27+00:00

Fix build when CONFIG_SYSFS is not enabled:
net/bridge/br_if.c:136: error: 'struct net_bridge_port' has no member named 'sysfs_name'

Note: dev->name == sysfs_name except when change name is in
progress, and we are protected from that by RTNL mutex.

Signed-off-by: Randy Dunlap 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller

bridge: update sysfs link names if port device names have changed

2010-05-16T06:10:15+00:00

Links for each port are created in sysfs using the device
name, but this could be changed after being added to the
bridge.

As well as being unable to remove interfaces after this
occurs (because userspace tools don't recognise the new
name, and the kernel won't recognise the old name), adding
another interface with the old name to the bridge will
cause an error trying to create the sysfs link.

This fixes the problem by listening for NETDEV_CHANGENAME
notifications and renaming the link.

https://bugzilla.kernel.org/show_bug.cgi?id=12743

Signed-off-by: Simon Arlott 
Acked-by: Stephen Hemminger 
Signed-off-by: David S. Miller