linux-toradex.git/net/caif/chnl_net.c, branch v4.9.36

caif: Remove unneeded header file

2016-06-28T09:26:14+00:00

Drop redundant include of moduleparam.h

The Coccinelle semantic patch used to make this change is as follows:
@ includesmodule @
@@

#include 

@ depends on includesmodule @
@@

- #include 

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: David S. Miller

caif: remove wrong dev_net_set() call

2015-01-29T22:20:02+00:00

src_net points to the netns where the netlink message has been received. This
netns may be different from the netns where the interface is created (because
the user may add IFLA_NET_NS_[PID|FD]). In this case, src_net is the link netns.

It seems wrong to override the netns in the newlink() handler because if it
was not already src_net, it means that the user explicitly asks to create the
netdevice in another netns.

CC: Sjur Brændeland 
CC: Dmitry Tarnyagin 
Fixes: 8391c4aab1aa ("caif: Bugfixes in CAIF netdevice for close and flow control")
Fixes: c41254006377 ("caif-hsi: Add rtnl support")
Signed-off-by: Nicolas Dichtel 
Signed-off-by: David S. Miller

caif: __dev_get_by_index instead of dev_get_by_index to find interface

2014-01-15T02:50:47+00:00

The following call chains indicate that chnl_net_open() is under
rtnl_lock protection as __dev_open() is protected by rtnl_lock.
So if __dev_get_by_index() instead of dev_get_by_index() is used
to find interface handler in it, this would help us avoid to change
interface reference counter.

__dev_open()
  chnl_net_open()

Cc: Dmitry Tarnyagin 
Signed-off-by: Ying Xue 
Signed-off-by: David S. Miller

caif: Remove bouncing address for Daniel Martensson

2013-04-23T17:25:51+00:00

cc: Daniel Martensson 
Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Remove my bouncing email address.

2013-04-23T17:25:51+00:00

Remove my soon bouncing email address.
Also remove the "Contact:" line in file header.
The MAINTAINERS file is a better place to find the
contact person anyway.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

CAIF: fix indentation for function arguments

2013-03-07T21:24:45+00:00

This lines up function arguments on second and subsequent lines at the
first column after the openning parenthesis of the first line.

Signed-off-by: Silviu-Mihai Popescu 
Signed-off-by: David S. Miller

caif: Do not dereference NULL in chnl_recv_cb()

2012-08-20T09:47:49+00:00

In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer()
which may return NULL, but we do not check for a NULL pointer before
dereferencing it.
This patch adds such a NULL check and properly free's allocated memory
and return an error (-EINVAL) on failure - much better than crashing..

Signed-off-by: Jesper Juhl 
Acked-by: Sjur Brændeland 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-04-13T15:36:48+00:00

Pull in the 'net' tree to get CAIF bug fixes upon which
the following set of CAIF feature patches depend.

Signed-off-by: David S. Miller

caif: Fix memory leakage in the chnl_net.c.

2012-04-13T15:01:44+00:00

Added kfree_skb() calls in the chnk_net.c file on
the error paths.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Stop using NLA_PUT*().

2012-04-02T08:33:44+00:00

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller