linux-toradex.git/net/caif, branch v3.0.16

caif: Fix BUG() with network namespaces

2011-11-11T17:35:47+00:00

commit 08613e4626c06ca408fc55071f6aedee36986a87 upstream.

The caif code will register its own pernet_operations, and then register
a netdevice_notifier. Each time the netdevice_notifier is triggered,
it'll do some stuff... including a lookup of its own pernet stuff with
net_generic().

If the net_generic() call ever returns NULL, the caif code will BUG().
That doesn't seem *so* unreasonable, I suppose — it does seem like it
should never happen.

However, it *does* happen. When we clone a network namespace,
setup_net() runs through all the pernet_operations one at a time. It
gets to loopback before it gets to caif. And loopback_net_init()
registers a netdevice... while caif hasn't been initialised. So the caif
netdevice notifier triggers, and immediately goes BUG().

We could imagine a complex and overengineered solution to this generic
class of problems, but this patch takes the simple approach. It just
makes caif_device_notify() *not* go looking for its pernet data
structures if the device it's being notified about isn't a caif device
in the first place.

Signed-off-by: David Woodhouse 
Acked-by: Sjur Brændeland 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

caif: Bugfix - XOFF removed channel from caif-mux

2011-06-17T03:59:09+00:00

XOFF was mixed up with DOWN indication, causing causing CAIF channel to be
removed from mux and all incoming traffic to be lost after receiving flow-off.
Fix this by replacing FLOW_OFF with DOWN notification.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Fix race when conditionally taking rtnl lock

2011-06-02T04:13:53+00:00

Take the RTNL lock unconditionally when calling dev_close.
Taking the lock conditionally may cause race conditions.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Plug memory leak for checksum error

2011-05-23T00:11:49+00:00

In case of checksum error, the framing layer returns -EILSEQ, but
does not free the packet. Plug this hole by freeing the packet if
-EILSEQ is returned.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Fix freezes when running CAIF loopback device

2011-05-23T00:11:48+00:00

Fix spinlock bugs when running out of link-ids in loopback tests and
avoid allocating link-id when error is set in link-setup-response.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Fixes freeze on Link layer removal.

2011-05-23T00:11:47+00:00

CAIF Socket layer - caif_socket.c:
- Plug mem-leak at reconnect.
- Always call disconnect to cleanup CAIF stack.
- Disconnect will always report success.

CAIF configuration layer - cfcnfg.c
- Disconnect must dismantle the caif stack correctly
- Protect against faulty removals (check on id zero)

CAIF mux layer - cfmuxl.c
- When inserting new service layer in the MUX remove
  any old entries with the same ID.
- When removing CAIF Link layer, remove the associated
  service layers before notifying service layers.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Bugfix add check NULL pointer before calling functions.

2011-05-23T00:11:47+00:00

Add check on layer->dn != NULL before calling functions in
layer below.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: remove unesesarry exports

2011-05-15T21:45:56+00:00

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Bugfix debugfs directory name must be unique.

2011-05-15T21:45:56+00:00

Race condition caused debugfs_create_dir() to fail due to duplicate
name. Use atomic counter to create unique directory name.

net_ratelimit() is introduced to limit debug printouts.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller

caif: Handle dev_queue_xmit errors.

2011-05-15T21:45:56+00:00

Do proper handling of dev_queue_xmit errors in order to
avoid double free of skb and leaks in error conditions.
In cfctrl pending requests are removed when CAIF Link layer goes down.

Signed-off-by: Sjur Brændeland 
Signed-off-by: David S. Miller