linux-toradex.git/net/caif, branch v3.18

caif_usb: use target structure member in memset

2014-10-14T20:05:45+00:00

parent cfusbl was used instead of first structure member 'layer'

Suggested-by: Joe Perches 
Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

caif_usb: remove redundant memory message

2014-10-14T20:05:45+00:00

Let MM subsystem display out of memory messages.

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

caif: replace kmalloc/memset 0 by kzalloc

2014-10-14T20:04:07+00:00

Also add blank line after declaration

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

caif: remove unnecessary break after goto

2014-07-15T23:27:01+00:00

Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

net/caif/caif_socket.c: remove unnecessary null test before debugfs_remove_recursive

2014-07-03T00:05:29+00:00

based on checkpatch:
"debugfs_remove_recursive(NULL) is safe this check is probably not required"

Cc: Dmitry Tarnyagin 
Cc: "David S. Miller" 
Cc: netdev@vger.kernel.org
Signed-off-by: Fabian Frederick 
Signed-off-by: David S. Miller

net: Fix use after free by removing length arg from sk_data_ready callbacks.

2014-04-11T20:15:36+00:00

Several spots in the kernel perform a sequence like:

	skb_queue_tail(&sk->s_receive_queue, skb);
	sk->sk_data_ready(sk, skb->len);

But at the moment we place the SKB onto the socket receive queue it
can be consumed and freed up.  So this skb->len access is potentially
to freed up memory.

Furthermore, the skb->len can be modified by the consumer so it is
possible that the value isn't accurate.

And finally, no actual implementation of this callback actually uses
the length argument.  And since nobody actually cared about it's
value, lots of call sites pass arbitrary values in such as '0' and
even '1'.

So just remove the length argument from the callback, that way there
is no confusion whatsoever and all of these use-after-free cases get
fixed as a side effect.

Based upon a patch by Eric Dumazet and his suggestion to audit this
issue tree-wide.

Signed-off-by: David S. Miller

net: Include appropriate header file in caif/cfsrvl.c

2014-02-10T01:32:49+00:00

Include appropriate header file net/caif/caif_dev.h in caif/cfsrvl.c
because it has prototype declaration of functions defined in
caif/cfsrvl.c.

This eliminates the following warning in caif/cfsrvl.c:
net/caif/cfsrvl.c:198:6: warning: no previous prototype for ‘caif_free_client’ [-Wmissing-prototypes]
net/caif/cfsrvl.c:208:6: warning: no previous prototype for ‘caif_client_register_refcnt’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: David S. Miller

net: Include appropriate header file in caif/caif_dev.c

2014-02-10T01:32:49+00:00

Include appropriate header file net/caif/caif_dev.h in caif/caif_dev.c
because it has prototype declarations of function defined in
caif/caif_dev.c.

This eliminates the following file in caif/caif_dev.c:
net/caif/caif_dev.c:303:6: warning: no previous prototype for ‘caif_enroll_dev’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: David S. Miller

net: Missing change from the ether_addr_copy() fixups.

2014-01-22T06:54:01+00:00

Signed-off-by: David S. Miller

caif_usb: Use ether_addr_copy

2014-01-22T02:13:04+00:00

Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN) to
save some cycles on arm and powerpc.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller