linux-toradex.git/net/ceph/osdmap.c, branch v3.12.16

libceph: use pg_num_mask instead of pgp_num_mask for pg.seed calc

2013-09-04T05:08:10+00:00

Fix a typo that used the wrong bitmask for the pg.seed calculation.  This
is normally unnoticed because in most cases pg_num == pgp_num.  It is, however,
a bug that is easily corrected.

CC: stable@vger.kernel.org
Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

libceph: define ceph_decode_pgid() only once

2013-05-02T04:17:52+00:00

There are two basically identical definitions of __decode_pgid()
in libceph, one in "net/ceph/osdmap.c" and the other in
"net/ceph/osd_client.c".  Get rid of both, and instead define
a single inline version in "include/linux/ceph/osdmap.h".

Signed-off-by: Alex Elder 
Reviewed-by: Josh Durgin

libceph: rename ceph_calc_object_layout()

2013-05-02T04:16:17+00:00

The purpose of ceph_calc_object_layout() is to fill in the pool
number and seed for a ceph_pg structure provided, based on a given
osd map and target object id.

Currently that function takes a file layout parameter, but the only
thing used out of that is its pool number.

Change the function so it takes a pool number rather than the full
file layout structure.  Only update the ceph_pg if the pool is found
in the osd map.  Get rid of few useless lines of code from the
function while there.

Since the function now very clearly just fills in the ceph_pg
structure it's provided, rename it ceph_calc_ceph_pg().

Signed-off-by: Alex Elder 
Reviewed-by: Josh Durgin

libceph: fix decoding of pgids

2013-03-11T21:31:00+00:00

In 4f6a7e5ee1393ec4b243b39dac9f36992d161540 we effectively dropped support
for the legacy encoding for the OSDMap and incremental.  However, we didn't
fix the decoding for the pgid.

Signed-off-by: Sage Weil 
Reviewed-by: Yehuda Sadeh

libceph: add support for HASHPSPOOL pool flag

2013-02-26T23:03:06+00:00

The legacy behavior adds the pgid seed and pool together as the input for
CRUSH.  That is problematic because each pool's PGs end up mapping to the
same OSDs: 1.5 == 2.4 == 3.3 == ...

Instead, if the HASHPSPOOL flag is set, we has the ps and pool together and
feed that into CRUSH.  This ensures that two adjacent pools will map to
an independent pseudorandom set of OSDs.

Advertise our support for this via a protocol feature flag.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

libceph: calculate placement based on the internal data types

2013-02-26T23:02:37+00:00

Instead of using the old ceph_object_layout struct, update our internal
ceph_calc_object_layout method to use the ceph_pg type.  This allows us to
pass the full 32-bit precision of the pgid.seed to the callers.  It also
allows some callers to avoid reaching into the request structures for the
struct ceph_object_layout fields.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

ceph: update support for PGID64, PGPOOL3, OSDENC protocol features

2013-02-26T23:02:25+00:00

Support (and require) the PGID64, PGPOOL3, and OSDENC protocol features.
These have been present in ceph.git since v0.42, Feb 2012.  Require these
features to simplify support; nobody is running older userspace.

Note that the new request and reply encoding is still not in place, so the new
code is not yet functional.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

libceph: decode into cpu-native ceph_pg type

2013-02-26T23:01:57+00:00

Always decode data into our cpu-native ceph_pg type that has the correct
field widths.  Limit any remaining uses of ceph_pg_v1 to dealing with the
legacy protocol.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

libceph: rename ceph_pg -> ceph_pg_v1

2013-02-26T23:01:41+00:00

Rename the old version this type to distinguish it from the new version.

Signed-off-by: Sage Weil 
Reviewed-by: Alex Elder

libceph: fix undefined behavior when using snprintf()

2013-01-25T23:48:59+00:00

The variable "str" is used as both the source and destination in
function snprintf(), which is undefined behavior based on C11. The
original description in C11 is:
	"If copying takes place between objects that
	overlap, the behavior is undefined."

And, the function of ceph_osdmap_state_str() is to return the osdmap
state, so it should return "doesn't exist" when all the conditions
are not satisfied. I fix it in this patch.

[elder@inktank.com: shortened the commit message]

Signed-off-by: Cong Ding 
Reviewed-by: Alex Elder