linux-toradex.git/net/core/dev.c, branch v4.16-rc4

net: fix race on decreasing number of TX queues

2018-02-14T19:12:55+00:00

netif_set_real_num_tx_queues() can be called when netdev is up.
That usually happens when user requests change of number of
channels/rings with ethtool -L.  The procedure for changing
the number of queues involves resetting the qdiscs and setting
dev->num_tx_queues to the new value.  When the new value is
lower than the old one, extra care has to be taken to ensure
ordering of accesses to the number of queues vs qdisc reset.

Currently the queues are reset before new dev->num_tx_queues
is assigned, leaving a window of time where packets can be
enqueued onto the queues going down, leading to a likely
crash in the drivers, since most drivers don't check if TX
skbs are assigned to an active queue.

Fixes: e6484930d7c7 ("net: allocate tx queues in register_netdevice")
Signed-off-by: Jakub Kicinski 
Signed-off-by: David S. Miller

net_sched: plug in qdisc ops change_tx_queue_len

2018-01-29T17:42:15+00:00

Introduce a new qdisc ops ->change_tx_queue_len() so that
each qdisc could decide how to implement this if it wants.
Previously we simply read dev->tx_queue_len, after pfifo_fast
switches to skb array, we need this API to resize the skb array
when we change dev->tx_queue_len.

To avoid handling race conditions with TX BH, we need to
deactivate all TX queues before change the value and bring them
back after we are done, this also makes implementation easier.

Cc: John Fastabend 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

net: introduce helper dev_change_tx_queue_len()

2018-01-29T17:42:15+00:00

This patch promotes the local change_tx_queue_len() to a core
helper function, dev_change_tx_queue_len(), so that rtnetlink
and net-sysfs could share the code. This also prepares for the
following patch.

Note, the -EFAULT in the original code doesn't make sense,
we should propagate the errno from notifiers.

Cc: John Fastabend 
Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

dev: advertise the new ifindex when the netns iface changes

2018-01-29T17:23:52+00:00

The goal is to let the user follow an interface that moves to another
netns.

CC: Jiri Benc 
CC: Christian Brauner 
Signed-off-by: Nicolas Dichtel 
Reviewed-by: Jiri Benc 
Signed-off-by: David S. Miller

dev: always advertise the new nsid when the netns iface changes

2018-01-29T17:23:51+00:00

The user should be able to follow any interface that moves to another
netns.  There is no reason to hide physical interfaces.

CC: Jiri Benc 
CC: Christian Brauner 
Signed-off-by: Nicolas Dichtel 
Reviewed-by: Jiri Benc 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2018-01-23T18:51:56+00:00

en_rx_am.c was deleted in 'net-next' but had a bug fixed in it in
'net'.

The esp{4,6}_offload.c conflicts were overlapping changes.
The 'out' label is removed so we just return ERR_PTR(-EINVAL)
directly.

Signed-off-by: David S. Miller

net: core: Fix kernel-doc for netdev_upper_link()

2018-01-23T16:06:50+00:00

Fixes the following warnings:
./net/core/dev.c:6438: warning: No description found for parameter 'extack'
./net/core/dev.c:6461: warning: No description found for parameter 'extack'

Fixes: 42ab19ee9029 ("net: Add extack to upper device linking")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: core: Fix kernel-doc for call_netdevice_notifiers_info()

2018-01-23T16:06:50+00:00

Remove the @dev comment, since we do not have a net_device argument, fixes the
following kernel doc warning: /net/core/dev.c:1707: warning: Excess function
parameter 'dev' description in 'call_netdevice_notifiers_info'

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: qdisc_pkt_len_init() should be more robust

2018-01-22T21:00:05+00:00

Without proper validation of DODGY packets, we might very well
feed qdisc_pkt_len_init() with invalid GSO packets.

tcp_hdrlen() might access out-of-bound data, so let's use
skb_header_pointer() and proper checks.

Whole story is described in commit d0c081b49137 ("flow_dissector:
properly cap thoff field")

We have the goal of validating DODGY packets earlier in the stack,
so we might very well revert this fix in the future.

Signed-off-by: Eric Dumazet 
Cc: Willem de Bruijn 
Cc: Jason Wang 
Reported-by: syzbot+9da69ebac7dddd804552@syzkaller.appspotmail.com
Acked-by: Jason Wang 
Signed-off-by: David S. Miller

net: Cap number of queues even with accel_priv

2018-01-12T16:20:36+00:00

With the recent fix to ixgbe we can cap the number of queues always
regardless of if accel_priv is being used or not since the actual number of
queues are being reported via real_num_tx_queues.

Signed-off-by: Alexander Duyck 
Tested-by: Andrew Bowers 
Signed-off-by: Jeff Kirsher