linux-toradex.git/net/core/net-sysfs.c, branch v2.6.32.64

net-sysfs: Use rtnl_trylock in wireless sysfs methods.

2010-03-15T15:49:38+00:00

[ Upstream commit b8afe6416101549e877f8470f2a160df69676166 ]

The wireless sysfs methods like the rest of the networking sysfs
methods are removed with the rtnl_lock held and block until
the existing methods stop executing.  So use rtnl_trylock
and restart_syscall so that the code continues to work.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

wext: let get_wireless_stats() sleep

2009-10-05T09:22:23+00:00

A number of drivers (recently including cfg80211-based ones)
assume that all wireless handlers, including statistics, can
sleep and they often also implicitly assume that the rtnl is
held around their invocation. This is almost always true now
except when reading from sysfs:

  BUG: sleeping function called from invalid context at kernel/mutex.c:280
  in_atomic(): 1, irqs_disabled(): 0, pid: 10450, name: head
  2 locks held by head/10450:
   #0:  (&buffer->mutex){+.+.+.}, at: [] sysfs_read_file+0x24/0xf4
   #1:  (dev_base_lock){++.?..}, at: [] wireless_show+0x1a/0x4c
  Pid: 10450, comm: head Not tainted 2.6.32-rc3 #1
  Call Trace:
   [] __might_sleep+0xf0/0xf7
   [] mutex_lock_nested+0x1a/0x33
   [] wdev_lock+0xd/0xf [cfg80211]
   [] cfg80211_wireless_stats+0x45/0x12d [cfg80211]
   [] get_wireless_stats+0x16/0x1c
   [] wireless_show+0x2a/0x4c

Fix this by using the rtnl instead of dev_base_lock.

Reported-by: Miles Lane 
Signed-off-by: Johannes Berg 
Signed-off-by: David S. Miller

wext: add back wireless/ dir in sysfs for cfg80211 interfaces

2009-09-28T20:55:07+00:00

The move away from having drivers assign wireless handlers,
in favour of making cfg80211 assign them, broke the sysfs
registration (the wireless/ dir went missing) because the
handlers are now assigned only after registration, which is
too late.

Fix this by special-casing cfg80211-based devices, all
of which are required to have an ieee80211_ptr, in the
sysfs code, and also using get_wireless_stats() to have
the same values reported as in procfs.

Signed-off-by: Johannes Berg 
Reported-by: Hugh Dickins 
Tested-by: Hugh Dickins 
Signed-off-by: John W. Linville

driver model: constify attribute groups

2009-09-15T16:50:47+00:00

Let attribute group vectors be declared "const".  We'd
like to let most attribute metadata live in read-only
sections... this is a start.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

net: mark read-only arrays as const

2009-08-05T17:42:58+00:00

String literals are constant, and usually, we can also tag the array
of pointers const too, moving it to the .rodata section.

Signed-off-by: Jan Engelhardt 
Signed-off-by: David S. Miller

net: Remove bogus reference to BUS_ID_SIZE in sysfs code.

2009-05-27T04:05:19+00:00

BUS_ID_SIZE is really no more, and device names are dynamically
allocated and thus can be any necessary size.

So remove the BUG check here making sure BUS_ID_SIZE is at least
as large as IFNAMSIZ.

Signed-off-by: David S. Miller

net-sysfs: Use rtnl_trylock in sysfs methods.

2009-05-19T05:15:57+00:00

The earlier patch to fix the deadlock between a network device going
away and writing to sysfs attributes was incomplete.
- It did not set signal_pending so we would leak ERSTARTSYS to user space.
- It used ERESTARTSYS which only restarts if sigaction configures it to.
- It did not cover store and show for ifalias.

So fix all of these up and use the new helper restart_syscall so we get
the details correct on what it takes.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

net: fix warning about non-const string

2009-03-10T12:22:43+00:00

Since dev_set_name takes a printf style string, new gcc complains
if arg is not const.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

net: Avoid race between network down and sysfs

2009-03-03T08:47:46+00:00

Signed-off-by: Stephen Hemminger 
Acked-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller

netns: filter out uevent not belonging to init_net

2008-11-26T00:46:37+00:00

This patch will filter out the uevent not related to the init_net.
Without this patch if a network device is created in a network
namespace with the same name as one network device belonging to the
initial network namespace (eg. eth0), when the network namespace
will die and the network device will be destroyed, an event will
be sent and catched by the udevd daemon. That will result to have
the real network device to be shutdown because the udevd/uevent are
not namespace aware.

Signed-off-by: Daniel Lezcano 
Acked-by: "Eric W. Biederman" 
Signed-off-by: David S. Miller