linux-toradex.git/net/core/netprio_cgroup.c, branch v3.4.41

Merge branch 'for-3.4' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup

2012-03-21T01:11:21+00:00

Pull cgroup changes from Tejun Heo:
 "Out of the 8 commits, one fixes a long-standing locking issue around
  tasklist walking and others are cleanups."

* 'for-3.4' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup:
  cgroup: Walk task list under tasklist_lock in cgroup_enable_task_cg_list
  cgroup: Remove wrong comment on cgroup_enable_task_cg_list()
  cgroup: remove cgroup_subsys argument from callbacks
  cgroup: remove extra calls to find_existing_css_set
  cgroup: replace tasklist_lock with rcu_read_lock
  cgroup: simplify double-check locking in cgroup_attach_proc
  cgroup: move struct cgroup_pidlist out from the header file
  cgroup: remove cgroup_attach_task_current_cg()

netprio_cgroup: don't allocate prio table when a device is registered

2012-02-10T20:08:57+00:00

So we delay the allocation till the priority is set through cgroup,
and this makes skb_update_priority() faster when it's not set.

This also eliminates an off-by-one bug similar with the one fixed
in the previous patch.

Origionally-authored-by: Li Zefan 
Signed-off-by: Li Zefan 
Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

netprio_cgroup: fix an off-by-one bug

2012-02-10T20:08:56+00:00

# mount -t cgroup xxx /mnt
  # mkdir /mnt/tmp
  # cat /mnt/tmp/net_prio.ifpriomap
  lo 0
  eth0 0
  virbr0 0
  # echo 'lo 999' > /mnt/tmp/net_prio.ifpriomap
  # cat /mnt/tmp/net_prio.ifpriomap
  lo 999
  eth0 0
  virbr0 4101267344

We got weired output, because we exceeded the boundary of the array.
We may even crash the kernel..

Origionally-authored-by: Li Zefan 
Signed-off-by: Li Zefan 
Signed-off-by: Neil Horman 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

netprio_cgroup: Fix obo in get_prioidx

2012-02-04T21:30:24+00:00

It was recently pointed out to me that the get_prioidx function sets a bit in
the prioidx map prior to checking to see if the index being set is out of
bounds.  This patch corrects that, avoiding the possiblity of us writing beyond
the end of the array

Signed-off-by: Neil Horman 
Reported-by: Stanislaw Gruszka 
CC: Stanislaw Gruszka 
CC: "David S. Miller" 
Signed-off-by: David S. Miller

cgroup: remove cgroup_subsys argument from callbacks

2012-02-02T17:20:22+00:00

The argument is not used at all, and it's not necessary, because
a specific callback handler of course knows which subsys it
belongs to.

Now only ->pupulate() takes this argument, because the handlers of
this callback always call cgroup_add_file()/cgroup_add_files().

So we reduce a few lines of code, though the shrinking of object size
is minimal.

 16 files changed, 113 insertions(+), 162 deletions(-)

   text    data     bss     dec     hex filename
5486240  656987 7039960 13183187         c928d3 vmlinux.o.orig
5486170  656987 7039960 13183117         c9288d vmlinux.o

Signed-off-by: Li Zefan 
Signed-off-by: Tejun Heo

Revert "net: netprio_cgroup: make net_prio_subsys static"

2011-12-09T18:39:27+00:00

This reverts commit 865d9f9f748fdc1943679ea65d9ee1dc55e4a6ae.

This commit breaks the build with CONFIG_NETPRIO_CGROUP=y so
revert it. It does build as a module though. The SUBSYS macro
in the cgroup core code automatically defines a subsys structure
as extern. Long term we should fix the macro. And I need to
fully build test things.

Tested with CONFIG_NETPRIO_CGROUP={y|m|n} with and without
CONFIG_CGROUPS defined.

Signed-off-by: John Fastabend 
CC: Neil Horman 
Reported-By: Eric Dumazet 
Signed-off-by: David S. Miller

net: netprio_cgroup: make net_prio_subsys static

2011-12-09T00:58:35+00:00

net_prio_subsys can be made static this removes the sparse
warning it was throwing.

Signed-off-by: John Fastabend 
Acked-by: Neil Horman 
Signed-off-by: David S. Miller

net: treewide use of RCU_INIT_POINTER

2011-11-23T23:48:19+00:00

rcu_assign_pointer(ptr, NULL) can be safely replaced by
RCU_INIT_POINTER(ptr, NULL)

(old rcu_assign_pointer() macro was testing the NULL value and could
omit the smp_wmb(), but this had to be removed because of compiler
warnings)

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

net: add network priority cgroup infrastructure (v4)

2011-11-22T20:22:23+00:00

This patch adds in the infrastructure code to create the network priority
cgroup.  The cgroup, in addition to the standard processes file creates two
control files:

1) prioidx - This is a read-only file that exports the index of this cgroup.
This is a value that is both arbitrary and unique to a cgroup in this subsystem,
and is used to index the per-device priority map

2) priomap - This is a writeable file.  On read it reports a table of 2-tuples
 where name is the name of a network interface and priority is
indicates the priority assigned to frames egresessing on the named interface and
originating from a pid in this cgroup

This cgroup allows for skb priority to be set prior to a root qdisc getting
selected. This is benenficial for DCB enabled systems, in that it allows for any
application to use dcb configured priorities so without application modification

Signed-off-by: Neil Horman 
Signed-off-by: John Fastabend 
CC: Robert Love 
CC: "David S. Miller" 
Signed-off-by: David S. Miller