linux-toradex.git/net/core/pktgen.c, branch v4.1.27

net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-09-29T17:26:21+00:00

[ Upstream commit fecdf8be2d91e04b0a9a4f79ff06499a36f5d14f ]

pktgen_thread_worker() is obviously racy, kthread_stop() can come
between the kthread_should_stop() check and set_current_state().

Signed-off-by: Oleg Nesterov 
Reported-by: Jan Stancek 
Reported-by: Marcelo Leitner 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: pktgen: disable xmit_clone on virtual devices

2015-02-23T03:43:20+00:00

Trying to use burst capability (aka xmit_more) on a virtual device
like bonding is not supported.

For example, skb might be queued multiple times on a qdisc, with
various list corruptions.

Fixes: 38b2cf2982dc ("net: pktgen: packet bursting via skb->xmit_more")
Signed-off-by: Eric Dumazet 
Cc: Alexei Starovoitov 
Acked-by: Alexei Starovoitov 
Signed-off-by: David S. Miller

net: spelling fixes

2015-02-15T04:36:08+00:00

Spelling errors caught by codespell.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

pktgen: fix UDP checksum computation

2015-02-05T23:41:34+00:00

This patch fixes two issues in UDP checksum computation in pktgen.

First, the pseudo-header uses the source and destination IP
addresses. Currently, the ports are used for IPv4.

Second, the UDP checksum covers both header and data.  So we need to
generate the data earlier (move pktgen_finalize_skb up), and compute
the checksum for UDP header + data.

Fixes: c26bf4a51308c ("pktgen: Add UDPCSUM flag to support UDP checksums")
Signed-off-by: Sabrina Dubroca 
Acked-by: Thomas Graf 
Signed-off-by: David S. Miller

net: pktgen: Deletion of an unnecessary check before the function call "proc_remove"

2014-11-19T20:20:15+00:00

The proc_remove() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

net: pktgen: packet bursting via skb->xmit_more

2014-10-02T02:08:12+00:00

This patch demonstrates the effect of delaying update of HW tailptr.
(based on earlier patch by Jesper)

burst=1 is the default. It sends one packet with xmit_more=false
burst=2 sends one packet with xmit_more=true and
        2nd copy of the same packet with xmit_more=false
burst=3 sends two copies of the same packet with xmit_more=true and
        3rd copy with xmit_more=false

Performance with ixgbe (usec 30):
burst=1  tx:9.2 Mpps
burst=2  tx:13.5 Mpps
burst=3  tx:14.5 Mpps full 10G line rate

Signed-off-by: Alexei Starovoitov 
Signed-off-by: Eric Dumazet 
Acked-by: Jesper Dangaard Brouer 
Signed-off-by: David S. Miller

pktgen: Convert pr_warning to pr_warn

2014-09-10T19:40:10+00:00

Use the more common pr_warn.
Realign arguments.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

pktgen: add flag NO_TIMESTAMP to disable timestamping

2014-09-02T01:06:59+00:00

Then testing the TX limits of the stack, then it is useful to
be-able to disable the do_gettimeofday() timetamping on every packet.

This implements a pktgen flag NO_TIMESTAMP which will disable this
call to do_gettimeofday().

The performance change on (my system E5-2695) with skb_clone=0, goes
from TX 2,423,751 pps to 2,567,165 pps with flag NO_TIMESTAMP. Thus,
the cost of do_gettimeofday() or saving is approx 23 nanosec.

Signed-off-by: Jesper Dangaard Brouer 
Signed-off-by: David S. Miller

net: Pass a "more" indication down into netdev_start_xmit() code paths.

2014-09-02T00:39:55+00:00

For now it will always be false.

Signed-off-by: David S. Miller

net: Do txq_trans_update() in netdev_start_xmit()

2014-09-02T00:39:55+00:00

That way we don't have to audit every call site to make sure it is
doing this properly.

Signed-off-by: David S. Miller