linux-toradex.git/net/core, branch v2.6.18 Linux kernel for Apalis and Colibri modules [NEIGH]: neigh_table_clear() doesn't free stats 2006-09-18T06:21:01+00:00 Kirill Korotaev dev@openvz.org 2006-09-01T08:34:10+00:00 3fcde74b3877756f4b4725a883d0b48696c0d369 neigh_table_clear() doesn't free tbl->stats. Found by Alexey Kuznetsov. Though Alexey considers this leak minor for mainstream, I still believe that cleanup code should not forget to free some of the resources :) At least, this is critical for OpenVZ with virtualized neighbour tables. Signed-Off-By: Kirill Korotaev <dev@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
neigh_table_clear() doesn't free tbl->stats.
Found by Alexey Kuznetsov. Though Alexey considers this
leak minor for mainstream, I still believe that cleanup
code should not forget to free some of the resources :)

At least, this is critical for OpenVZ with virtualized
neighbour tables.

Signed-Off-By: Kirill Korotaev <dev@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[NET]: Disallow whitespace in network device names. 2006-08-17T23:29:56+00:00 David S. Miller davem@sunset.davemloft.net 2006-08-15T23:34:13+00:00 c7fa9d189e93877a1fa08ab00f230e0689125e45 It causes way too much trouble and confusion in userspace. Signed-off-by: David S. Miller <davem@davemloft.net> 
It causes way too much trouble and confusion in userspace.

Signed-off-by: David S. Miller <davem@davemloft.net>
[NET]: Fix potential stack overflow in net/core/utils.c 2006-08-17T23:29:47+00:00 Suresh Siddha suresh.b.siddha@intel.com 2006-08-15T07:03:01+00:00 855751125093f758871b70da2951d8b92b6368cc On High end systems (1024 or so cpus) this can potentially cause stack overflow. Fix the stack usage. Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
On High end systems (1024 or so cpus) this can potentially cause stack
overflow.  Fix the stack usage.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[VLAN]: Make sure bonding packet drop checks get done in hwaccel RX path. 2006-08-17T23:29:46+00:00 David S. Miller davem@sunset.davemloft.net 2006-08-15T00:08:36+00:00 7ea49ed73c8d0d0bdf7c11fc18c61572d2d22176 Since __vlan_hwaccel_rx() is essentially bypassing the netif_receive_skb() call that would have occurred if we did the VLAN decapsulation in software, we are missing the skb_bond() call and the assosciated checks it does. Export those checks via an inline function, skb_bond_should_drop(), and use this in __vlan_hwaccel_rx(). Signed-off-by: David S. Miller <davem@davemloft.net> 
Since __vlan_hwaccel_rx() is essentially bypassing the
netif_receive_skb() call that would have occurred if we did the VLAN
decapsulation in software, we are missing the skb_bond() call and the
assosciated checks it does.

Export those checks via an inline function, skb_bond_should_drop(),
and use this in __vlan_hwaccel_rx().

Signed-off-by: David S. Miller <davem@davemloft.net>
Merge gregkh@master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2006-08-09T18:49:13+00:00 Greg Kroah-Hartman gregkh@suse.de 2006-08-09T18:49:13+00:00 a4657141091c2f975fa35ac1ad28fffdd756091e 






[NET]: add_timer -> mod_timer() in dst_run_gc()
2006-08-09T09:25:54+00:00

Dmitry Mishin
dim@openvz.org

2006-08-09T09:25:54+00:00

7c91767a6b701543c93ebcd611dab61deff3dad1

Patch from Dmitry Mishin <dim@openvz.org>:

Replace add_timer() by mod_timer() in dst_run_gc
in order to avoid BUG message.

       CPU1                            CPU2
dst_run_gc()  entered           dst_run_gc() entered
spin_lock(&dst_lock)                   .....
del_timer(&dst_gc_timer)         fail to get lock
       ....                         mod_timer() <--- puts 
                                                 timer back
                                                 to the list
add_timer(&dst_gc_timer) <--- BUG because timer is in list already.

Found during OpenVZ internal testing.

At first we thought that it is OpenVZ specific as we
added dst_run_gc(0) call in dst_dev_event(),
but as Alexey pointed to me it is possible to trigger
this condition in mainstream kernel.

F.e. timer has fired on CPU2, but the handler was preeempted
by an irq before dst_lock is tried.
Meanwhile, someone on CPU1 adds an entry to gc list and
starts the timer.
If CPU2 was preempted long enough, this timer can expire
simultaneously with resuming timer handler on CPU1, arriving
exactly to the situation described.

Signed-off-by: Dmitry Mishin <dim@openvz.org>
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>





Patch from Dmitry Mishin <dim@openvz.org>:

Replace add_timer() by mod_timer() in dst_run_gc
in order to avoid BUG message.

       CPU1                            CPU2
dst_run_gc()  entered           dst_run_gc() entered
spin_lock(&dst_lock)                   .....
del_timer(&dst_gc_timer)         fail to get lock
       ....                         mod_timer() <--- puts 
                                                 timer back
                                                 to the list
add_timer(&dst_gc_timer) <--- BUG because timer is in list already.

Found during OpenVZ internal testing.

At first we thought that it is OpenVZ specific as we
added dst_run_gc(0) call in dst_dev_event(),
but as Alexey pointed to me it is possible to trigger
this condition in mainstream kernel.

F.e. timer has fired on CPU2, but the handler was preeempted
by an irq before dst_lock is tried.
Meanwhile, someone on CPU1 adds an entry to gc list and
starts the timer.
If CPU2 was preempted long enough, this timer can expire
simultaneously with resuming timer handler on CPU1, arriving
exactly to the situation described.

Signed-off-by: Dmitry Mishin <dim@openvz.org>
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>







[RTNETLINK]: Fix IFLA_ADDRESS handling.
2006-08-08T23:47:37+00:00

David S. Miller
davem@sunset.davemloft.net

2006-08-08T23:47:37+00:00

70f8e78e150425b01c1099087ad3decacf7e4ccf

The ->set_mac_address handlers expect a pointer to a
sockaddr which contains the MAC address, whereas
IFLA_ADDRESS provides just the MAC address itself.

So whip up a sockaddr to wrap around the netlink
attribute for the ->set_mac_address call.

Signed-off-by: David S. Miller <davem@davemloft.net>





The ->set_mac_address handlers expect a pointer to a
sockaddr which contains the MAC address, whereas
IFLA_ADDRESS provides just the MAC address itself.

So whip up a sockaddr to wrap around the netlink
attribute for the ->set_mac_address call.

Signed-off-by: David S. Miller <davem@davemloft.net>







[PKTGEN]: Make sure skb->{nh,h} are initialized in fill_packet_ipv6() too.
2006-08-08T03:52:10+00:00

David S. Miller
davem@sunset.davemloft.net

2006-08-08T03:52:10+00:00

69d8c28c9578ce78b3dc1b9be36926d962282898

Mirror the bug fix from fill_packet_ipv4()

Signed-off-by: David S. Miller <davem@davemloft.net>





Mirror the bug fix from fill_packet_ipv4()

Signed-off-by: David S. Miller <davem@davemloft.net>







[PKTGEN]: Fix oops when used with balance-tlb bonding
2006-08-08T03:49:07+00:00

Chen-Li Tien
cltien@gmail.com

2006-08-08T03:49:07+00:00

aaf580601ff244df82324fff380ed6740f27ef03

Signed-off-by: Chen-Li Tien <cltien@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>





Signed-off-by: Chen-Li Tien <cltien@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>







[NET]: Assign skb->dev in netdev_alloc_skb
2006-08-07T23:09:04+00:00

Christoph Hellwig
hch@lst.de

2006-08-07T23:09:04+00:00

7b2e497a06c0e93719fda88820e057b635e8fae2

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>





Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>