linux-toradex.git/net/dcb, branch v3.7.3 Linux kernel for Apalis and Colibri modules netlink: Rename pid to portid to avoid confusion 2012-09-10T19:30:41+00:00 Eric W. Biederman ebiederm@xmission.com 2012-09-07T20:12:54+00:00 15e473046cb6e5d18a4d0057e61d76315230382b It is a frequent mistake to confuse the netlink port identifier with a process identifier. Try to reduce this confusion by renaming fields that hold port identifiers portid instead of pid. I have carefully avoided changing the structures exported to userspace to avoid changing the userspace API. I have successfully built an allyesconfig kernel with this change. Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Acked-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
It is a frequent mistake to confuse the netlink port identifier with a
process identifier.  Try to reduce this confusion by renaming fields
that hold port identifiers portid instead of pid.

I have carefully avoided changing the structures exported to
userspace to avoid changing the userspace API.

I have successfully built an allyesconfig kernel with this change.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: Fix non-kernel-doc comments with kernel-doc start marker 2012-07-11T06:13:45+00:00 Ben Hutchings bhutchings@solarflare.com 2012-07-10T10:55:35+00:00 ae86b9e3846f6fc5509dee721f2bdba1db8ab96a Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: dcb: fix small regression in __dcbnl_pg_setcfg() 2012-06-21T22:06:00+00:00 John Fastabend john.r.fastabend@intel.com 2012-06-20T19:56:21+00:00 bb1dfefdc62fa68107c4c9f1374cb856743a9434 A small regression was introduced in the reply command of dcbnl_pg_setcfg(). User space apps may be expecting the DCB_ATTR_PG_CFG attribute to be returned with the patch below TX or RX variants are returned. commit 7be994138b188387691322921c08e19bddf6d3c5 Author: Thomas Graf <tgraf@suug.ch> Date: Wed Jun 13 02:54:55 2012 +0000 dcbnl: Shorten all command handling functions This patch reverts this behavior and returns DCB_ATTR_PG_CFG Signed-off-by: John Fastabend <john.r.fastabend@intel.com> Acked-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
A small regression was introduced in the reply command of
dcbnl_pg_setcfg(). User space apps may be expecting the
DCB_ATTR_PG_CFG attribute to be returned with the patch
below TX or RX variants are returned.

commit 7be994138b188387691322921c08e19bddf6d3c5
Author: Thomas Graf <tgraf@suug.ch>
Date:   Wed Jun 13 02:54:55 2012 +0000

    dcbnl: Shorten all command handling functions

This patch reverts this behavior and returns DCB_ATTR_PG_CFG

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Use BUG_ON() instead of BUG() 2012-06-14T08:45:46+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T22:40:15+00:00 b3908e22ad8bb6074934496ef171fd83605d7d3e Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Silence harmless gcc warning about uninitialized reply_nlh 2012-06-14T08:45:46+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T22:34:03+00:00 39912f9cf9603f0de085fb5ba916a7a88010ccd9 Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Use type safe nlmsg_data() 2012-06-13T22:46:35+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T02:55:01+00:00 7a282bc37f8a1e7b46907d78724177d20214b137 Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Move dcb app allocation into dcb_app_add() 2012-06-13T22:46:35+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T02:55:00+00:00 4e4f2f69704be0ae218d91fb827e5a6987fe262f Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Move dcb app lookup code into dcb_app_lookup() 2012-06-13T22:46:35+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T02:54:59+00:00 716b31abbd39baab307c0a7b38dce9a20c16c62d Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Return consistent error codes 2012-06-13T22:46:34+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T02:54:58+00:00 3d1f486952b750f1cca53cf22d4f769db5aba4f0 EMSGSIZE - ran out of space while constructing message EOPNOTSUPP - driver/hardware does not support operation ENODEV - network device not found EINVAL - invalid message Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
EMSGSIZE - ran out of space while constructing message
EOPNOTSUPP - driver/hardware does not support operation
ENODEV - network device not found
EINVAL - invalid message

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
dcbnl: Use dcbnl_newmsg() where possible 2012-06-13T22:46:34+00:00 Thomas Graf tgraf@suug.ch 2012-06-13T02:54:57+00:00 ab6d470735682a6e1ba889a66f56eb1640242096 Signed-off-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>