linux-toradex.git/net/dccp/ccids, branch v2.6.22.9

DCCP: Fix DCCP GFP_KERNEL allocation in atomic context

2007-08-31T06:01:01+00:00

This fixes the following bug reported in syslog:

[ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032
[ 4039.051668] in_atomic():1, irqs_disabled():0
[ 4039.051670] INFO: lockdep is turned off.
[ 4039.051674]  [] show_trace_log_lvl+0x1a/0x30
[ 4039.051687]  [] show_trace+0x12/0x14
[ 4039.051691]  [] dump_stack+0x16/0x18
[ 4039.051695]  [] __might_sleep+0xaf/0xbe
[ 4039.051700]  [] __kmalloc+0xb1/0xd0
[ 4039.051706]  [] ccid2_hc_tx_alloc_seq+0x35/0xc3 [dccp_ccid2]
[ 4039.051717]  [] ccid2_hc_tx_packet_sent+0x27f/0x2d9 [dccp_ccid2]
[ 4039.051723]  [] dccp_write_xmit+0x1eb/0x338 [dccp]
[ 4039.051741]  [] dccp_sendmsg+0x113/0x18f [dccp]
[ 4039.051750]  [] inet_sendmsg+0x2e/0x4c
[ 4039.051758]  [] sock_aio_write+0xd5/0x107
[ 4039.051766]  [] do_sync_write+0xcd/0x11c
[ 4039.051772]  [] vfs_write+0x118/0x11f
[ 4039.051840]  [] sys_write+0x3d/0x64
[ 4039.051845]  [] syscall_call+0x7/0xb
[ 4039.051848]  =======================

The problem was that GFP_KERNEL was used; fixed by using gfp_any().

Signed-off-by: Gerrit Renker 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

[DCCP]: Fix build warning when debugging is disabled.

2007-05-24T23:36:55+00:00

Signed-off-by: David S. Miller

[DCCP]: Fix bug in the calculation of very low sending rates

2007-04-26T05:28:54+00:00

This fixes an error in the calculation of t_ipi when X converges towards
very low sending rates (between 1 and 64 bytes per second).

Although this case may not sound likely, it can be reproduced by connecting,
hitting enter (1 byte sent) and waiting for some time, during which the
nofeedback timer halves the sending rate until finally it reaches the region
1..64 bytes/sec. Computing X is handled correctly (tested separately); but by
dividing X _before_ entering the calculation of t_ipi, X becomes zero as
a result.  This in turn triggers a BUG condition caught in scaled_div().

Fixed by replacing with equivalent statement and explicit typecast for good
measure.

Calculation verified and effect of patch tested - reduced never below 1 byte
per 64 seconds afterwards, i.e. not allowing divide-by-zero.

Signed-off-by: Gerrit Renker 
Acked-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: Use initial RTT sample from SYN exchange

2007-04-26T05:27:04+00:00

The patch follows the following recommendation made in an erratum to RFC 4342:

  "Senders MAY additionally make use of other available RTT measurements,
   including those from the initial Request-Response packet exchange."

It implements larger initial windows with regard to this inital RTT measurement,
using the mechanism suggested in draft-ietf-dccp-rfc3448bis, section 4.2.

Signed-off-by: Gerrit Renker 
Signed-off-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: Use function for RTT sampling

2007-04-26T05:27:01+00:00

This replaces the existing occurrences of RTT sampling with
the use of the new function dccp_sample_rtt.

Signed-off-by: Gerrit Renker 
Signed-off-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: Handle Idle and Application-Limited periods

2007-04-26T05:26:59+00:00

This updates the code with regard to handling idle and application-limited
periods as specified in [RFC 4342, 5.1].

Background:

[CCID3]: Wrap computation of RFC3390-initial rate into separate function

2007-04-26T05:26:58+00:00

The CCID 3 and TFRC specs (RFC 4342, RFC 3448, draft-3448bis) make frequent
reference to the computation of the RFC-3390 initial sending rate:

  1. Initial sending rate when RTT is known (RFC 4342, p. 6)
  2. Response to Idle/Application-Limited periods (RFC 4342, 5.1)

This warrants putting the code into its own function, for later code reuse.

Signed-off-by: Gerrit Renker 
Signed-off-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: Remove build warnings for 64bit

2007-04-26T05:26:57+00:00

This clears the following sparc64 build warnings:
 1) warning: format "%ld" expects type "long int", but argument 3 has type "suseconds_t"
 2) warning: format "%llu" expects type "long long unsigned int", but argument 3 has type "__u64"
Fixed by using typecast to unsigned. This is argued to be safe, since the quantities, after
de-scaling (factor 2^6) fit all in u32.

Signed-off-by: Gerrit Renker 
Signed-off-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: Remove race condition and update t_ipi when `s' changes

2007-04-26T05:26:52+00:00

This:

 1. removes a race condition in the access to the scheduled send time t_nom which
    results from allowing asynchronous r/w access to t_nom without locks;

 2. updates the inter-packet interval t_ipi = s/X when `s' changes, following a
    suggestion by Ian McDonald.

Signed-off-by: Gerrit Renker 
Acked-by: Ian McDonald 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[CCID3]: More verbose debugging

2007-04-26T05:26:51+00:00

This adds a few debugging statements to ccid3.c

Signed-off-by: Ian McDonald 
Signed-off-by: Gerrit Renker 
Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller