linux-toradex.git/net/dccp/ipv4.c, branch v3.3.5

dccp: Evaluate ip_hdr() only once in dccp_v4_route_skb().

2011-12-01T18:28:34+00:00

This also works around a bogus gcc warning generated by an
upcoming patch from Eric Dumazet that rearranges the layout
of struct flowi4.

Signed-off-by: David S. Miller

dccp: fix error propagation in dccp_v4_connect

2011-11-21T21:45:26+00:00

The errcode is not updated when ip_route_newports() fails.

Signed-off-by: RongQing.Li 
Signed-off-by: David S. Miller

net: add missing bh_unlock_sock() calls

2011-11-03T22:06:18+00:00

Simon Kirby reported lockdep warnings and following messages :

[104661.897577] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

[104661.923653] huh, entered softirq 3 NET_RX ffffffff81613740
preempt_count 00000101, exited with 00000102?

Problem comes from commit 0e734419
(ipv4: Use inet_csk_route_child_sock() in DCCP and TCP.)

If inet_csk_route_child_sock() returns NULL, we should release socket
lock before freeing it.

Another lock imbalance exists if __inet_inherit_port() returns an error
since commit 093d282321da ( tproxy: fix hash locking issue when using
port redirection in __inet_inherit_port()) a backport is also needed for
>= 2.6.37 kernels.

Reported-by: Simon Kirby 
Signed-off-by: Eric Dumazet 
Tested-by: Eric Dumazet 
CC: Balazs Scheidler 
CC: KOVACS Krisztian 
Reviewed-by: Thomas Gleixner 
Tested-by: Simon Kirby 
Signed-off-by: David S. Miller

net: Compute protocol sequence numbers and fragment IDs using MD5.

2011-08-07T01:33:19+00:00

Computers have become a lot faster since we compromised on the
partial MD4 hash which we use currently for performance reasons.

MD5 is a much safer choice, and is inline with both RFC1948 and
other ISS generators (OpenBSD, Solaris, etc.)

Furthermore, only having 24-bits of the sequence number be truly
unpredictable is a very serious limitation.  So the periodic
regeneration and 8-bit counter have been removed.  We compute and
use a full 32-bit sequence number.

For ipv6, DCCP was found to use a 32-bit truncated initial sequence
number (it needs 43-bits) and that is fixed here as well.

Reported-by: Dan Kaminsky 
Tested-by: Willy Tarreau 
Signed-off-by: David S. Miller

ipv4: Make caller provide flowi4 key to inet_csk_route_req().

2011-05-18T22:32:03+00:00

This way the caller can get at the fully resolved fl4->{daddr,saddr}
etc.

Signed-off-by: David S. Miller

ipv4: Use inet_csk_route_child_sock() in DCCP and TCP.

2011-05-08T22:28:03+00:00

Operation order is now transposed, we first create the child
socket then we try to hook up the route.

Signed-off-by: David S. Miller

dccp: Use cork flow in dccp_v4_connect()

2011-05-08T20:18:53+00:00

Since this is invoked from inet_stream_connect() the socket is locked
and therefore this usage is safe.

Signed-off-by: David S. Miller

dccp: Use flowi4->saddr in dccp_v4_connect()

2011-05-04T03:06:41+00:00

Signed-off-by: David S. Miller

ipv4: Get route daddr from flow key in dccp_v4_connect().

2011-04-29T06:49:30+00:00

Now that output route lookups update the flow with
destination address selection, we can fetch it from
fl4->daddr instead of rt->rt_dst

Signed-off-by: David S. Miller

inet: add RCU protection to inet->opt

2011-04-28T20:16:35+00:00

We lack proper synchronization to manipulate inet->opt ip_options

Problem is ip_make_skb() calls ip_setup_cork() and
ip_setup_cork() possibly makes a copy of ipc->opt (struct ip_options),
without any protection against another thread manipulating inet->opt.

Another thread can change inet->opt pointer and free old one under us.

Use RCU to protect inet->opt (changed to inet->inet_opt).

Instead of handling atomic refcounts, just copy ip_options when
necessary, to avoid cache line dirtying.

We cant insert an rcu_head in struct ip_options since its included in
skb->cb[], so this patch is large because I had to introduce a new
ip_options_rcu structure.

Signed-off-by: Eric Dumazet 
Cc: Herbert Xu 
Signed-off-by: David S. Miller