linux-toradex.git/net/decnet, branch v2.6.19-rc2

[DECNET]: Fix sfuzz hanging on 2.6.18

2006-10-12T08:48:20+00:00

Dave Jones wrote:
> sfuzz         D 724EF62A  2828 28717  28691                     (NOTLB)
>        cd69fe98 00000082 0000012d 724ef62a 0001971a 00000010 00000007 df6d22b0 
>        dfd81080 725bbc5e 0001971a 000cc634 00000001 df6d23bc c140e260 00000202 
>        de1d5ba0 cd69fea0 de1d5ba0 00000000 00000000 de1d5b60 de1d5b8c de1d5ba0 
> Call Trace:
>  [] lock_sock+0x75/0xa6
>  [] dn_getname+0x18/0x5f [decnet]
>  [] sys_getsockname+0x5c/0xb0
>  [] sys_socketcall+0xef/0x261
>  [] syscall_call+0x7/0xb
> DWARF2 unwinder stuck at syscall_call+0x7/0xb
> 
> I wonder if the plethora of lockdep related changes inadvertantly broke something?

Looks like unbalanced locking.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[NET]: Do not memcmp() over pad bytes of struct flowi.

2006-10-12T07:49:15+00:00

They are not necessarily initialized to zero by the compiler,
for example when using run-time initializers of automatic
on-stack variables.

Noticed by Eric Dumazet and Patrick McHardy.

Signed-off-by: David S. Miller

[NET]: Fix sk->sk_filter field access

2006-09-22T22:18:47+00:00

Function sk_filter() is called from tcp_v{4,6}_rcv() functions with arg
needlock = 0, while socket is not locked at that moment. In order to avoid
this and similar issues in the future, use rcu for sk->sk_filter field read
protection.

Signed-off-by: Dmitry Mishin 
Signed-off-by: Alexey Kuznetsov 
Signed-off-by: Kirill Korotaev

[NETLINK]: Make use of NLA_STRING/NLA_NUL_STRING attribute validation

2006-09-22T22:18:25+00:00

Converts existing NLA_STRING attributes to use the new
validation features, saving a couple of temporary buffers.

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[NET]: Use SLAB_PANIC

2006-09-22T22:18:19+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

[DECNET]: Add support for fwmark masks in routing rules

2006-09-22T22:18:11+00:00

Add support for fwmark masks. For compatibility a mask of 0xFFFFFFFF is used
when a mark value != 0 is sent without a mask.

Signed-off-by: Patrick McHardy 
Acked-by: Steven Whitehouse 
Signed-off-by: David S. Miller

[DECNET]: Convert DECnet notifications to use rtnl_notify()

2006-09-22T21:54:52+00:00

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[RTNETLINK]: Use rtnl_unicast() for rtnetlink unicasts

2006-09-22T21:54:48+00:00

Signed-off-by: Thomas Graf 
Signed-off-by: David S. Miller

[DECNET]: cleanups

2006-09-22T21:54:40+00:00

- make the following needlessly global functions static:
  - dn_fib.c: dn_fib_sync_down()
  - dn_fib.c: dn_fib_sync_up()
  - dn_rules.c: dn_fib_rule_action()
- remove the following unneeded prototype:
  - dn_fib.c: dn_cache_dump()

Signed-off-by: Adrian Bunk 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[DECNET] Fix to decnet rules compare function

2006-09-22T21:54:37+00:00

Here is a fix to the DECnet rules compare function where we used 32bit
values rather than 16bit values. Spotted by Patrick McHardy.

Signed-off-by: Steven Whitehouse 
Signed-off-by: David S. Miller