linux-toradex.git/net/devlink, branch v6.13-rc1

net: convert to nla_get_*_default()

2024-11-11T18:32:06+00:00

Most of the original conversion is from the spatch below,
but I edited some and left out other instances that were
either buggy after conversion (where default values don't
fit into the type) or just looked strange.

    @@
    expression attr, def;
    expression val;
    identifier fn =~ "^nla_get_.*";
    fresh identifier dfn = fn ## "_default";
    @@
    (
    -if (attr)
    -  val = fn(attr);
    -else
    -  val = def;
    +val = dfn(attr, def);
    |
    -if (!attr)
    -  val = def;
    -else
    -  val = fn(attr);
    +val = dfn(attr, def);
    |
    -if (!attr)
    -  return def;
    -return fn(attr);
    +return dfn(attr, def);
    |
    -attr ? fn(attr) : def
    +dfn(attr, def)
    |
    -!attr ? def : fn(attr)
    +dfn(attr, def)
    )

Signed-off-by: Johannes Berg 
Reviewed-by: Toke Høiland-Jørgensen 
Link: https://patch.msgid.link/20241108114145.0580b8684e7f.I740beeaa2f70ebfc19bfca1045a24d6151992790@changeid
Signed-off-by: Jakub Kicinski

devlink: remove unused devlink_resource_register()

2024-10-29T23:52:57+00:00

Remove unused devlink_resource_register(); all the drivers use
devl_resource_register() variant instead.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-8-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

devlink: remove unused devlink_resource_occ_get_register() and _unregister()

2024-10-29T23:52:57+00:00

Remove not used devlink_resource_occ_get_register() and
devlink_resource_occ_get_unregister() functions; current devlink resource
users are fine with devl_ variants of the two.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-7-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

devlink: region: snapshot IDs: consolidate error values

2024-10-29T23:52:57+00:00

Consolidate error codes for too big message size.

Current code is written to return -EINVAL when tailroom in the skb msg
would be exhausted precisely when it's time to nest, and return -EMSGSIZE
in all other "not enough space" conditions.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-5-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

devlink: devl_resource_register(): differentiate error codes

2024-10-29T23:52:57+00:00

Differentiate error codes of devl_resource_register().

Replace one of -EINVAL exit paths by -EEXIST. This should aid developers
introducing new resources and registering them in the wrong order.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-4-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

devlink: use devlink_nl_put_u64() helper

2024-10-29T23:52:56+00:00

Use devlink_nl_put_u64() shortcut added by prev commit on all devlink/.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-3-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

devlink: introduce devlink_nl_put_u64()

2024-10-29T23:52:56+00:00

Add devlink_nl_put_u64() that abstracts padding for u64 values.
All u64 values are passed with the very same padding option.

Reviewed-by: Wojciech Drewek 
Reviewed-by: Jiri Pirko 
Reviewed-by: Joe Damato 
Signed-off-by: Przemek Kitszel 
Link: https://patch.msgid.link/20241023131248.27192-2-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski

genetlink: extend info user-storage to match NL cb ctx

2024-10-10T15:30:21+00:00

This allows a more uniform implementation of non-dump and dump
operations, and will be used later in the series to avoid some
per-operation allocation.

Additionally rename the NL_ASSERT_DUMP_CTX_FITS macro, to
fit a more extended usage.

Suggested-by: Jakub Kicinski 
Reviewed-by: Jakub Kicinski 
Reviewed-by: Jiri Pirko 
Signed-off-by: Paolo Abeni 
Link: https://patch.msgid.link/1130cc2896626b84587a2a5f96a5c6829638f4da.1728460186.git.pabeni@redhat.com
Signed-off-by: Jakub Kicinski

devlink: Constify the 'table_ops' parameter of devl_dpipe_table_register()

2024-06-05T09:24:57+00:00

"struct devlink_dpipe_table_ops" only contains some function pointers.

Update "struct devlink_dpipe_table" and the 'table_ops' parameter of
devl_dpipe_table_register() so that structures in drivers can be
constified.

Constifying these structures will move some data to a read-only section, so
increase overall security.

Signed-off-by: Christophe JAILLET 
Reviewed-by: Wojciech Drewek 
Reviewed-by: Ido Schimmel 
Signed-off-by: David S. Miller

devlink: extend devlink_param *set pointer

2024-04-22T20:05:19+00:00

Extend devlink_param *set function pointer to take extack as a param.
Sometimes it is needed to pass information to the end user from set
function. It is more proper to use for that netlink instead of passing
message to dmesg.

Reviewed-by: Jiri Pirko 
Reviewed-by: Przemek Kitszel 
Signed-off-by: Mateusz Polchlopek 
Signed-off-by: Tony Nguyen