linux-toradex.git/net/devlink, branch v6.8-rc2

devlink: extend multicast filtering by port index

2023-12-19T14:31:40+00:00

Expose the previously introduced notification multicast messages
filtering infrastructure and allow the user to select messages using
port index.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: add a command to set notification filter and use it for multicasts

2023-12-19T14:31:40+00:00

Currently the user listening on a socket for devlink notifications
gets always all messages for all existing instances, even if he is
interested only in one of those. That may cause unnecessary overhead
on setups with thousands of instances present.

User is currently able to narrow down the devlink objects replies
to dump commands by specifying select attributes.

Allow similar approach for notifications. Introduce a new devlink
NOTIFY_FILTER_SET which the user passes the select attributes. Store
these per-socket and use them for filtering messages
during multicast send.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: introduce a helper for netlink multicast send

2023-12-19T14:31:40+00:00

Introduce a helper devlink_nl_notify_send() so each object notification
function does not have to call genlmsg_multicast_netns() with the same
arguments.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: send notifications only if there are listeners

2023-12-19T14:31:40+00:00

Introduce devlink_nl_notify_need() helper and using it to check at the
beginning of notification functions to avoid overhead of composing
notification messages in case nobody listens.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: introduce __devl_is_registered() helper and use it instead of xa_get_mark()

2023-12-19T14:31:40+00:00

Introduce __devl_is_registered() which does not assert on devlink
instance lock and use it in notifications which may be called
without devlink instance lock held.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: use devl_is_registered() helper instead xa_get_mark()

2023-12-19T14:31:40+00:00

Instead of checking the xarray mark directly using xa_get_mark() helper
use devl_is_registered() helper which wraps it up. Note that there are
couple more users of xa_get_mark() left which are going to be handled
by the next patch.

Signed-off-by: Jiri Pirko 
Signed-off-by: Paolo Abeni

devlink: warn about existing entities during reload-reinit

2023-11-30T11:31:23+00:00

During reload-reinit, all entities except for params, resources, regions
and health reporter should be removed and re-added. Add a warning to
be triggered in case the driver behaves differently.

Signed-off-by: Jiri Pirko 
Reviewed-by: Przemek Kitszel 
Signed-off-by: Paolo Abeni

devlink: Add device lock assert in reload operation

2023-11-18T17:38:50+00:00

Add an assert to verify that the device lock is always held throughout
reload operations.

Tested the following flows with netdevsim and mlxsw while lockdep is
enabled:

netdevsim:

 # echo "10 1" > /sys/bus/netdevsim/new_device
 # devlink dev reload netdevsim/netdevsim10
 # ip netns add bla
 # devlink dev reload netdevsim/netdevsim10 netns bla
 # ip netns del bla
 # echo 10 > /sys/bus/netdevsim/del_device

mlxsw:

 # devlink dev reload pci/0000:01:00.0
 # ip netns add bla
 # devlink dev reload pci/0000:01:00.0 netns bla
 # ip netns del bla
 # echo 1 > /sys/bus/pci/devices/0000\:01\:00.0/remove
 # echo 1 > /sys/bus/pci/rescan

Signed-off-by: Ido Schimmel 
Reviewed-by: Jiri Pirko 
Signed-off-by: Petr Machata 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

devlink: Acquire device lock during reload command

2023-11-18T17:38:50+00:00

Device drivers register with devlink from their probe routines (under
the device lock) by acquiring the devlink instance lock and calling
devl_register().

Drivers that support a devlink reload usually implement the
reload_{down, up}() operations in a similar fashion to their remove and
probe routines, respectively.

However, while the remove and probe routines are invoked with the device
lock held, the reload operations are only invoked with the devlink
instance lock held. It is therefore impossible for drivers to acquire
the device lock from their reload operations, as this would result in
lock inversion.

The motivating use case for invoking the reload operations with the
device lock held is in mlxsw which needs to trigger a PCI reset as part
of the reload. The driver cannot call pci_reset_function() as this
function acquires the device lock. Instead, it needs to call
__pci_reset_function_locked which expects the device lock to be held.

To that end, adjust devlink to always acquire the device lock before the
devlink instance lock when performing a reload.

Do that when reload is explicitly triggered by user space by specifying
the 'DEVLINK_NL_FLAG_NEED_DEV_LOCK' flag in the pre_doit and post_doit
operations of the reload command.

A previous patch already handled the case where reload is invoked as
part of netns dismantle.

Signed-off-by: Ido Schimmel 
Reviewed-by: Jiri Pirko 
Signed-off-by: Petr Machata 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller

devlink: Allow taking device lock in pre_doit operations

2023-11-18T17:38:50+00:00

Introduce a new private flag ('DEVLINK_NL_FLAG_NEED_DEV_LOCK') to allow
netlink commands to specify that they need to acquire the device lock in
their pre_doit operation and release it in their post_doit operation.

The reload command will use this flag in the subsequent patch.

No functional changes intended.

Signed-off-by: Ido Schimmel 
Reviewed-by: Jiri Pirko 
Signed-off-by: Petr Machata 
Reviewed-by: Simon Horman 
Signed-off-by: David S. Miller