linux-toradex.git/net/dsa, branch v3.14.3

dsa: Use ether_addr_copy

2014-01-22T02:13:05+00:00

Use ether_addr_copy instead of memcpy(a, b, ETH_ALEN) to
save some cycles on arm and powerpc.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

net: dsa: inherit addr_assign_type along with dev_addr

2013-09-04T00:57:49+00:00

A device inheriting a random or set address should reflect this in
its addr_assign_type.

Signed-off-by: Bjørn Mork 
Signed-off-by: David S. Miller

dsa: fix freeing of sparse port allocation

2013-03-25T16:23:41+00:00

If we have defined a sparse port allocation which is non-contiguous and
contains gaps, the code freeing port_names will just stop when it
encouters a first NULL port_names, which is not right, we should iterate
over all possible number of ports (DSA_MAX_PORTS) until we are done.

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

dsa: factor freeing of dsa_platform_data

2013-03-25T16:23:41+00:00

This patch factors the freeing of the struct dsa_platform_data
manipulated by the driver identically in two places to a single
function.

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

dsa: add device tree bindings to register DSA switches

2013-03-24T21:16:30+00:00

This patch adds support for registering DSA switches using Device Tree
bindings. Note that we support programming the switch routing table even
though no in-tree user seems to require it. I tested this on Armada 370
with a Marvell 88E6172 (not supported by mainline yet).

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

dsa: make dsa_switch_setup check for valid port names

2013-01-21T20:40:12+00:00

This patch changes dsa_switch_setup() to ensure that at least one valid
valid port name is specified and will bail out with an error in case we
walked the maximum number of port with a valid port name found.

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

dsa: use an unique and non conflicting bus name for the slave MII bus

2013-01-21T20:40:11+00:00

The slave MII bus registered by the DSA code is using the parent MII bus
as part of its name (ds->master_mii_bus_id), in case the parent MII bus
name is already 16 characters long (such as d0072004.mdio-mi) we will
get the following WARN_ON in dsa_switch_setup() when calling
mdiobus_register():

[   79.088782] ------------[ cut here ]------------
[   79.093448] WARNING: at fs/sysfs/dir.c:536 sysfs_add_one+0x80/0xa0()
[   79.099831] sysfs: cannot create duplicate filename
'/class/mdio_bus/d0072004.mdio-mi'

This is a genuine warning, because the DSA slave MII bus will also be
named d0072004.mdio-mi, and since MII_BUS_ID_SIZE is 17 characters long
(with null-terminator) the following will truncate the slave MII bus id:

snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "%s-%d:%.2x",
                        ds->master_mii_bus->id, ds->pd->sw_addr);

Fix this by using dsa-: which is guaranteed to be
unique.

Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

net: phy: remove flags argument from phy_{attach, connect, connect_direct}

2013-01-14T20:11:50+00:00

The flags argument of the phy_{attach,connect,connect_direct} functions
is then used to assign a struct phy_device dev_flags with its value.
All callers but the tg3 driver pass the flag 0, which results in the
underlying PHY drivers in drivers/net/phy/ not being able to actually
use any of the flags they would set in dev_flags. This patch gets rid of
the flags argument, and passes phydev->dev_flags to the internal PHY
library call phy_attach_direct() such that drivers which actually modify
a phy device dev_flags get the value preserved for use by the underlying
phy driver.

Acked-by: Kosta Zertsekel 
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller

ethtool: fix drvinfo strings set in drivers

2013-01-07T05:06:31+00:00

Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

dsa: Hide core config options; make drivers select what they need

2012-11-26T22:10:44+00:00

Commit 82167cb8c6b2f8166d5c7532e5ef4b5e0cc46a72 ('net: dsa/slave: Fix
compilation warnings') fixed one possible invalid configuration
(NET_DSA enabled with no trailer formats) but added others: drivers
can select NET_DSA without its dependencies being met.

It's not very useful to make either the DSA core or the tagging
formats manually selectable without a driver to use them, so:

1. Define a hidden HAVE_NET_DSA option and move the dependencies of
   NET_DSA to that.  While we're at it, drop the deprecated
   EXPERIMENTAL dependency.
2. Make NET_DSA and the drivers dependent on HAVE_NET_DSA.
3. Hide the tagging format options again.
4. Make drivers select both NET_DSA and the appropriate tagging format
   option.

Signed-off-by: Ben Hutchings 
Acked-by: Randy Dunlap 
Signed-off-by: David S. Miller