linux-toradex.git/net/ipv4/devinet.c, branch v2.6.25.2

[IPV4]: Reset scope when changing address

2008-02-27T02:42:41+00:00

This bug did bite at least one user, who did have to resort to rebooting
the system after an "ifconfig eth0 127.0.0.1" typo.

Deleting the address and adding a new is a less intrusive workaround.
But I still beleive this is a bug that should be fixed.  Some way or
another.

Another possibility would be to remove the scope mangling based on
address.  This will always be incomplete (are 127/8 the only address
space with host scope requirements?)

We set the scope to RT_SCOPE_HOST if an IPv4 interface is configured
with a loopback address (127/8).  The scope is never reset, and will
remain set to RT_SCOPE_HOST after changing the address. This patch
resets the scope if the address is changed again, to restore normal
functionality.

Signed-off-by: Bjorn Mork 
Signed-off-by: David S. Miller

[NETNS]: Process interface address manipulation routines in the namespace.

2008-02-01T03:28:39+00:00

The namespace is available when required except rtm_to_ifaddr. Add
namespace argument to it.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

2008-02-01T03:28:38+00:00

Remove error code assignment inside brackets on failure. The code
looks better if the error is assigned before condition check. Also,
the compiler treats this better.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[IPV4]: Make struct ipv4_devconf static.

2008-02-01T03:28:31+00:00

struct ipv4_devconf can now become static.

Signed-off-by: Adrian Bunk 
Acked-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

[NETNS]: Add netns parameter to inetdev_by_index.

2008-01-28T23:10:20+00:00

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[NETNS]: Process inet_confirm_addr in the correct namespace.

2008-01-28T23:02:13+00:00

inet_confirm_addr can be called with NULL in_dev from arp_ignore iff
scope is RT_SCOPE_LINK.

Lets always pass the device and check for RT_SCOPE_LINK scope inside
inet_confirm_addr. This let us take network namespace from in_device a
need for an additional argument.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[IPV4]: Remove extra argument from arp_ignore.

2008-01-28T23:02:12+00:00

arp_ignore has two arguments: dev & in_dev. dev is used for
inet_confirm_addr calling only.

inet_confirm_addr, in turn, either gets in_dev from the device passed
or iterates over all network devices if the device passed is NULL. It
seems logical to directly pass in_dev into inet_confirm_addr.

Signed-off-by: Denis V. Lunev 
Signed-off-by: David S. Miller

[NETNS]: Should build with CONFIG_SYSCTL=n

2008-01-28T23:00:40+00:00

Previous NETNS patches broke CONFIG_SYSCTL=n case

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

[IPV4] net/ipv4: Use ipv4_is_

2008-01-28T22:58:15+00:00

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

[IPV4]: Switch users of ipv4_devconf(_all) to use the pernet one

2008-01-28T22:58:12+00:00

These are scattered over the code, but almost all the
"critical" places already have the proper struct net
at hand except for snmp proc showing function and routing
rtnl handler.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller