linux-toradex.git/net/ipv4/icmp.c, branch v2.6.23.3

[ICMP]: Fix icmp_errors_use_inbound_ifaddr sysctl

2007-06-04T01:08:51+00:00

Currently when icmp_errors_use_inbound_ifaddr is set and an ICMP error is
sent after the packet passed through ip_output(), an address from the
outgoing interface is chosen as ICMP source address since skb->dev doesn't
point to the incoming interface anymore.

Fix this by doing an interface lookup on rt->dst.iif and using that device.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[IPV4]: icmp: fix crash with sysctl_icmp_errors_use_inbound_ifaddr

2007-05-19T21:44:15+00:00

When icmp_send is called on the local output path before the
packet hits ip_output, skb->dev is not set, causing a crash
when sysctl_icmp_errors_use_inbound_ifaddr is set. This can
happen with the netfilter REJECT target or IPsec tunnels.

Let routing decide the ICMP source address in that case, since the
packet is locally generated there is no inbound interface and
the sysctl should not apply.

The option actually seems to be unfixable broken, on the path
after ip_output() skb->dev points to the outgoing device and
we don't know the incoming device anymore, so its going to do
the absolute wrong thing and pick the address of the outgoing
interface. Add a comment about this.

Reported by Curtis Doty .

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[SK_BUFF]: Convert skb->tail to sk_buff_data_t

2007-04-26T05:26:28+00:00

So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
on 64bit architectures, allowing us to combine the 4 bytes hole left by the
layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
:-)

Many calculations that previously required that skb->{transport,network,
mac}_header be first converted to a pointer now can be done directly, being
meaningful as offsets or pointers.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce icmp_hdr(), remove skb->h.icmph

2007-04-26T05:25:23+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce ip_hdr(), remove skb->nh.iph

2007-04-26T05:25:10+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[SK_BUFF]: Introduce skb_network_header()

2007-04-26T05:24:59+00:00

For the places where we need a pointer to the network header, it is still legal
to touch skb->nh.raw directly if just adding to, subtracting from or setting it
to another layer header.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[NET] IPV4: Fix whitespace errors.

2007-02-11T07:19:39+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[NET]: Annotate callers of the reset of checksum.h stuff.

2006-12-03T05:23:34+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[NET]: Annotate callers of csum_fold() in net/*

2006-12-03T05:23:27+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller

[IPV4] net/ipv4/icmp.c: trivial annotations

2006-09-29T01:02:19+00:00

Signed-off-by: Al Viro 
Signed-off-by: David S. Miller