linux-toradex.git/net/ipv4/ipmr.c, branch v3.0.44

net: ipv4: ipmr_expire_timer causes crash when removing net namespace

2012-10-02T16:47:22+00:00

[ Upstream commit acbb219d5f53821b2d0080d047800410c0420ea1 ]

When tearing down a net namespace, ipv4 mr_table structures are freed
without first deactivating their timers. This can result in a crash in
run_timer_softirq.
This patch mimics the corresponding behaviour in ipv6.
Locking and synchronization seem to be adequate.
We are about to kfree mrt, so existing code should already make sure that
no other references to mrt are pending or can be created by incoming traffic.
The functions invoked here do not cause new references to mrt or other
race conditions to be created.
Invoking del_timer_sync guarantees that ipmr_expire_timer is inactive.
Both ipmr_expire_process (whose completion we may have to wait in
del_timer_sync) and mroute_clean_tables internally use mfc_unres_lock
or other synchronizations when needed, and they both only modify mrt.

Tested in Linux 3.4.8.

Signed-off-by: Francesco Ruggeri 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ipv4: use RT_TOS after some rt_tos conversions

2011-08-16T01:31:39+00:00

[ Upstream commit b0fe4a31849063fcac0bdc93716ca92615e93f57 ]

rt_tos was changed to iph->tos but it must be filtered by RT_TOS

Signed-off-by: Julian Anastasov 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ipv4: Pass explicit saddr/daddr args to ipmr_get_route().

2011-05-04T19:18:54+00:00

This eliminates the need to use rt->rt_{src,dst}.

Signed-off-by: David S. Miller

ipv4: Make caller provide on-stack flow key to ip_route_output_ports().

2011-05-04T03:25:42+00:00

Signed-off-by: David S. Miller

ipv4: Rework ipmr_rt_fib_lookup() flow key initialization.

2011-05-04T02:42:43+00:00

Use information from the skb as much as possible, currently
this means daddr, saddr, and TOS.

Signed-off-by: David S. Miller

inet: constify ip headers and in6_addr

2011-04-22T18:04:14+00:00

Add const qualifiers to structs iphdr, ipv6hdr and in6_addr pointers
where possible, to make code intention more obvious.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipv4: Use flowi4 in ipmr code.

2011-03-12T23:08:49+00:00

Signed-off-by: David S. Miller

net: Put flowi_* prefix on AF independent members of struct flowi

2011-03-12T23:08:44+00:00

I intend to turn struct flowi into a union of AF specific flowi
structs.  There will be a common structure that each variant includes
first, much like struct sock_common.

This is the first step to move in that direction.

Signed-off-by: David S. Miller

ipv4: Create and use route lookup helpers.

2011-03-12T23:08:42+00:00

The idea here is this minimizes the number of places one has to edit
in order to make changes to how flows are defined and used.

Signed-off-by: David S. Miller

ipv4: Lookup multicast routes by rtable using helper.

2011-03-09T22:06:20+00:00

Create a common helper for this operation, since we do
it identically in three spots.

Suggested by Eric Dumazet.

Signed-off-by: David S. Miller