linux-toradex.git/net/ipv4/tcp_diag.c, branch v4.4.142

tcp: ensure proper barriers in lockless contexts

2015-11-15T23:36:38+00:00

Some functions access TCP sockets without holding a lock and
might output non consistent data, depending on compiler and or
architecture.

tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() ...

Introduce sk_state_load() and sk_state_store() to fix the issues,
and more clearly document where this lack of locking is happening.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

sock_diag: implement a get_info handler for inet

2015-06-16T02:49:22+00:00

This get_info handler will simply dispatch to the appropriate
existing inet protocol handler.

This patch also includes a new netlink attribute
(INET_DIAG_PROTOCOL).  This attribute is currently only used
for multicast messages.  Without this attribute, there is no
way of knowing the IP protocol used by the socket information
being broadcast.  This attribute is not necessary in the 'dump'
variant of this protocol (though it could easily be added)
because dump requests are issued for specific family/protocol
pairs.

Tested: ss -E (note, the -E option has not yet been merged into
the upstream version of ss).

Signed-off-by: Craig Gallek 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

sock_diag: specify info_size per inet protocol

2015-06-16T02:49:22+00:00

Previously, there was no clear distinction between the inet protocols
that used struct tcp_info to report information and those that didn't.
This change adds a specific size attribute to the inet_diag_handler
struct which defines these interfaces.  This will make dispatching
sock_diag get_info requests identical for all inet protocols in a
following patch.

Tested: ss -au
Tested: ss -at
Signed-off-by: Craig Gallek 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

ipv4: coding style: comparison for inequality with NULL

2015-04-03T16:11:15+00:00

The ipv4 code uses a mixture of coding styles. In some instances check
for non-NULL pointer is done as x != NULL and sometimes as x. x is
preferred according to checkpatch and this patch makes the code
consistent by adopting the latter form.

No changes detected by objdiff.

Signed-off-by: Ian Morris 
Signed-off-by: David S. Miller

inet_diag: add const to inet_diag_req_v2

2015-03-10T17:45:28+00:00

diag dumpers should not modify the request.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

tcp: whitespace fixes

2014-09-02T01:12:45+00:00

Fix places where there is space before tab, long lines, and
awkward if(){, double spacing etc. Add blank line after declaration/initialization.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

inet_diag: Rename inet_diag_req into inet_diag_req_v2

2012-01-11T20:56:06+00:00

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

sock_diag: Fix module netlink aliases

2011-12-16T18:48:27+00:00

I've made a mistake when fixing the sock_/inet_diag aliases :(

1. The sock_diag layer should request the family-based alias,
   not just the IPPROTO_IP one;
2. The inet_diag layer should request for AF_INET+protocol alias,
   not just the protocol one.

Thus fix this.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

inet_diag: Generalize inet_diag dump and get_exact calls

2011-12-09T19:14:08+00:00

Introduce two callbacks in inet_diag_handler -- one for dumping all
sockets (with filters) and the other one for dumping a single sk.

Replace direct calls to icsk handlers with indirect calls to callbacks
provided by handlers.

Make existing TCP and DCCP handlers use provided helpers for icsk-s.

The UDP diag module will provide its own.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller

inet_diag: Remove indirect sizeof from inet diag handlers

2011-12-09T19:14:07+00:00

There's an info_size value stored on inet_diag_handler, but for existing
code this value is effectively constant, so just use sizeof(struct tcp_info)
where required.

Signed-off-by: Pavel Emelyanov 
Signed-off-by: David S. Miller