linux-toradex.git/net/ipv4, branch v2.6.16.42

[TCP]: struct tcp_sack_block annotations

2007-02-14T12:58:42+00:00

Some of the instances of tcp_sack_block are host-endian, some - net-endian.
Define struct tcp_sack_block_wire identical to struct tcp_sack_block
with u32 replaced with __be32; annotate uses of tcp_sack_block replacing
net-endian ones with tcp_sack_block_wire.  Change is obviously safe since
for cc(1) __be32 is typedefed to u32.

Signed-off-by: Al Viro 
Signed-off-by: Adrian Bunk

[NETFILTER]: Clear GSO bits for TCP reset packet

2007-02-14T08:39:09+00:00

The TCP reset packet is copied from the original.  This
includes all the GSO bits which do not apply to the new
packet.  So we should clear those bits.

Spotted by Patrick McHardy.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[TCP]: Don't apply FIN exception to full TSO segments.

2007-02-14T08:34:43+00:00

Signed-off-by: John Heffner 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

TCP: skb is unexpectedly freed.

2007-02-14T08:31:02+00:00

I encountered a kernel panic with my test program, which is a very
simple IPv6 client-server program.

The server side sets IPV6_RECVPKTINFO on a listening socket, and the
client side just sends a message to the server.  Then the kernel panic
occurs on the server.  (If you need the test program, please let me
know. I can provide it.)

This problem happens because a skb is forcibly freed in
tcp_rcv_state_process().

When a socket in listening state(TCP_LISTEN) receives a syn packet,
then tcp_v6_conn_request() will be called from
tcp_rcv_state_process().  If the tcp_v6_conn_request() successfully
returns, the skb would be discarded by __kfree_skb().

However, in case of a listening socket which was already set
IPV6_RECVPKTINFO, an address of the skb will be stored in
treq->pktopts and a ref count of the skb will be incremented in
tcp_v6_conn_request().  But, even if the skb is still in use, the skb
will be freed.  Then someone still using the freed skb will cause the
kernel panic.

I suggest to use kfree_skb() instead of __kfree_skb().

Signed-off-by: Masayuki Nakagawa 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

TCP: Fix sorting of SACK blocks.

2007-02-14T08:29:14+00:00

The sorting of SACK blocks actually munges them rather than sort,
causing the TCP stack to ignore some SACK information and breaking the
assumption of ordered SACK blocks after sorting.

The sort takes the data from a second buffer which isn't moved causing
subsequent data moves to occur from the wrong location. The fix is to
use a temporary buffer as a normal sort does.

Signed-off-By: Baruch Even 
Signed-off-by: David S. Miller

NETFILTER: arp_tables: missing unregistration on module unload

2007-01-22T20:39:03+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

NETFILTER: NAT: fix NOTRACK checksum handling

2007-01-20T21:18:30+00:00

The whole idea with the NOTRACK netfilter target is that
you can force the netfilter code to avoid connection
tracking, and all costs assosciated with it, by making
traffic match a NOTRACK rule.

But this is totally broken by the fact that we do a checksum
calculation over the packet before we do the NOTRACK bypass
check, which is very expensive.  People setup NOTRACK rules
explicitly to avoid all of these kinds of costs.

This patch from Patrick, already in Linus's tree, fixes the
bug.

Move the check for ip_conntrack_untracked before the call to
skb_checksum_help to fix NOTRACK excemptions from NAT. Pre-2.6.19
NAT code breaks TSO by invalidating hardware checksums for every
packet, even if explicitly excluded from NAT through NOTRACK.

2.6.19 includes a fix that makes NAT and TSO live in harmony,
but the performance degradation caused by this deserves making
at least the workaround work properly in -stable.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

TCP: Fix and simplify microsecond rtt sampling

2007-01-09T02:23:33+00:00

This changes the microsecond RTT sampling so that samples are taken in
the same way that RTT samples are taken for the RTO calculator: on the
last segment acknowledged, and only when the segment hasn't been
retransmitted.

Signed-off-by: John Heffner 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[IPV4/IPV6]: Fix inet{,6} device initialization order.

2007-01-09T02:23:31+00:00

It is important that we only assign dev->ip{,6}_ptr
only after all portions of the inet{,6} are setup.

Otherwise we can receive packets before the multicast
spinlocks et al. are initialized.

Signed-off-by: David L Stevens 
Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk

[IPV4] ip_fragment: Always compute hash with ipfrag_lock held.

2006-12-17T20:37:17+00:00

Otherwise we could compute an inaccurate hash due to the
random seed changing.

Noticed by Zach Brown and patch is based upon some feedback
from Herbert Xu.

Signed-off-by: David S. Miller 
Signed-off-by: Adrian Bunk