linux-toradex.git/net/ipv6/addrconf.c, branch v2.6.28.9

ipv6: fix run pending DAD when interface becomes ready

2008-11-05T09:43:57+00:00

With some net devices types, an IPv6 address configured while the
interface was down can stay 'tentative' forever, even after the interface
is set up. In some case, pending IPv6 DADs are not executed when the
device becomes ready.

I observed this while doing some tests with kvm. If I assign an IPv6 
address to my interface eth0 (kvm driver rtl8139) when it is still down
then the address is flagged tentative (IFA_F_TENTATIVE). Then, I set
eth0 up, and to my surprise, the address stays 'tentative', no DAD is
executed and the address can't be pinged.

I also observed the same behaviour, without kvm, with virtual interfaces
types macvlan and veth.

Some easy steps to reproduce the issue with macvlan:

1. ip link add link eth0 type macvlan
2. ip -6 addr add 2003::ab32/64 dev macvlan0
3. ip addr show dev macvlan0
   ... 
   inet6 2003::ab32/64 scope global tentative
   ...
4. ip link set macvlan0 up
5. ip addr show dev macvlan0
   ...
   inet6 2003::ab32/64 scope global tentative
   ...
   Address is still tentative

I think there's a bug in net/ipv6/addrconf.c, addrconf_notify():
addrconf_dad_run() is not always run when the interface is flagged IF_READY.
Currently it is only run when receiving NETDEV_CHANGE event. Looks like
some (virtual) devices doesn't send this event when becoming up.

For both NETDEV_UP and NETDEV_CHANGE events, when the interface becomes
ready, run_pending should be set to 1. Patch below.

'run_pending = 1' could be moved below the if/else block but it makes 
the code less readable.

Signed-off-by: Benjamin Thery 
Signed-off-by: David S. Miller

sysctl: simplify ->strategy

2008-10-16T18:21:47+00:00

name and nlen parameters passed to ->strategy hook are unused, remove
them.  In general ->strategy hook should know what it's doing, and don't
do something tricky for which, say, pointer to original userspace array
may be needed (name).

Signed-off-by: Alexey Dobriyan 
Acked-by: David S. Miller  [ networking bits ]
Cc: Ralf Baechle 
Cc: David Howells 
Cc: Matt Mackall 
Cc: "Eric W. Biederman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipv6: protocol for address routes

2008-08-23T12:16:46+00:00

This fixes a problem spotted with zebra, but not sure if it is
necessary a kernel problem.  With IPV6 when an address is added to an
interface, Zebra creates a duplicate RIB entry, one as a connected
route, and other as a kernel route.

When an address is added to an interface the RTN_NEWADDR message
causes Zebra to create a connected route. In IPV4 when an address is
added to an interface a RTN_NEWROUTE message is set to user space with
the protocol RTPROT_KERNEL. Zebra ignores these messages, because it
already has the connected route.

The problem is that route created in IPV6 has route protocol ==
RTPROT_BOOT.  Was this a design decision or a bug? This fixes it. Same
patch applies to both net-2.6 and stable.

Signed-off-by: Stephen Hemminger 
Signed-off-by: David S. Miller

netns: Add network namespace argument to rt6_fill_node() and ipv6_dev_get_saddr()

2008-08-14T22:33:21+00:00

ipv6_dev_get_saddr() blindly de-references dst_dev to get the network
namespace, but some callers might pass NULL.  Change callers to pass a
namespace pointer instead.

Signed-off-by: Brian Haley 
Signed-off-by: David S. Miller

net: convert BUG_TRAP to generic WARN_ON

2008-07-26T04:43:18+00:00

Removes legacy reinvent-the-wheel type thing. The generic
machinery integrates much better to automated debugging aids
such as kerneloops.org (and others), and is unambiguous due to
better naming. Non-intuively BUG_TRAP() is actually equal to
WARN_ON() rather than BUG_ON() though some might actually be
promoted to BUG_ON() but I left that to future.

I could make at least one BUILD_BUG_ON conversion.

Signed-off-by: Ilpo Järvinen 
Signed-off-by: David S. Miller

ipv6: make struct ipv6_devconf static

2008-07-22T21:21:58+00:00

struct ipv6_devconf can now become static.

Signed-off-by: Adrian Bunk 
Signed-off-by: David S. Miller

ipv6: Fix warning in addrconf code.

2008-07-21T04:18:26+00:00

Reported by Linus.

Signed-off-by: David S. Miller 
Signed-off-by: Linus Torvalds

ipv6 netns: Make several "global" sysctl variables namespace aware.

2008-07-20T05:35:03+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

pkt_sched: Add qdisc_tx_is_noop() helper and use in IPV6.

2008-07-09T06:01:27+00:00

This indicates if the NOOP scheduler is what is active for TX on a
given device.

Signed-off-by: David S. Miller

netdev: Move rest of qdisc state into struct netdev_queue

2008-07-09T00:42:10+00:00

Now qdisc, qdisc_sleeping, and qdisc_list also live there.

Signed-off-by: David S. Miller