linux-toradex.git/net/ipv6/af_inet6.c, branch v2.6.16.42

[IPV6]: Fix illegal dst locking in softirq context.

2006-02-03T01:01:13+00:00

On Tue, Jan 31, 2006 at 10:24:32PM +0100, Ingo Molnar wrote:
>
>  [] _write_lock+0x8/0x10
>  [] inet6_destroy_sock+0x25/0x100
>  [] tcp_v6_destroy_sock+0x12/0x20
>  [] inet_csk_destroy_sock+0x4a/0x150
>  [] tcp_rcv_state_process+0xd4c/0xdd0
>  [] tcp_v4_do_rcv+0xa9/0x340
>  [] tcp_v4_rcv+0x8eb/0x9d0

OK this is definitely broken.  We should never touch the dst lock in
softirq context.  Since inet6_destroy_sock may be called from that
context due to the asynchronous nature of sockets, we can't take the
lock there.

In fact this sk_dst_reset is totally redundant since all IPv6 sockets
use inet_sock_destruct as their socket destructor which always cleans
up the dst anyway.  So the solution is to simply remove the call.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[PATCH] capable/capability.h (net/)

2006-01-12T02:42:14+00:00

net: Use  where capable() is used.

Signed-off-by: Randy Dunlap 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] slab: remove unused align parameter from alloc_percpu

2006-01-09T04:12:39+00:00

__alloc_percpu and alloc_percpu both take an 'align' argument which is
completely ignored.  snmp6_mib_init() in net/ipv6/af_inet6.c attempts to use
it, but it will be ignored.  Therefore, remove the 'align' argument and fixup
the lone caller.

Signed-off-by: Matthew Dobson 
Acked-by: Manfred Spraul 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NET]: Add a dev_ioctl() fallback to sock_ioctl()

2006-01-03T22:18:33+00:00

Currently all network protocols need to call dev_ioctl as the default
fallback in their ioctl implementations.  This patch adds a fallback
to dev_ioctl to sock_ioctl if the protocol returned -ENOIOCTLCMD.
This way all the procotol ioctl handlers can be simplified and we don't
need to export dev_ioctl.

Signed-off-by: Christoph Hellwig 
Signed-off-by: David S. Miller

[NET]: move struct proto_ops to const

2006-01-03T21:11:15+00:00

I noticed that some of 'struct proto_ops' used in the kernel may share
a cache line used by locks or other heavily modified data. (default
linker alignement is 32 bytes, and L1_CACHE_LINE is 64 or 128 at
least)

This patch makes sure a 'struct proto_ops' can be declared as const,
so that all cpus can share all parts of it without false sharing.

This is not mandatory : a driver can still use a read/write structure
if it needs to (and eventually a __read_mostly)

I made a global stubstitute to change all existing occurences to make
them const.

This should reduce the possibility of false sharing on SMP, and
speedup some socket system calls.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

[IP_SOCKGLUE]: Remove most of the tcp specific calls

2006-01-03T21:10:58+00:00

As DCCP needs to be called in the same spots.

Now we have a member in inet_sock (is_icsk), set at sock creation time from
struct inet_protosw->flags (if INET_PROTOSW_ICSK is set, like for TCP and
DCCP) to see if a struct sock instance is a inet_connection_sock for places
like the ones in ip_sockglue.c (v4 and v6) where we previously were looking if
sk_type was SOCK_STREAM, that is insufficient because we now use the same code
for DCCP, that has sk_type SOCK_DCCP.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV6]: Export ipv6_opt_accepted

2006-01-03T21:10:51+00:00

It was already non-TCP specific, will be used by DCCPv6.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV6]: Export some symbols for DCCPv6

2006-01-03T21:10:48+00:00

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV6]: Generalise some functions

2006-01-03T21:10:46+00:00

Using sk->sk_protocol instead of IPPROTO_TCP.

Will be used by DCCPv6 in the next changesets.

Signed-off-by: Arnaldo Carvalho de Melo 
Signed-off-by: David S. Miller

[IPV6]: Load protocol module dynamically.

2005-12-03T04:56:57+00:00

[ Modified to match inet_create() bug fix by Herbert Xu -DaveM ]

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller