linux-toradex.git/net/ipv6/anycast.c, branch v4.9.33

ipv6: coding style: comparison for equality with NULL

2015-03-31T17:51:54+00:00

The ipv6 code uses a mixture of coding styles. In some instances check for NULL
pointer is done as x == NULL and sometimes as !x. !x is preferred according to
checkpatch and this patch makes the code consistent by adopting the latter
form.

No changes detected by objdiff.

Signed-off-by: Ian Morris 
Signed-off-by: David S. Miller

ipv6: invert join/leave anycast rtnl/socket locking order

2015-03-20T17:32:38+00:00

Commit baf606d9c9b1 ("ipv4,ipv6: grab rtnl before locking the socket")
missed to update two setsockopt options, IPV6_JOIN_ANYCAST and
IPV6_LEAVE_ANYCAST, causing a lock inverstion regarding to the updated ones.

As ipv6_sock_ac_join and ipv6_sock_ac_leave are only called from
do_ipv6_setsockopt, we are good to just move the rtnl lock upper.

Fixes: baf606d9c9b1 ("ipv4,ipv6: grab rtnl before locking the socket")
Reported-by: Ying Huang 
Signed-off-by: Marcelo Ricardo Leitner 
Signed-off-by: David S. Miller

ipv6: remove aca_lock spinlock from struct ifacaddr6

2014-10-14T17:15:15+00:00

no user uses this lock.

Signed-off-by: Li RongQing 
Signed-off-by: David S. Miller

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2014-09-23T16:09:27+00:00

Conflicts:
	arch/mips/net/bpf_jit.c
	drivers/net/can/flexcan.c

Both the flexcan and MIPS bpf_jit conflicts were cases of simple
overlapping changes.

Signed-off-by: David S. Miller

ipv6: refactor __ipv6_dev_ac_inc()

2014-09-13T20:38:42+00:00

Refactor out allocation and initialization and make
the refcount code more readable.

Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

ipv6: clean up ipv6_dev_ac_inc()

2014-09-13T20:38:42+00:00

Make it accept inet6_dev, and rename it to __ipv6_dev_ac_inc()
to reflect this change.

Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

ipv6: remove ipv6_sk_ac_lock

2014-09-13T20:38:42+00:00

Just move rtnl lock up, so that the anycast list can be protected
by rtnl lock now.

Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

ipv6: drop useless rcu_read_lock() in anycast

2014-09-13T20:38:42+00:00

These code is now protected by rtnl lock, rcu read lock
is useless now.

Signed-off-by: Cong Wang 
Signed-off-by: David S. Miller

ipv6: clean up anycast when an interface is destroyed

2014-09-12T21:33:06+00:00

If we try to rmmod the driver for an interface while sockets with
setsockopt(JOIN_ANYCAST) are alive, some refcounts aren't cleaned up
and we get stuck on:

  unregister_netdevice: waiting for ens3 to become free. Usage count = 1

If we LEAVE_ANYCAST/close everything before rmmod'ing, there is no
problem.

We need to perform a cleanup similar to the one for multicast in
addrconf_ifdown(how == 1).

Signed-off-by: Sabrina Dubroca 
Acked-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller

ipv6: restore the behavior of ipv6_sock_ac_drop()

2014-09-07T23:10:07+00:00

It is possible that the interface is already gone after joining
the list of anycast on this interface as we don't hold a refcount
for the device, in this case we are safe to ignore the error.

What's more important, for API compatibility we should not
change this behavior for applications even if it were correct.

Fixes: commit a9ed4a2986e13011 ("ipv6: fix rtnl locking in setsockopt for anycast and multicast")
Cc: Sabrina Dubroca 
Cc: David S. Miller 
Signed-off-by: Cong Wang 
Acked-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller