linux-toradex.git/net/ipv6/ndisc.c, branch v3.10.29

ipv6: Don't depend on per socket memory for neighbour discovery messages

2013-09-14T13:54:56+00:00

[ Upstream commit 25a6e6b84fba601eff7c28d30da8ad7cfbef0d43 ]

Allocating skbs when sending out neighbour discovery messages
currently uses sock_alloc_send_skb() based on a per net namespace
socket and thus share a socket wmem buffer space.

If a netdevice is temporarily unable to transmit due to carrier
loss or for other reasons, the queued up ndisc messages will cosnume
all of the wmem space and will thus prevent from any more skbs to
be allocated even for netdevices that are able to transmit packets.

The number of neighbour discovery messages sent is very limited,
use of alloc_skb() bypasses the socket wmem buffer size enforcement
while the manual call to skb_set_owner_w() maintains the socket
reference needed for the IPv6 output path.

This patch has orginally been posted by Eric Dumazet in a modified
form.

Signed-off-by: Thomas Graf 
Cc: Eric Dumazet 
Cc: Hannes Frederic Sowa 
Cc: Stephen Warren 
Cc: Fabio Estevam 
Tested-by: Fabio Estevam 
Tested-by: Stephen Warren 
Acked-by: Hannes Frederic Sowa 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

ipv6: ndisc: fix ndisc_send_redirect writing to the wrong skb

2013-06-18T05:59:12+00:00

Since some refactoring in 5f5a011, ndisc_send_redirect called
ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or
in the worst case a panic when the skb_put failed.

Signed-off-by: Matthias Schiffer 
Reviewed-by: Cong Wang 
Signed-off-by: David S. Miller

ipv6: ndisc: remove redundant check for !dev->addr_len

2013-03-08T17:29:22+00:00

send_sllao is already initialized with the value of dev->addr_len

Cc: Hideaki YOSHIFUJI 
Signed-off-by: Thomas Graf 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Use compound literals to build redirect message.

2013-01-21T18:33:18+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Break down ndisc_build_skb() and build message directly.

2013-01-21T18:33:18+00:00

Construct NS/NA/RS message directly using C99 compound literals.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Break down __ndisc_send().

2013-01-21T18:33:17+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Fill in ICMPv6 checksum and IPv6 header in ndisc_send_skb().

2013-01-21T18:33:17+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Use ndisc_send_skb() for redirect.

2013-01-21T18:33:17+00:00

Reuse dst if one is attached with skb.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Remove icmp6h argument from ndisc_send_skb().

2013-01-21T18:33:17+00:00

skb_transport_header() (thus icmp6_hdr()) is available here,
use it.

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

ndisc: Make ndisc_fill_xxx_option() for sk_buff.

2013-01-21T18:33:16+00:00

Signed-off-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller