linux-toradex.git/net/ipv6, branch v2.6.18-rc4

[IPV6]: SNMPv2 "ipv6IfStatsOutFragCreates" counter error

2006-08-02T20:41:21+00:00

  When I tested linux kernel 2.6.71.7 about statistics
"ipv6IfStatsOutFragCreates", and found that it couldn't increase
correctly. The criteria is RFC 2465:

  ipv6IfStatsOutFragCreates OBJECT-TYPE
      SYNTAX      Counter32
      MAX-ACCESS  read-only
      STATUS      current
      DESCRIPTION
         "The number of output datagram fragments that have
         been generated as a result of fragmentation at
         this output interface."
      ::= { ipv6IfStatsEntry 15 }

I think there are two issues in Linux kernel. 
1st:
RFC2465 specifies the counter is "The number of output datagram
fragments...". I think increasing this counter after output a fragment
successfully is better. And it should not be increased even though a
fragment is created but failed to output.

2nd:
If we send a big ICMP/ICMPv6 echo request to a host, and receive
ICMP/ICMPv6 echo reply consisted of some fragments. As we know that in
Linux kernel first fragmentation occurs in ICMP layer(maybe saying
transport layer is better), but this is not the "real"
fragmentation,just do some "pre-fragment" -- allocate space for date,
and form a frag_list, etc. The "real" fragmentation happens in IP layer
-- set offset and MF flag and so on. So I think in "fast path" for
ip_fragment/ip6_fragment, if we send a fragment which "pre-fragment" by
upper layer we should also increase "ipv6IfStatsOutFragCreates".

Signed-off-by: Wei Dong 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[IPV6]: SNMPv2 "ipv6IfStatsInHdrErrors" counter error

2006-08-02T20:39:57+00:00

  When I tested Linux kernel 2.6.17.7 about statistics
"ipv6IfStatsInHdrErrors", found that this counter couldn't increase
correctly. The criteria is RFC2465:
  ipv6IfStatsInHdrErrors OBJECT-TYPE
      SYNTAX     Counter3
      MAX-ACCESS read-only
      STATUS     current
      DESCRIPTION
         "The number of input datagrams discarded due to
         errors in their IPv6 headers, including version
         number mismatch, other format errors, hop count
         exceeded, errors discovered in processing their
         IPv6 options, etc."
      ::= { ipv6IfStatsEntry 2 }

When I send TTL=0 and TTL=1 a packet to a router which need to be
forwarded, router just sends an ICMPv6 message to tell the sender that
TIME_EXCEED and HOPLIMITS, but no increments for this counter(in the
function ip6_forward).

Signed-off-by: Wei Dong 
Acked-by: YOSHIFUJI Hideaki 
Signed-off-by: David S. Miller

[NET]: Core net changes to generate netevents

2006-08-02T20:38:21+00:00

Generate netevents for:
- neighbour changes
- routing redirects
- pmtu changes

Signed-off-by: Tom Tucker 
Signed-off-by: Steve Wise 
Signed-off-by: David S. Miller

[TCP]: SNMPv2 tcpAttemptFails counter error

2006-08-02T20:38:19+00:00

Refer to RFC2012, tcpAttemptFails is defined as following:
  tcpAttemptFails OBJECT-TYPE
      SYNTAX      Counter32
      MAX-ACCESS  read-only
      STATUS      current
      DESCRIPTION
              "The number of times TCP connections have made a direct
              transition to the CLOSED state from either the SYN-SENT
              state or the SYN-RCVD state, plus the number of times TCP
              connections have made a direct transition to the LISTEN
              state from the SYN-RCVD state."
      ::= { tcp 7 }

When I lookup into RFC793, I found that the state change should occured
under following condition:
  1. SYN-SENT -> CLOSED
     a) Received ACK,RST segment when SYN-SENT state.

  2. SYN-RCVD -> CLOSED
     b) Received SYN segment when SYN-RCVD state(came from LISTEN).
     c) Received RST segment when SYN-RCVD state(came from SYN-SENT).
     d) Received SYN segment when SYN-RCVD state(came from SYN-SENT).

  3. SYN-RCVD -> LISTEN
     e) Received RST segment when SYN-RCVD state(came from LISTEN).

In my test, those direct state transition can not be counted to
tcpAttemptFails.

Signed-off-by: Wei Yongjun 
Signed-off-by: David S. Miller

[IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-08-02T20:38:14+00:00

The current users of ip6_dst_lookup can be divided into two classes:

1) The caller holds no locks and is in user-context (UDP).
2) The caller does not want to lookup the dst cache at all.

The second class covers everyone except UDP because most people do
the cache lookup directly before calling ip6_dst_lookup.  This patch
adds ip6_sk_dst_lookup for the first class.

Similarly ip6_dst_store users can be divded into those that need to
take the socket dst lock and those that don't.  This patch adds
__ip6_dst_store for those (everyone except UDP/datagram) that don't
need an extra lock.

Signed-off-by: Herbert Xu 
Signed-off-by: David S. Miller

[XFRM]: Fix protocol field value for outgoing IPv6 GSO packets

2006-08-02T20:38:13+00:00

Signed-off-by: Patrick McHardy 
Acked-by: Herbert Xu 
Signed-off-by: David S. Miller

[IPV6] ADDRCONF: NLM_F_REPLACE support for RTM_NEWADDR

2006-08-02T20:38:12+00:00

Based on MIPL2 kernel patch.

Signed-off-by: Noriaki YAKAMIYA 
Signed-off-by: YOSHIFUJI Hideaki

[IPV6] ADDRCONF: Support get operation of single address

2006-08-02T20:38:11+00:00

Based on MIPL2 kernel patch.

Signed-off-by: Noriaki TAKAMIYA 
Signed-off-by: YOSHIFUJI Hideaki

[IPV6] ADDRCONF: Do not verify an address with infinity lifetime

2006-08-02T20:38:10+00:00

We also do not try regenarating new temporary address corresponding to an
address with infinite preferred lifetime.

Signed-off-by: YOSHIFUJI Hideaki

[IPV6] ADDRCONF: Allow user-space to specify address lifetime

2006-08-02T20:38:09+00:00

Based on MIPL2 kernel patch.

Signed-off-by: Noriaki TAKAMIYA 
Signed-off-by: YOSHIFUJI Hideaki