linux-toradex.git/net/irda, branch v2.6.19.2

[PATCH] IrDA: Incorrect TTP header reservation

2006-12-11T19:32:39+00:00

We must reserve SAR + MAX_HEADER bytes for IrLMP to fit in.
This fixes an oops reported (and fixed) by Jeet Chaudhuri, when max_sdu_size
is greater than 0.

Signed-off-by: Samuel Ortiz 
Signed-off-by: David S. Miller 
Signed-off-by: Chris Wright

[IRDA]: Lockdep fix.

2006-11-22T01:33:01+00:00

On Sat, 2006-11-18 at 16:12 +0300, Andrey Borzenkov wrote:

> =============================================
> [ INFO: possible recursive locking detected ]
> 2.6.19-rc5-2avb #2
> - ---------------------------------------------
> pppd/26425 is trying to acquire lock:
>  (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x5a/0x170
> [irda]
>
> but task is already holding lock:
>  (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x37/0x170
> [irda]
>
> other info that might help us debug this:
> 1 lock held by pppd/26425:
>  #0:  (&hashbin->hb_spinlock){....}, at: []
> irlmp_slsap_inuse+0x37/0x170 [irda]
>
> stack backtrace:
>  [] dump_trace+0x1cc/0x200
>  [] show_trace_log_lvl+0x1a/0x30
>  [] show_trace+0x12/0x20
>  [] dump_stack+0x19/0x20
>  [] __lock_acquire+0x8fa/0xc20
>  [] lock_acquire+0x5d/0x80
>  [] _spin_lock+0x2c/0x40
>  [] irlmp_slsap_inuse+0x5a/0x170 [irda]
>  [] irlmp_open_lsap+0x62/0x180 [irda]
>  [] irttp_open_tsap+0x181/0x230 [irda]
>  [] ircomm_open_tsap+0x5d/0xa0 [ircomm]
>  [] ircomm_open+0xb8/0xd0 [ircomm]
>  [] ircomm_tty_open+0x4f7/0x570 [ircomm_tty]
>  [] tty_open+0x174/0x340
>  [] chrdev_open+0x89/0x170
>  [] __dentry_open+0xa6/0x1d0
>  [] nameidata_to_filp+0x35/0x40
>  [] do_filp_open+0x49/0x50
>  [] do_sys_open+0x47/0xd0
>  [] sys_open+0x1c/0x20
>  [] sysenter_past_esp+0x56/0x8d
>  [] 0xb7f86410
>  =======================

The comment at the nesting lock says:

	/* Careful for priority inversions here !
	 * irlmp->links is never taken while another IrDA
	 * spinlock is held, so we are safe. Jean II */

So, under the assumption the author was right, it just needs a lockdep
annotation.

Signed-off-by: Peter Zijlstra 
Acked-by: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

[PATCH] strndup() would better take size_t, not int

2006-10-10T22:37:24+00:00

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

[PATCH] const struct tty_operations

2006-10-02T14:57:14+00:00

As part of an SMP cleanliness pass over UML, I consted a bunch of
structures in order to not have to document their locking.  One of these
structures was a struct tty_operations.  In order to const it in UML
without introducing compiler complaints, the declaration of
tty_set_operations needs to be changed, and then all of its callers need to
be fixed.

This patch declares all struct tty_operations in the tree as const.  In all
cases, they are static and used only as input to tty_set_operations.  As an
extra check, I ran an i386 allyesconfig build which produced no extra
warnings.

53 drivers are affected.  I checked the history of a bunch of them, and in
most cases, there have been only a handful of maintenance changes in the
last six months.  serial_core.c was the busiest one that I looked at.

Signed-off-by: Jeff Dike 
Acked-by: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[IrDA]: Memory allocations cleanups

2006-09-29T01:02:48+00:00

This patch replaces the bunch of arbitrary 64 and 128 bytes alloc_skb() calls
with more accurate allocation sizes.

Signed-off-by: Samuel Ortiz 
Signed-off-by: David S. Miller

[IrDA]: af_irda.c cleanups

2006-09-29T01:02:46+00:00

We lock the socket when both releasing and getting a disconnected
notification. In the latter case, we also ste the socket as orphan.
This fixes a potential kernel bug that can be triggered when we get the
disconnection notification before closing the socket.

Signed-off-by: Samuel Ortiz 
Signed-off-by: David S. Miller

[NET]: Conversions from kmalloc+memset to k(z|c)alloc.

2006-07-21T21:51:30+00:00

Signed-off-by: Panagiotis Issaris 
Signed-off-by: David S. Miller

[IrDA]: Use alloc_skb() in IrDA TX path

2006-07-21T21:50:41+00:00

As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be
used for allocating TX sk_buff. The IrDA stack was exclusively calling
dev_alloc_skb() on the TX path, and this patch fixes that.

Signed-off-by: Samuel Ortiz 
Signed-off-by: David S. Miller

Remove obsolete #include

2006-06-30T17:25:36+00:00

Signed-off-by: Jörn Engel 
Signed-off-by: Adrian Bunk

[IrDA]: Fix RCU lock pairing on error path

2006-06-30T00:02:31+00:00

irlan_client_discovery_indication calls rcu_read_lock and rcu_read_unlock, but
returns without unlocking in an error case.  Fix that by replacing the return
with a goto so that the rcu_read_unlock always gets executed.

Signed-off-by: Josh Triplett 
Acked-by: Paul E. McKenney 
Signed-off-by: Samuel Ortiz samuel@sortiz.org <>
Signed-off-by: David S. Miller