linux-toradex.git/net/irda, branch v3.0.44

irda: iriap: Use seperate lockdep class for irias_objects->hb_spinlock

2011-06-07T00:00:35+00:00

The SEQ output functions grab the obj->attrib->hb_spinlock lock of
sub-objects found in the hash traversal.  These locks are in a different
realm than the one used for the irias_objects hash table itself.

So put the latter into it's own lockdep class.

Reported-by: Dave Jones 
Signed-off-by: David S. Miller

irda: Fix error propagation in ircomm_lmp_connect_response()

2011-05-19T22:58:39+00:00

The variable 'ret' is set but unused, and this pointed out that
errors from irlmp_connect_response() are not propagated to the
caller.

Note that this is currently academic since irlmp_connect_response()
always returns 0. :-)

Signed-off-by: David S. Miller

irda: Kill set but unused variable 'bytes' in irlan_check_command_param()

2011-05-19T22:53:58+00:00

Signed-off-by: David S. Miller

irda: Kill set but unused variable 'clen' in ircomm_connect_indication()

2011-05-19T22:52:59+00:00

Signed-off-by: David S. Miller

irda: Kill set but unused vars 'saddr' and 'daddr' in irlan_provider_connect_indication()

2011-05-19T22:46:41+00:00

Signed-off-by: David S. Miller

net/irda/ircomm_tty.c: Use flip buffers to deliver data

2011-05-12T22:02:51+00:00

use tty_insert_flip_string and tty_flip_buffer_push to deliver incoming data
packets from the IrDA device instead of delivering the packets directly to the
line discipline. Following later approach resulted in warning "Sleeping function
called from invalid context".

Signed-off-by: Amit Virdi 
Acked-by: Alan Cox 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2011-04-19T07:21:33+00:00

Conflicts:
	drivers/net/bnx2x/bnx2x_ethtool.c

irda: irproc: Fix set-but-unused variables.

2011-04-17T23:59:50+00:00

The variable 'd' is set but unused in irda_proc_register().

Just kill it off.

Signed-off-by: David S. Miller

irda: irlap_event: Fix set-but-unused variables.

2011-04-17T23:59:09+00:00

The variable 'ret' is set but unused in irlap_state_sclose().

Just kill it off.

Signed-off-by: David S. Miller

irda: fix locking unbalance in irda_sendmsg

2011-04-12T22:29:54+00:00

5b40964eadea40509d353318d2c82e8b7bf5e8a5 ("irda: Remove BKL instances
from af_irda.c") introduced a path where we have a locking unbalance.
If we pass invalid flags, we unlock a socket we never locked,
resulting in this...

=====================================
[ BUG: bad unlock balance detected! ]
-------------------------------------
trinity/20101 is trying to release lock (sk_lock-AF_IRDA) at:
[] irda_sendmsg+0x207/0x21d [irda]
but there are no more locks to release!

other info that might help us debug this:
no locks held by trinity/20101.

stack backtrace:
Pid: 20101, comm: trinity Not tainted 2.6.39-rc3+ #3
Call Trace:
 [] ? irda_sendmsg+0x207/0x21d [irda]
 [] print_unlock_inbalance_bug+0xc7/0xd2
 [] ? irda_sendmsg+0x207/0x21d [irda]
 [] lock_release+0xcf/0x18e
 [] release_sock+0x2d/0x155
 [] irda_sendmsg+0x207/0x21d [irda]
 [] __sock_sendmsg+0x69/0x75
 [] sock_sendmsg+0xa1/0xb6
 [] ? might_fault+0x5c/0xac
 [] ? lock_release+0x181/0x18e
 [] ? might_fault+0xa5/0xac
 [] ? might_fault+0x5c/0xac
 [] ? fcheck_files+0xb9/0xf0
 [] ? copy_from_user+0x2f/0x31
 [] ? verify_iovec+0x52/0xa6
 [] sys_sendmsg+0x23a/0x2b8
 [] ? lock_release+0x181/0x18e
 [] ? up_read+0x28/0x2c
 [] ? do_page_fault+0x360/0x3b4
 [] ? trace_hardirqs_on_caller+0x10b/0x12f
 [] ? finish_task_switch+0xb2/0xe3
 [] ? finish_task_switch+0x46/0xe3
 [] ? trace_hardirqs_off_caller+0x33/0x90
 [] ? retint_swapgs+0x13/0x1b
 [] ? trace_hardirqs_on_caller+0x10b/0x12f
 [] ? audit_syscall_entry+0x11c/0x148
 [] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [] system_call_fastpath+0x16/0x1b

Signed-off-by: Dave Jones 
Signed-off-by: David S. Miller