linux-toradex.git/net/irda, branch v3.0.95 Linux kernel for Apalis and Colibri modules irda: Fix missing msg_namelen update in irda_recvmsg_dgram() 2013-05-01T15:56:39+00:00 Mathias Krause minipli@googlemail.com 2013-04-07T01:51:53+00:00 65f4ea22548ffdd868d9d98cf91f50bc9978fb69 [ Upstream commit 5ae94c0d2f0bed41d6718be743985d61b7f5c47d ] The current code does not fill the msg_name member in case it is set. It also does not set the msg_namelen member to 0 and therefore makes net/socket.c leak the local, uninitialized sockaddr_storage variable to userland -- 128 bytes of kernel stack memory. Fix that by simply setting msg_namelen to 0 as obviously nobody cared about irda_recvmsg_dgram() not filling the msg_name in case it was set. Signed-off-by: Mathias Krause <minipli@googlemail.com> Cc: Samuel Ortiz <samuel@sortiz.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
[ Upstream commit 5ae94c0d2f0bed41d6718be743985d61b7f5c47d ]

The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about irda_recvmsg_dgram() not filling the msg_name in case it was
set.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/irda: add missing error path release_sock call 2013-04-05T17:16:37+00:00 Kees Cook keescook@chromium.org 2013-03-20T05:19:24+00:00 c7eff9734960f1730b0373b2635e8e055592c318 commit 896ee0eee6261e30c3623be931c3f621428947df upstream. This makes sure that release_sock is called for all error conditions in irda_getsockopt. Signed-off-by: Kees Cook <keescook@chromium.org> Reported-by: Brad Spengler <spender@grsecurity.net> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 896ee0eee6261e30c3623be931c3f621428947df upstream.

This makes sure that release_sock is called for all error conditions in
irda_getsockopt.

Signed-off-by: Kees Cook <keescook@chromium.org>
Reported-by: Brad Spengler <spender@grsecurity.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
irda: iriap: Use seperate lockdep class for irias_objects->hb_spinlock 2011-06-07T00:00:35+00:00 David S. Miller davem@davemloft.net 2011-06-07T00:00:35+00:00 79b3891587741dfac72cdfead1f2764b56a567b0 The SEQ output functions grab the obj->attrib->hb_spinlock lock of sub-objects found in the hash traversal. These locks are in a different realm than the one used for the irias_objects hash table itself. So put the latter into it's own lockdep class. Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
The SEQ output functions grab the obj->attrib->hb_spinlock lock of
sub-objects found in the hash traversal.  These locks are in a different
realm than the one used for the irias_objects hash table itself.

So put the latter into it's own lockdep class.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
irda: Fix error propagation in ircomm_lmp_connect_response() 2011-05-19T22:58:39+00:00 David S. Miller davem@davemloft.net 2011-05-19T22:58:39+00:00 8ce6eb1a4a4bc46820f23e927377d386d3ec5404 The variable 'ret' is set but unused, and this pointed out that errors from irlmp_connect_response() are not propagated to the caller. Note that this is currently academic since irlmp_connect_response() always returns 0. :-) Signed-off-by: David S. Miller <davem@davemloft.net> 
The variable 'ret' is set but unused, and this pointed out that
errors from irlmp_connect_response() are not propagated to the
caller.

Note that this is currently academic since irlmp_connect_response()
always returns 0. :-)

Signed-off-by: David S. Miller <davem@davemloft.net>
irda: Kill set but unused variable 'bytes' in irlan_check_command_param() 2011-05-19T22:53:58+00:00 David S. Miller davem@davemloft.net 2011-05-19T22:53:58+00:00 ad6376434c945495ea8c4082ad8a392cc58c3406 Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>
irda: Kill set but unused variable 'clen' in ircomm_connect_indication() 2011-05-19T22:52:59+00:00 David S. Miller davem@davemloft.net 2011-05-19T22:52:59+00:00 bfad6ef6d29e776472b3ead1f5bc920c5410ed2c Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>
irda: Kill set but unused vars 'saddr' and 'daddr' in irlan_provider_connect_indication() 2011-05-19T22:46:41+00:00 David S. Miller davem@davemloft.net 2011-05-19T22:46:41+00:00 fa7479cf48103ee9261398034528495966bd7d2d Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: David S. Miller <davem@davemloft.net>
net/irda/ircomm_tty.c: Use flip buffers to deliver data 2011-05-12T22:02:51+00:00 Amit Virdi amit.virdi@st.com 2011-05-12T01:04:40+00:00 cbfd1526f6076ece92b4e2dcc0a2f1e89041b3bd use tty_insert_flip_string and tty_flip_buffer_push to deliver incoming data packets from the IrDA device instead of delivering the packets directly to the line discipline. Following later approach resulted in warning "Sleeping function called from invalid context". Signed-off-by: Amit Virdi <amit.virdi@st.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
use tty_insert_flip_string and tty_flip_buffer_push to deliver incoming data
packets from the IrDA device instead of delivering the packets directly to the
line discipline. Following later approach resulted in warning "Sleeping function
called from invalid context".

Signed-off-by: Amit Virdi <amit.virdi@st.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6 2011-04-19T07:21:33+00:00 David S. Miller davem@davemloft.net 2011-04-19T07:21:33+00:00 e1943424e43974f85b82bb31eaf832823bf49ce7 Conflicts: drivers/net/bnx2x/bnx2x_ethtool.c 
Conflicts:
	drivers/net/bnx2x/bnx2x_ethtool.c
irda: irproc: Fix set-but-unused variables. 2011-04-17T23:59:50+00:00 David S. Miller davem@davemloft.net 2011-04-17T23:59:50+00:00 6385969b3297287e6259a012671be09c78c20620 The variable 'd' is set but unused in irda_proc_register(). Just kill it off. Signed-off-by: David S. Miller <davem@davemloft.net> 
The variable 'd' is set but unused in irda_proc_register().

Just kill it off.

Signed-off-by: David S. Miller <davem@davemloft.net>